Initial action to build containers for tag pushes #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCrank
requested review from
christian-oudard,
joekottke,
eranrund,
briancorbin and
jgreat
briancorbin
approved these changes
Feb 17, 2022
|
@briancorbin Just double checking some things and realized I put the wrong secret name. Just pushed an update to fix that error. |
briancorbin
added a commit
that referenced
this pull request
Mar 4, 2022
* adding max limit to some API endpoints (#248) * Remove unnecessary foreign keys from gift_codes table. (#249) * Update readme installation instructions (#250) * Enable foreign key constraints. Fix transient FK errors when deleting an account. (#251) * Remove foreign key check before running migrations. This allows databases with existing foreign key errors to be fixed by the migrations. (#252) * Fix a bug causing sync to create many tiny chunks. (#253) * Remove target block arg from manually sync account fn (#255) * Initial action to build containers for tag pushes (#256) * Supporting FOG enabled accounts (#254) * FOG Creds default to empty string if not provided from API (#257) * update readme (#259) * Api key guard (#205) * fixing issue with ledger not syncing automatically (#261) * sync up to the last block instead of excluding it (#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soundtrack of this PR: Fantasy Ambient
Motivation
Currently there is no automated build of Docker images for Full-Service so updates lag behind the code. This adds a github action to build and publish docker images when a tag is pushed
In this PR
-testnetand-mainnetsuffixes to the images for better clarification.testsjob placeholder for Mikey who is currently working on some stress tests.developandfeature/**filters so when the tests are put in they should run for any push to those branches. This is also just a placeholder and should be adjusted when the test action is created if need be for any additional branches (main?)Future Work