Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware-wallet/base #833

Merged
merged 3 commits into from
Sep 27, 2023
Merged

hardware-wallet/base #833

merged 3 commits into from
Sep 27, 2023

Conversation

briancorbin
Copy link
Contributor

@briancorbin briancorbin commented Apr 27, 2023

Addition of the ledger-mob submodule to support other PRs in ledger hardware wallet support

@briancorbin
Copy link
Contributor Author

briancorbin commented Apr 27, 2023

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch coverage: 74.33% and project coverage change: +0.23 🎉

Comparison is base (ab2af32) 60.12% compared to head (1e417de) 60.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   60.12%   60.36%   +0.23%     
==========================================
  Files          88       95       +7     
  Lines       12356    13011     +655     
  Branches     2010     2117     +107     
==========================================
+ Hits         7429     7854     +425     
- Misses       3238     3442     +204     
- Partials     1689     1715      +26     
Impacted Files Coverage Δ
full-service/src/db/models.rs 29.57% <0.00%> (-1.86%) ⬇️
full-service/src/db/schema.rs 21.53% <0.00%> (ø)
full-service/src/db/wallet_db_error.rs 8.00% <0.00%> (-0.70%) ⬇️
full-service/src/json_rpc/v1/models/amount.rs 52.08% <0.00%> (-4.44%) ⬇️
...service/src/json_rpc/v1/models/receiver_receipt.rs 80.35% <ø> (+3.57%) ⬆️
full-service/src/json_rpc/v2/api/request.rs 51.35% <0.00%> (-18.72%) ⬇️
full-service/src/json_rpc/v2/api/response.rs 0.00% <0.00%> (ø)
...ll-service/src/json_rpc/v2/models/masked_amount.rs 50.00% <0.00%> (-4.55%) ⬇️
...service/src/json_rpc/v2/models/receiver_receipt.rs 79.62% <ø> (+3.70%) ⬆️
full-service/src/json_rpc/v2/models/tx_proposal.rs 67.59% <0.00%> (ø)
... and 42 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@briancorbin briancorbin marked this pull request as ready for review September 26, 2023 22:14
@briancorbin briancorbin merged commit 499d539 into main Sep 27, 2023
9 checks passed
@briancorbin briancorbin deleted the feature/hw/base branch September 27, 2023 19:35
@briancorbin briancorbin added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants