Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hw wallet account check prior to executing operations #919

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

briancorbin
Copy link
Contributor

@briancorbin briancorbin commented Sep 25, 2023

This adds a check to make sure the account is the expected one prior to executing the operations.

@briancorbin
Copy link
Contributor Author

@briancorbin briancorbin marked this pull request as ready for review September 26, 2023 22:14
@briancorbin briancorbin force-pushed the feature/hw/check-account branch from a9b8f9e to bf5e524 Compare September 26, 2023 22:18
@briancorbin briancorbin force-pushed the feature/hw/check-account branch from bf5e524 to cb79479 Compare September 26, 2023 22:25
@briancorbin briancorbin force-pushed the feature/hw/check-account branch from cb79479 to 0d00b23 Compare September 30, 2023 18:46
@briancorbin briancorbin force-pushed the feature/hw/check-account branch from 0d00b23 to 79031db Compare September 30, 2023 18:53
Base automatically changed from feature/hw/cli to main October 2, 2023 20:57
@briancorbin briancorbin force-pushed the feature/hw/check-account branch from 79031db to 49ab266 Compare October 2, 2023 20:58
@codecov-commenter
Copy link

Codecov Report

Attention: 277 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (49ab266) 54.62%.
Report is 145 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   60.12%   54.62%   -5.51%     
==========================================
  Files          88      116      +28     
  Lines       12356    14803    +2447     
  Branches     2010     2550     +540     
==========================================
+ Hits         7429     8086     +657     
- Misses       3238     4847    +1609     
- Partials     1689     1870     +181     
Files Coverage Δ
full-service/src/db/gift_code.rs 67.85% <100.00%> (+1.19%) ⬆️
full-service/src/json_rpc/v1/api/request.rs 76.98% <100.00%> (-1.59%) ⬇️
...service/src/json_rpc/v1/models/receiver_receipt.rs 77.77% <ø> (+0.99%) ⬆️
full-service/src/json_rpc/v1/models/tx_proposal.rs 73.56% <100.00%> (+0.30%) ⬆️
full-service/src/json_rpc/v1/models/txo.rs 57.27% <100.00%> (+2.72%) ⬆️
full-service/src/json_rpc/v2/api/test_utils.rs 84.61% <100.00%> (ø)
full-service/src/json_rpc/v2/models/account.rs 46.42% <ø> (-2.23%) ⬇️
full-service/src/json_rpc/v2/models/account_key.rs 47.05% <ø> (+0.76%) ⬆️
...ll-service/src/json_rpc/v2/models/masked_amount.rs 50.00% <ø> (-4.55%) ⬇️
...l-service/src/json_rpc/v2/models/network_status.rs 55.00% <ø> (-1.25%) ⬇️
... and 44 more

... and 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briancorbin briancorbin merged commit 142f8dc into main Oct 2, 2023
5 of 6 checks passed
@briancorbin briancorbin deleted the feature/hw/check-account branch October 2, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants