-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hw wallet account check prior to executing operations #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancorbin
force-pushed
the
feature/hw/check-account
branch
from
September 25, 2023 21:34
f7fadfb
to
a9b8f9e
Compare
This was referenced Sep 25, 2023
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
briancorbin
requested review from
eranrund and
christian-oudard
as code owners
September 26, 2023 22:14
briancorbin
force-pushed
the
feature/hw/cli
branch
from
September 26, 2023 22:18
4eeb948
to
db2ee9f
Compare
briancorbin
force-pushed
the
feature/hw/check-account
branch
from
September 26, 2023 22:18
a9b8f9e
to
bf5e524
Compare
briancorbin
force-pushed
the
feature/hw/cli
branch
from
September 26, 2023 22:25
db2ee9f
to
d08e52d
Compare
briancorbin
force-pushed
the
feature/hw/check-account
branch
from
September 26, 2023 22:25
bf5e524
to
cb79479
Compare
briancorbin
force-pushed
the
feature/hw/cli
branch
from
September 30, 2023 18:45
d08e52d
to
2fe71b3
Compare
briancorbin
force-pushed
the
feature/hw/check-account
branch
from
September 30, 2023 18:46
cb79479
to
0d00b23
Compare
briancorbin
force-pushed
the
feature/hw/cli
branch
from
September 30, 2023 18:52
2fe71b3
to
ad4c2ad
Compare
briancorbin
force-pushed
the
feature/hw/check-account
branch
from
September 30, 2023 18:53
0d00b23
to
79031db
Compare
briancorbin
force-pushed
the
feature/hw/cli
branch
from
October 2, 2023 20:13
ad4c2ad
to
9558644
Compare
briancorbin
force-pushed
the
feature/hw/check-account
branch
from
October 2, 2023 20:58
79031db
to
49ab266
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
- Coverage 60.12% 54.62% -5.51%
==========================================
Files 88 116 +28
Lines 12356 14803 +2447
Branches 2010 2550 +540
==========================================
+ Hits 7429 8086 +657
- Misses 3238 4847 +1609
- Partials 1689 1870 +181
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to make sure the account is the expected one prior to executing the operations.