Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware-wallet/import-from-ledger #835

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

briancorbin
Copy link
Contributor

@briancorbin briancorbin commented Apr 27, 2023

This adds the idea of "managed by hardware wallet" to accounts, which will prompt them to try to interface with a hardware wallet when performing transactions that required the private spend key.

This was referenced Apr 27, 2023
@briancorbin
Copy link
Contributor Author

briancorbin commented Apr 27, 2023

This was referenced Apr 27, 2023
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from 0bd36a6 to 5978256 Compare April 27, 2023 15:53
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 10dab43 to 24bac9e Compare April 27, 2023 15:53
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from 5978256 to 01b4f1b Compare May 1, 2023 18:51
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 24bac9e to 5189b9d Compare May 1, 2023 18:51
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from 01b4f1b to f937539 Compare May 2, 2023 15:11
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 5189b9d to da9ec37 Compare May 2, 2023 15:11
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from f937539 to b954c75 Compare May 12, 2023 14:48
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from fac7e77 to 5a6f888 Compare May 12, 2023 14:48
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from b954c75 to 2371438 Compare May 12, 2023 19:40
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 5a6f888 to 0e61596 Compare May 12, 2023 19:40
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from 2371438 to 13774a8 Compare June 20, 2023 19:17
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 0e61596 to 9b784d5 Compare June 20, 2023 19:17
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from 13774a8 to 88922cb Compare June 21, 2023 04:56
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 9b784d5 to 22ded55 Compare June 21, 2023 04:57
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch from 88922cb to 2f67395 Compare June 22, 2023 16:37
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 22ded55 to d8760c9 Compare June 22, 2023 16:37
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from d8760c9 to aeecac3 Compare September 25, 2023 21:34
Copy link

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@briancorbin briancorbin marked this pull request as ready for review September 26, 2023 22:14
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from aeecac3 to 04ad5eb Compare September 26, 2023 22:18
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 04ad5eb to b70bf26 Compare September 26, 2023 22:25
Cargo.toml Outdated Show resolved Hide resolved
full-service/src/json_rpc/v2/models/account.rs Outdated Show resolved Hide resolved
full-service/src/service/account.rs Outdated Show resolved Hide resolved
full-service/src/service/account.rs Outdated Show resolved Hide resolved
@briancorbin briancorbin force-pushed the feature/hw/build-tx branch 2 times, most recently from 70fad73 to 2a149fb Compare September 28, 2023 23:44
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from b70bf26 to 6da80ac Compare September 30, 2023 18:29
Base automatically changed from feature/hw/build-tx to main September 30, 2023 18:48
updating API to optionally take in private keys when importing VOAccount

updating service implementation

updating tests

updating tests

fixing lint issues

fixing more lint issues

fixing missing function

wip implementation

add test for db account import from hw

lint fixes

fetch main address from database

making hw fog info optional

lint fixes

actually make the parameter optional...

making sign with local signer public function

making device mutable
@briancorbin briancorbin force-pushed the feature/hw/import-from-ledger branch from 6da80ac to d45f5f9 Compare September 30, 2023 18:52
@codecov-commenter
Copy link

Codecov Report

Attention: 248 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (198fe65) 59.90%.
Report is 142 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   60.12%   59.90%   -0.22%     
==========================================
  Files          88       96       +8     
  Lines       12356    13486    +1130     
  Branches     2010     2226     +216     
==========================================
+ Hits         7429     8079     +650     
- Misses       3238     3536     +298     
- Partials     1689     1871     +182     
Files Coverage Δ
full-service/src/db/gift_code.rs 67.85% <100.00%> (+1.19%) ⬆️
full-service/src/json_rpc/v1/api/request.rs 76.98% <100.00%> (-1.59%) ⬇️
...service/src/json_rpc/v1/models/receiver_receipt.rs 77.77% <ø> (+0.99%) ⬆️
full-service/src/json_rpc/v1/models/tx_proposal.rs 73.56% <100.00%> (+0.30%) ⬆️
full-service/src/json_rpc/v1/models/txo.rs 57.27% <100.00%> (+2.72%) ⬆️
full-service/src/json_rpc/v2/api/test_utils.rs 84.61% <100.00%> (ø)
full-service/src/json_rpc/v2/models/account.rs 46.42% <ø> (-2.23%) ⬇️
full-service/src/json_rpc/v2/models/account_key.rs 47.05% <ø> (+0.76%) ⬆️
...ll-service/src/json_rpc/v2/models/masked_amount.rs 50.00% <ø> (-4.55%) ⬇️
...l-service/src/json_rpc/v2/models/network_status.rs 55.00% <ø> (-1.25%) ⬇️
... and 45 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briancorbin briancorbin merged commit dcee7a8 into main Oct 2, 2023
5 of 6 checks passed
@briancorbin briancorbin deleted the feature/hw/import-from-ledger branch October 2, 2023 19:26
@briancorbin briancorbin added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants