-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardware-wallet/import-from-ledger #835
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
0bd36a6
to
5978256
Compare
10dab43
to
24bac9e
Compare
5978256
to
01b4f1b
Compare
24bac9e
to
5189b9d
Compare
01b4f1b
to
f937539
Compare
5189b9d
to
da9ec37
Compare
f937539
to
b954c75
Compare
fac7e77
to
5a6f888
Compare
b954c75
to
2371438
Compare
5a6f888
to
0e61596
Compare
2371438
to
13774a8
Compare
0e61596
to
9b784d5
Compare
13774a8
to
88922cb
Compare
9b784d5
to
22ded55
Compare
88922cb
to
2f67395
Compare
22ded55
to
d8760c9
Compare
2f67395
to
a656ef4
Compare
d8760c9
to
aeecac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a656ef4
to
7d953da
Compare
aeecac3
to
04ad5eb
Compare
7d953da
to
569f576
Compare
04ad5eb
to
b70bf26
Compare
a725ec2
to
9a79eff
Compare
70fad73
to
2a149fb
Compare
b70bf26
to
6da80ac
Compare
updating API to optionally take in private keys when importing VOAccount updating service implementation updating tests updating tests fixing lint issues fixing more lint issues fixing missing function wip implementation add test for db account import from hw lint fixes fetch main address from database making hw fog info optional lint fixes actually make the parameter optional... making sign with local signer public function making device mutable
6da80ac
to
d45f5f9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 60.12% 59.90% -0.22%
==========================================
Files 88 96 +8
Lines 12356 13486 +1130
Branches 2010 2226 +216
==========================================
+ Hits 7429 8079 +650
- Misses 3238 3536 +298
- Partials 1689 1871 +182
☔ View full report in Codecov by Sentry. |
This adds the idea of "managed by hardware wallet" to accounts, which will prompt them to try to interface with a hardware wallet when performing transactions that required the private spend key.