hardware-wallet/build-tx

[briancorbin]

This PR handles enabling a tx to be built via the ledger hardware device. Quite a few functions were made async to support this.

A new service class called hardware_wallet.rs contains most of the logic for interfacing with the ledger device.

[briancorbin]

Current dependencies on/for this PR:

• main
  • PR hardware-wallet/base #833
    • PR hardware-wallet/build-tx #834 👈
      • PR hardware-wallet/import-from-ledger #835
        • PR hardware-wallet/sync-account #836
          • PR hardware-wallet/cli-updates #837
            • PR add hw wallet account check prior to executing operations #919

This comment was auto-generated by Graphite.

[ryankurte]

big lockfile changes but, such is life and logic all lgtm

[remoun]

LGTM

[codecov-commenter]

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (aab98e4) 55.23%.
Report is 141 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   60.12%   55.23%   -4.90%     
==========================================
  Files          88      116      +28     
  Lines       12356    14432    +2076     
  Branches     2010     2472     +462     
==========================================
+ Hits         7429     7971     +542     
- Misses       3238     4621    +1383     
- Partials     1689     1840     +151     

Files	Coverage Δ
full-service/src/db/assigned_subaddress.rs	63.56% <100.00%> (+6.20%)	⬆️
full-service/src/db/gift_code.rs	67.85% <100.00%> (+1.19%)	⬆️
full-service/src/json_rpc/v1/api/request.rs	76.98% <100.00%> (-1.59%)	⬇️
...service/src/json_rpc/v1/models/receiver_receipt.rs	77.77% <ø> (+0.99%)	⬆️
full-service/src/json_rpc/v1/models/tx_proposal.rs	73.56% <100.00%> (+0.30%)	⬆️
full-service/src/json_rpc/v1/models/txo.rs	57.27% <100.00%> (+2.72%)	⬆️
full-service/src/json_rpc/v2/api/test_utils.rs	84.61% <100.00%> (ø)
full-service/src/json_rpc/v2/models/account_key.rs	47.05% <100.00%> (+0.76%)	⬆️
...l-service/src/json_rpc/v2/models/public_address.rs	60.00% <100.00%> (ø)
...service/src/json_rpc/v2/models/receiver_receipt.rs	76.92% <ø> (+0.99%)	⬆️
... and 46 more

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.