Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs button causes app to freeze #1127

Open
SilmarillionWorshipper opened this issue Apr 19, 2024 · 20 comments · Fixed by #1304
Open

Logs button causes app to freeze #1127

SilmarillionWorshipper opened this issue Apr 19, 2024 · 20 comments · Fixed by #1304
Labels
bug Something isn't working

Comments

@SilmarillionWorshipper
Copy link

SilmarillionWorshipper commented Apr 19, 2024

Describe the bug

When attempting to view the logs for any of the mod profiles, the app will freeze and refuse to close unless killed.

Steps to reproduce

  1. Go to any mod profile
  2. Click on the logs button

System information

Linux (Pop!_OS 22.04)

@SilmarillionWorshipper SilmarillionWorshipper added the bug Something isn't working label Apr 19, 2024
@jcv99
Copy link

jcv99 commented Apr 30, 2024

Same on fedora 39 with appimage.
Operating System: Fedora Linux 39
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12
Kernel Version: 6.8.7-200.fc39.x86_64 (64-bit)
Graphics Platform: X11
Processors: 16 × Intel® Core™ i7-10700KF CPU @ 3.80GHz
Memory: 15,5 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 3070/PCIe/SSE2
Manufacturer: ASUS

@quaap
Copy link

quaap commented May 22, 2024

Same here. Fully updated Manjaro/Arch with XFCE and Kernel 6.9.x

@Sl3epy
Copy link

Sl3epy commented May 23, 2024

Same here. On Ubuntu and Gnome

@AstroOrbis
Copy link

Same here with Arch Linux (which I use btw) on Plasma and Gnome with both X11 and Wayland (latest on all)

@CrossScarDev
Copy link

Has this been seen?

@LapisPhoenix
Copy link

Same here, it will just hang there and do nothing, ive tried several ways of killing it but nothing seems to work, other than restarting.

Linux Mint 21.3 Cinnamon
prewview

@CrossScarDev
Copy link

CrossScarDev commented Jun 16, 2024

@LapisPhoenix I can quit by running killall modrinth-app on Arch but don't know about Mint.

@Norbiros
Copy link
Contributor

The same bug was mentioned here: #1216 (comment)

Geometrically pushed a commit that referenced this issue Jul 4, 2024
Norbiros added a commit to Norbiros/code that referenced this issue Jul 9, 2024
Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library.
@LapisPhoenix
Copy link

@LapisPhoenix I can quit by running kill-all modrinth-app on Arch but don't know about Mint.

Sorry for late reply, thanks for letting me know. On Mint I need to do killall modrinth-app and it works. Thanks for the work around.

@CrossScarDev
Copy link

@LapisPhoenix sorry yeah I meant killall modrinth-app the - was a mistake. I'll update my reply.

Norbiros added a commit to Norbiros/code that referenced this issue Jul 18, 2024
…rinth#1237)

Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library.
github-merge-queue bot pushed a commit that referenced this issue Jul 20, 2024
* fix(theseus): Resolve log tab freezing entire app (#1127, #1237)
Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library.

* fix(theseus): Double opening of Socials Share link (#1136, #1074)

* fix(theseus): Proper symlinks resolution (#1236)
Ensures correct symlink resolution for specific mods, the mods directory, and the entire profile directory.

* fix(theseus): Correctly recognize NeoForge mods (#1215)

* fix(theseus): Corrected `Environments` and `Loaders` filters (#899)

* fix(theseus): Remove `_JAVA_OPTIONS` when testing JRE (#1171)

* fix(theseus): Fixed opening files using `show_in_folder`
Previously, opening a mod would display the contents of the JAR file instead of its location.

* fix(theseus): Hide `.DS_Store` files (#1274, #1002, #1174)

* fix(theseus): Corrected tooltip color

* fix(theseus): Fixed white mode issues (#1144, #1010)

* fix: Corrected `Slider` min and max value handling (#1008)

* fix: Fixed rebase problems

* fix: Fixed `:deep` usage warning

* chore: Updated eslint plugins to fix conflicts with Prettier
@Norbiros
Copy link
Contributor

This bug was reintroduced in c84e2e0

@Call-Me-Alex
Copy link

@Norbiros can confirm

@Geometrically Geometrically reopened this Aug 24, 2024
@okunamayanad
Copy link

Ubuntu 24.04, opening any modpack's logs page makes the app freeze and turns the window to gray. here are the logs of the app:

/usr/lib/x86_64-linux-gnu/gvfs/libgvfscommon.so: undefined symbol: g_task_set_static_name
Failed to load module: /usr/lib/x86_64-linux-gnu/gio/modules/libgvfsdbus.so
/usr/lib/x86_64-linux-gnu/gvfs/libgvfscommon.so: undefined symbol: g_task_set_static_name
Failed to load module: /usr/lib/x86_64-linux-gnu/gio/modules/libgvfsdbus.so
/usr/lib/x86_64-linux-gnu/gvfs/libgvfscommon.so: undefined symbol: g_task_set_static_name
Failed to load module: /usr/lib/x86_64-linux-gnu/gio/modules/libgvfsdbus.so
/lib/x86_64-linux-gnu/libcurl-gnutls.so.4: undefined symbol: nghttp2_option_set_no_rfc9113_leading_and_trailing_ws_validation
Failed to load module: /usr/lib/x86_64-linux-gnu/gio/modules/libgiolibproxy.so
/usr/lib/x86_64-linux-gnu/gio/modules/libdconfsettings.so: undefined symbol: g_assertion_message_cmpint
Failed to load module: /usr/lib/x86_64-linux-gnu/gio/modules/libdconfsettings.so
-- app starts up --

-- click on logs and freeze --

some errors while launching but no logs after that

@Norbiros
Copy link
Contributor

This is some weird problem with webkit gtk. We can't really fix it easily, so we have to switch to different virtual list library.

@mcredstoner
Copy link

Same here, it will just hang there and do nothing, ive tried several ways of killing it but nothing seems to work, other than restarting.

Linux Mint 21.3 Cinnamon prewview

for that you can use an extra app called Resources
( https://flathub.org/apps/net.nokyan.Resources )

@kawazoe
Copy link

kawazoe commented Oct 18, 2024

This is some weird problem with webkit gtk. We can't really fix it easily, so we have to switch to different virtual list library.

@Norbiros Maybe a somewhat related issue, on my install (Garuda KDE 6.2) the app scrolling is insanely slow. I get maybe 5-10 FPS (EDIT: turns out it's actually tied to the window size). Everything else works fine outside of the log crash. It could be that the list virtualisation is causing this too.

@LapisPhoenix
Copy link

LapisPhoenix commented Oct 19, 2024

This is some weird problem with webkit gtk. We can't really fix it easily, so we have to switch to different virtual list library.

@Norbiros Maybe a somewhat related issue, on my install (Garuda KDE 6.2) the app scrolling is insanely slow. I get maybe 5-10 FPS. Everything else works fine outside of the log crash. It could be that the list virtualisation is causing this too.

I can second, I got extremely slow scrolling, on all menus.

@Norbiros
Copy link
Contributor

Yeah, it's also webkit problem. It is generalny very slow but in AppImages this problem is even bigger. For me manually building the app (pnpm app:build) and using binary improves it.

@Norbiros Norbiros mentioned this issue Nov 17, 2024
@Norbiros
Copy link
Contributor

Norbiros commented Dec 24, 2024

On new version (0.9.0) setting WEBKIT_DISABLE_DMABUF_RENDERER=0 on wayland improves performance & fixes this issue.

@kawazoe
Copy link

kawazoe commented Dec 24, 2024

On new version (0.9.0) setting WEBKIT_DISABLE_DMABUF_RENDERER=0 on wayland improves performance & fixes this issue.

I just tried 0.9 and... it's been nothing short of a disastrous experience for me*. The official app image stays stuck on a gray window and the native decorations don't do anything.

I tried 0.9.0-1 from the AUR and that one launches but, even with the envar you're suggesting, it's more meaningful to talk about the performance in seconds per frame rather than frames per second. Simple animations like button hovers takes 1 to 2 seconds to reach their steady state. Resizing the window feels like I'm back on Windows XP. Even the native window decorations don't respond properly.

All of those simple actions are using 100% of a core. Even if some of this stuff should clearly be offloaded to the GPU, hovering a button should not be using that much resources. I can run a browser without hardware acceleration and watch videos with a better frame-rate so it's clear that there's something more involved going on here.

If this helps, I don't just get stalls; I get actual seg faults in libwebkit2gtk. If you have a way for me to share the coredump privately, I don't mind sending it over.

* Here's my setup to give you some context

 OS Garuda Linux x86_64
└󰍹 Kernel Linux 6.12.4-zen1-1-zen

 DE KDE Plasma 6.2.4
└󰍹 Window Manager KWin (Wayland)

󰌢 PC Desktop
├󰻠 CPU AMD Ryzen 9 7950X (32) @ 5.88 GHz
├󰍛 GPU AMD Radeon RX 7900 XTX [Discrete]
├󰍛 GPU AMD Raphael [Integrated]
├󰍛 OpenGL 4.6 (Compatibility Profile) Mesa 24.3.2-arch1.1
├󰍛 Vulkan 1.3.296 - radv [Mesa 24.3.2-arch1.1]
└󰍹 Display(s) 3840x2160 @ 60 Hz (as 3072x1728) in 27" [External] *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.