-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all association tables together #775
Conversation
…ll association types on page load
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 70.75% 70.75%
=======================================
Files 91 91
Lines 3084 3084
=======================================
Hits 2182 2182
Misses 902 902 ☔ View full report in Codecov by Sentry. |
… up the info section above)
…n details section within a modal
Kevin, I see this still has some linting failures. Would you like me to review it anyway? |
…t all categories are shown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I didn't extensively test the web function. I also think we should probably present this a little more broadly before we pull the trigger to move it to prod.
There is a problem with the formatting of section headers when this is merged in. I'm working on finding the source of the issue. Sorry I missed this when I reviewed... Sara pointed it out to me on one of my PR's. |
Show all association tables at once on a node page rather than having to select the association type from an option box. From the initial first pass, I think the minimum to make this work is going to also include making the page nav always visible and making sure it has scrollspy functionality. This may turn into a longer lived PR if we find that we need to tweak table content before we want to merge.