Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all association tables together #775

Merged
merged 28 commits into from
Oct 4, 2024

Conversation

kevinschaper
Copy link
Member

Show all association tables at once on a node page rather than having to select the association type from an option box. From the initial first pass, I think the minimum to make this work is going to also include making the page nav always visible and making sure it has scrollspy functionality. This may turn into a longer lived PR if we find that we need to tweak table content before we want to merge.

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 6a5a295
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/67004711bc130d000872fe40
😎 Deploy Preview https://deploy-preview-775--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.75%. Comparing base (510a4a1) to head (6a5a295).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   70.75%   70.75%           
=======================================
  Files          91       91           
  Lines        3084     3084           
=======================================
  Hits         2182     2182           
  Misses        902      902           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinschaper kevinschaper linked an issue Aug 9, 2024 that may be closed by this pull request
@kevinschaper kevinschaper linked an issue Aug 9, 2024 that may be closed by this pull request
5 tasks
@sagehrke sagehrke mentioned this pull request Sep 17, 2024
53 tasks
@amc-corey-cox
Copy link
Collaborator

Kevin, I see this still has some linting failures. Would you like me to review it anyway?

@kevinschaper kevinschaper marked this pull request as ready for review October 4, 2024 16:05
Copy link
Collaborator

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I didn't extensively test the web function. I also think we should probably present this a little more broadly before we pull the trigger to move it to prod.

@kevinschaper kevinschaper merged commit 2c878e8 into main Oct 4, 2024
11 checks passed
@kevinschaper kevinschaper deleted the issue-734-all-association-sections branch October 4, 2024 22:14
@amc-corey-cox amc-corey-cox restored the issue-734-all-association-sections branch October 11, 2024 17:56
@amc-corey-cox
Copy link
Collaborator

amc-corey-cox commented Oct 11, 2024

There is a problem with the formatting of section headers when this is merged in. I'm working on finding the source of the issue. Sorry I missed this when I reviewed... Sara pointed it out to me on one of my PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the progressive disclosure on mi.org
2 participants