Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Iron with Main for release #2347

Closed
wants to merge 21 commits into from
Closed

Sync Iron with Main for release #2347

wants to merge 21 commits into from

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Sep 7, 2023

No description provided.

todoubaba and others added 20 commits July 24, 2023 11:54
@todoubaba
fix move_group capabilities loading (#2270)
6eebe6c 
* fix move_group capabilities loading
* clang-format
@stephanie-eng @sjahr
Specify controller name in MGI execution (#2257)
cdf7a98 
* Specify controller name in MGI execute

* Finish comment

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
@sjahr @sea-bass @kylc
Cleanup planning request adapter interface (#2266)
830ceda 
* Use default arguments instead of additional functions

* Use generate param lib for default plan request adapters

* Small cleanup of ResolveConstraintFrames

* Remove dublicate yaml file entry

* Move list_planning_adapter_plugins into own directory

* Apply suggestions from code review

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>

* Fix copy& paste error

* Update parameter descriptions

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kyle Cesare <kcesare@gmail.com>

* EMPTY_PATH_INDEX_VECTOR -> empty_path_index_vector

* Update parameter yaml

* Make param listener unique

* Fix build error

* Use gt_eq instead of deprecated lower_bounds

---------

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Co-authored-by: Kyle Cesare <kcesare@gmail.com>
@Shobuj-Paul
Replaced numbers with SystemDefaultsQos() (#2271)
5506dd5
@stephanie-eng
Fix comment formatting (#2276)
83892d6
@henningkayser
Remove source install of gtest branch in CI (#2284)
f9f1804 
The PR branch has been removed by GitHub so that CI was using the
official release. The compile warnings have been fixed in a
more recent version.
@stephanie-eng
Fix typo in error message (#2286)
548f5fe
@ibrahiminfinite
[Servo] Refactoring servo (#2224)
92ca89d
@ibrahiminfinite @AndyZe
[Servo] Add additional info about twist frame conversion (#2295)
4476fb6 
* Update docstring + warning for twist frame conversion

* Apply suggestions from code review

Co-authored-by: AndyZe <andyz@utexas.edu>

* Suppress old-style-cast warnings

---------

Co-authored-by: AndyZe <andyz@utexas.edu>
@Shobuj-Paul @sea-bass @sjahr
Replaced boost::algorithm::join with fmt::join (#2273)
bdc9cec 
* Replaced boost::algorithm::join with fmt::join

* Made changes in CMakeLists.txt to accomodate fmt

* Updated package.xml files

* removed redundant boost dependencies

* Rename variables -> variable

---------

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
@sjahr
Add mergify iron backport label (#2293)
01ccced
@sloretz @henningkayser
Fix linking error with cached_ik_kinematics_plugin (#2292)
3b9de9b 
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
@todoubaba
Fx class_loader warnings in PILZ unittests (#2296)
d4dcea3
@sjahr
Remove added path index from planner adapter function signature (#2285)
a2f0183
@uavster
[TOTG] Exit loop when position can't change (#2307)
7c95367
@todoubaba @sjahr
Remove boost from motion_planning_rviz_plugin (#2308)
05f3501 
Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io>
@ibrahiminfinite
[Servo] Fix Twist transformation (#2311)
5af8db7
@henningkayser
Remove humble tags from main branch GHA jobs (#2312)
3e5af1b
@marioprats
Add a benchmark for 'getJacobian' (#2326)
47d92ef
@dependabot
🛠️ Bump actions/checkout from 3 to 4 (#2339)
84421ea 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mergify
Copy link

mergify bot commented Sep 7, 2023

This pull request is in conflict. Could you fix it @tylerjw?

@mergify
Copy link

mergify bot commented Sep 7, 2023

Please target the main branch for development, we will backport the changes to iron for you if approved and if they don't break API.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 83.02% and project coverage change: +0.22% 🎉

Comparison is base (93c48b0) 50.51% compared to head (6608798) 50.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             iron    #2347      +/-   ##
==========================================
+ Coverage   50.51%   50.72%   +0.22%     
==========================================
  Files         386      386              
  Lines       31740    31958     +218     
==========================================
+ Hits        16029    16207     +178     
- Misses      15711    15751      +40
Files Changed Coverage Δ
...ene/include/moveit/planning_scene/planning_scene.h 44.27% <ø> (ø)
moveit_core/robot_model/src/robot_model.cpp 74.64% <0.00%> (ø)
...g/rdf_loader/src/synchronized_string_parameter.cpp 32.31% <0.00%> (-0.50%) ⬇️
...it_ros/robot_interaction/src/robot_interaction.cpp 0.00% <0.00%> (ø)
...obot_state_rviz_plugin/src/robot_state_display.cpp 0.00% <0.00%> (ø)
...ugin_render_tools/src/trajectory_visualization.cpp 0.00% <0.00%> (ø)
...include/moveit_setup_app_plugins/launch_bundle.hpp 0.00% <0.00%> (ø)
...ework/include/moveit_setup_framework/templates.hpp 25.00% <ø> (ø)
...sistant/moveit_setup_framework/src/urdf_config.cpp 49.40% <0.00%> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 37.28% <42.86%> (-7.98%) ⬇️
... and 13 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@henningkayser
Copy link
Member

fixed merge commit message and pushed this to iron 👍

@henningkayser henningkayser mentioned this pull request Sep 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.