Handle sync errors #824
Handle sync errors #824
Conversation
…splay error message.
|
Waiting for @ryanfeeley to suggest an error panel, but did this temporary UI just to prove we can handle that issue properly 🎉 |
|
@sebastienbarbier I could not have done it better myself! Here is where we should put storage information. I'm working on when/how we should warn them BEFORE IT’S TOO LATE. |
src/sync.js
Outdated
| @@ -104,6 +102,12 @@ class JWETransformer { | |||
| // If we get such a record, flag it as deleted. | |||
| if (decoded._status === 'deleted') { | |||
| decoded.deleted = true; | |||
| // On decode, we flag notes with _status deleted but still on server. | |||
| // We automatically will request deletion for those. | |||
| // (This is due to singleNote overriding deleted state with udpated to server) | |||
src/sync.js
Outdated
| // On decode, we flag notes with _status deleted but still on server. | ||
| // We automatically will request deletion for those. | ||
| // (This is due to singleNote overriding deleted state with udpated to server) | ||
| // Should be deleted when every user who tryed beta runned it once. |
src/sync.js
Outdated
| // We automatically will request deletion for those. | ||
| // (This is due to singleNote overriding deleted state with udpated to server) | ||
| // Should be deleted when every user who tryed beta runned it once. | ||
| // (see meetrics deleteDeleted) |
@sebastienbarbier we won't be able to do this initially. let's open a follow up issue.
Not sure what else we can do there. Could we clean up this PR and merge? |
|
I'll refactor and yes we should be able to merge soon. |
|
Is there a point of flagging me for review if these PRs get merged within hours, without giving me a chance to look at them? That's the second time it happens in a few hours. |
Sorry, yeah good point. I Think we are gonna change the process on our end and not introduce strings in small batches, and do a separate commit for those before when preparing a release so you get a chance to review them (in a larger batch as well). |
After authenticating, kinto might return some errors we should handle.
Fix #791 #801 #802 #827