doc/ko: Add missing options in uftrace-replay.md #1957
Conversation
Identified and corrected discrepancies between the English and Korean versions of uftrace-replay.md: 1. The description of the --disable option in the Korean version differed from the English version. This has been correctly retranslated. 2. Added the missing options --trace=*STATE*, --srcline, and --no-args to the Korean version. 3. Included the 'task' and 'module' fields for the -f *FIELD*, --output-fields=*FIELD* option in the Korean version, which were previously omitted. These changes bring the Korean documentation in line with the English version, ensuring consistency and completeness. Signed-off-by: Sinsohi <sohi8451@naver.com>
There was a problem hiding this comment.
Thanks for the patch. I've just left one minor comment and others are fine.
But could you please enhance your commit message? I've asked many times about rewriting commit messages in various PRs so you can get some ideas.
The most recent request can be found at #1946 (review). Please read the comment and other comments below so that you can get more ideas what I have been asking before merge a PR.
I can see your commit message at https://github.com/namhyung/uftrace/pull/1957.patch.
It would be helpful if @gichoel or @ParkSeungHyeok can help him write better commit messages.
doc/ko/uftrace-replay.md
Outdated
| : uftrace 트레이싱 상태를 설정한다. 가능한 상태는 `on`과 `off`이다. 기본값은 | ||
| `on`이다. 이는 `trace_on` 트리거나 에이전트와 함께 사용할 때만 의미가 있다. |
There was a problem hiding this comment.
How about making it as follows?
| : uftrace 트레이싱 상태를 설정한다. 가능한 상태는 `on`과 `off`이다. 기본값은 | |
| `on`이다. 이는 `trace_on` 트리거나 에이전트와 함께 사용할 때만 의미가 있다. | |
| : uftrace 트레이싱 상태를 설정한다. 가능한 상태는 `on`과 `off` 이며 기본값은 | |
| `on`이다. 이는 `trace_on` 트리거나 에이전트와 함께 사용할 때만 의미가 있다. |
|
First, thanks for your contribution. However, there are some rules for writing a good readable commit message, and the commit message improvement that In the case of the commit message currently written, the subject does not exceed 50 characters, so it satisfies the rule, but the body does not satisfies the rule because it is not broken every 72 characters. Could you please make this change? [1] https://www.gitkraken.com/learn/git/best-practices/git-commit-message#git-commit-message-structure |
Identified and corrected discrepancies between the English and Korean versions of uftrace-replay.md: 1. The description of the --disable option in the Korean version differed from the English version. This has been correctly retranslated. 2. Added the missing options --trace=*STATE*, --srcline, and --no-args to the Korean version. 3. Included the 'task' and 'module' fields for the -f *FIELD*, --output-fields=*FIELD* option in the Korean version, which were previously omitted. These changes bring the Korean documentation in line with the English version, ensuring consistency and completeness. Signed-off-by: Sinsohi <sohi8451@naver.com>
|
Thank you for your feedback.
Let me know if any further modifications are needed. |
|
Please update your name correctly as I mentioned at #1957 (review).
|
Identified and corrected discrepancies between the English and Korean versions of uftrace-replay.md: 1. The description of the --disable option in the Korean version differed from the English version. This has been correctly retranslated. 2. Added the missing options --trace=*STATE*, --srcline, and --no-args to the Korean version. 3. Included the 'task' and 'module' fields for the -f *FIELD*, --output-fields=*FIELD* option in the Korean version, which were previously omitted. These changes bring the Korean documentation in line with the English version, ensuring consistency and completeness. Signed-off-by: Sin Sohi <sohi8451@naver.com>
|
Please don't merge, just rebase your changes on top of the current master. |
|
Thank you for your feedback. |
|
Please squash all the commits in this PR. And it has conflict with the master so can't be merged. |
Identified and corrected discrepancies between the English and Korean versions of uftrace-replay.md: 1. The description of the --disable option in the Korean version differed from the English version. This has been correctly retranslated. 2. Added the missing options --trace=*STATE*, --srcline, and --no-args to the Korean version. 3. Included the 'task' and 'module' fields for the -f *FIELD*, --output-fields=*FIELD* option in the Korean version, which were previously omitted. These changes bring the Korean documentation in line with the English version, ensuring consistency and completeness. Signed-off-by: Sin Sohi <sohi8451@naver.com> mcount: Get rid of tid from retstack I don't remember why it has tid for each return stack entry. It's not used so let's get rid of it. Also move dyn_idx field to remove the padding. Signed-off-by: Namhyung Kim <namhyung@gmail.com> mcount: Handle recover trigger only if -e is not used The -e/--estimate-return doesn't hook the return addresses so no need to recover the original address. Signed-off-by: Namhyung Kim <namhyung@gmail.com> mcount: Use mcount_memcpy1() instead of memcpy() We don't want to use external memcpy() function in the mcount fast path because it might use some SSE/AVX registers internally. We want to preserve the original register values and to avoid saving and restoring all the registers unnecessarily. Signed-off-by: Namhyung Kim <namhyung@gmail.com> doc/ko: Add missing options in uftrace-replay.md Identified and corrected discrepancies between the English and Korean versions of uftrace-replay.md: 1. The description of the --disable option in the Korean version differed from the English version. This has been correctly retranslated. 2. Added the missing options --trace=*STATE*, --srcline, and --no-args to the Korean version. 3. Included the 'task' and 'module' fields for the -f *FIELD*, --output-fields=*FIELD* option in the Korean version, which were previously omitted. These changes bring the Korean documentation in line with the English version, ensuring consistency and completeness. Signed-off-by: Sinsohi <sohi8451@naver.com>
|
I'm having trouble resolving this. Would it be okay if I delete this PR and submit a new one |
|
Please update it here and don't open a new PR. If you're a contribution academy mentee, then you can ask @gichoel. |
|
I apologize. I didn't check your response and, due to severe errors, I hastily closed the PR and deleted the repository. I'm really sorry, but would it be alright if I fork again and resend the PR? |
|
You don't have to say sorry. We know how it is difficult at the first try. The issue is that I am quite busy these days so cannot explain all the details. I just hope someone else can help you with this issue because helping new contributors is also a great contribution to the project. |
|
However, after checking the commit hash of the PR and the commit hash of @honggyukim |
|
I would be really grateful if you could do that. |
|
Thanks. I will do that when I have some time. |
|
@sinsohi I have a simple question. What do you want me to write your name among the followings?
|
|
@honggyukim Please write my name as Sin Sohi. Thank you. |
|
@sinsohi Sorry, I've been busy for a while. I will do that within a few days. |
Identified and corrected discrepancies between the English and
Korean versions of uftrace-replay.md:
The description of the --disable option in the Korean version
differed from the English version. This has been correctly
retranslated.
Added the missing options --trace=STATE, --srcline, and
--no-args to the Korean version.
Included the 'task' and 'module' fields for the
-f FIELD, --output-fields=FIELD option in the Korean version,
which were previously omitted.
These changes bring the Korean documentation in line with the
English version, ensuring consistency and completeness.
Signed-off-by: Sin Sohi sohi8451@naver.com