Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Set CERT_STORE_READONLY_FLAG when opening cert stores #6019

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

neilalexander
Copy link
Member

This should allow access to CERT_SYSTEM_STORE_LOCAL_MACHINE from non-admin users.

Fixes #6018.

Signed-off-by: Neil Twigg neil@nats.io

This should allow access to `CERT_SYSTEM_STORE_LOCAL_MACHINE` from non-admin users.

Fixes #6018.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner October 18, 2024 13:29
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 9de7c4f into main Oct 18, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/certstorero branch October 18, 2024 16:18
neilalexander added a commit that referenced this pull request Oct 29, 2024
Includes the following:

- #5115
- #6019
- #6039
- #6034
- #6043
- #6042
- #6047
- #6049
- #6050 
- #6052
- #6053

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server won't start when TLS configuration uses "WindowsLocalMachine" store
2 participants