Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Cluster: load balancing of queue groups from attached leaf nodes #6043

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

kozlovic
Copy link
Member

When receiving a message from a route, if the queue interest is only routes and leaf connections, the server will always favor the leaf kind. However, if there were more than one leaf connections for the same queue group, the server will always pick the same (the last one). It would change if new leaf were to connect or disconnect/reconnect, but with a stable set, it would always be the same.

This PR makes this selection somewhat random.

Resolves #6040

Signed-off-by: Ivan Kozlovic ivan@synadia.com

When receiving a message from a route, if the queue interest is
only routes and leaf connections, the server will always favor
the leaf kind. However, if there were more than one leaf connections
for the same queue group, the server will always pick the same
(the last one). It would change if new leaf were to connect or
disconnect/reconnect, but with a stable set, it would always
be the same.

This PR makes this selection somewhat random.

Resolves #6040

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 599c105 into main Oct 25, 2024
5 checks passed
@derekcollison derekcollison deleted the fix_6040 branch October 25, 2024 19:26
@wallyqs wallyqs changed the title [FIXED] Cluster: loab balancing of queue groups from attached leaf nodes [FIXED] Cluster: load balancing of queue groups from attached leaf nodes Oct 26, 2024
neilalexander added a commit that referenced this pull request Oct 29, 2024
Includes the following:

- #5115
- #6019
- #6039
- #6034
- #6043
- #6042
- #6047
- #6049
- #6050 
- #6052
- #6053

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants