Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in consumers #6039

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Reduce allocations in consumers #6039

merged 3 commits into from
Oct 24, 2024
+20 −1

Conversation

neilalexander
Copy link
Member

This PR makes the following changes that should reduce allocations in consumers:

  • JSApiConsumerGetNextRequest structs are now pooled, as they were unavoidably escaping to the heap;
  • waitingRequest structs are now returned to the pool correctly if hitting MaxWaiting;
  • Reuse the hdr buffer from pooled jsPubMsg when returning consumer errors to the client.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Pool JSApiConsumerGetNextRequest in nextReqFromMsg
7ab3b1e 
Otherwise a lot of allocations escape to the heap due to the `json.Unmarshal()`.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander
Recycle wait request if exceeded MaxWaiting
b4c9d27 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander
Reduce allocations with jsPubMsg message headers
a0c41b4 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner October 24, 2024 14:49
@neilalexander neilalexander marked this pull request as draft October 24, 2024 15:05
@neilalexander neilalexander marked this pull request as ready for review October 24, 2024 15:10
derekcollison
derekcollison approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit c432281 into main Oct 24, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/nextreqfrommsg branch October 24, 2024 17:49
@neilalexander neilalexander mentioned this pull request Oct 29, 2024
Merged
neilalexander added a commit that referenced this pull request Oct 29, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.1 (#6054)
8f6dd32 
Includes the following:

- #5115
- #6019
- #6039
- #6034
- #6043
- #6042
- #6047
- #6049
- #6050 
- #6052
- #6053

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic left review comments

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilalexander @derekcollison @kozlovic