Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Invalidate stream state on read/write if tracking states mismatch #6034

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[FIXED] Invalidate stream state on read/write if tracking states mismatch #6034

merged 2 commits into from
Oct 24, 2024

Conversation

MauriceVanVeen
Copy link
Member

  • When writing the state file, the state check was not active anymore. That change was made here.
  • When reading the state file, the state check was removed as well which meant if all checksums matched we'd use a stale index.db. Re-introduced the state check from here.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen force-pushed the maurice/write-full-state-check-equals branch from 13eefbb to 2ddff06 Compare October 24, 2024 07:38
@MauriceVanVeen MauriceVanVeen changed the title [FIXED] Check state consistency on read/write [FIXED] Check stream state consistency on read/write Oct 24, 2024
@MauriceVanVeen
[FIXED] Invalidate stream state before write if tracking states mismatch
7266a52 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen
[FIXED] Invalidate stream state on recovery if tracking states mismatch
9656708 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/write-full-state-check-equals branch from 2ddff06 to 9656708 Compare October 24, 2024 17:43
@MauriceVanVeen MauriceVanVeen changed the title [FIXED] Check stream state consistency on read/write [FIXED] Invalidate stream state on read/write if tracking states mismatch Oct 24, 2024
@MauriceVanVeen MauriceVanVeen marked this pull request as ready for review October 24, 2024 18:10
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner October 24, 2024 18:10
derekcollison
derekcollison approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 2086858 into main Oct 24, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/write-full-state-check-equals branch October 24, 2024 18:14
@neilalexander neilalexander mentioned this pull request Oct 29, 2024
Merged
neilalexander added a commit that referenced this pull request Oct 29, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.1 (#6054)
8f6dd32 
Includes the following:

- #5115
- #6019
- #6039
- #6034
- #6043
- #6042
- #6047
- #6049
- #6050 
- #6052
- #6053

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @derekcollison