Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gvcf are published also when all intervals are processed at once #1172

Merged
merged 4 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#1155](https://github.com/nf-core/sarek/pull/1155) - Restore proper rendering in `usage.md`
- [#1163](https://github.com/nf-core/sarek/pull/1163) - Correcting location of output folder for joint variant calling with GATK's haplotypecaller
- [#1169](https://github.com/nf-core/sarek/pull/1169) - Updating Sentieon-modules. (The conda-check in the Sentieon-modules was moved to the script-section. The version of Sentieon remain unchanged.)
- [#1172](https://github.com/nf-core/sarek/pull/1172) - Publish gvcf files when all intervals are processed at once ([#764](https://github.com/nf-core/sarek/issues/764))

## [3.2.3](https://github.com/nf-core/sarek/releases/tag/3.2.3) - Gällivare

Expand Down
1 change: 0 additions & 1 deletion conf/modules/haplotypecaller.config
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ process {
ext.prefix = { meta.num_intervals <= 1 ? ( params.joint_germline ? "${meta.id}.haplotypecaller.g" : "${meta.id}.haplotypecaller" ) : ( params.joint_germline ? "${meta.id}.haplotypecaller.${intervals.simpleName}.g" :"${meta.id}.haplotypecaller.${intervals.simpleName}" ) }
ext.when = { params.tools && params.tools.split(',').contains('haplotypecaller') }
publishDir = [
enabled: !params.joint_germline,
mode: params.publish_dir_mode,
path: { "${params.outdir}/variant_calling/"},
pattern: "*{vcf.gz,vcf.gz.tbi}",
Expand Down
2 changes: 1 addition & 1 deletion docs/output.md
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ If the haplotype-called VCF files are not filtered, then Sarek should be run wit
**Output directory: `{outdir}/variantcalling/haplotypecaller/<sample>/`**

- `<sample>.haplotypecaller.g.vcf.gz` and `<sample>.haplotypecaller.g.vcf.gz.tbi`
- VCF with tabix index
- gVCF with tabix index

**Output directory: `{outdir}/variantcalling/haplotypecaller/joint_variant_calling/`**

Expand Down
32 changes: 32 additions & 0 deletions tests/test_joint_germline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,35 @@
- path: results/variant_calling/haplotypecaller/testT/testT.haplotypecaller.g.vcf.gz.tbi
- path: results/haplotypecaller
should_exist: false
- name: Run joint germline variant calling with haplotypecaller all intervals at once
command: nextflow run main.nf -profile test_cache,targeted --input ./tests/csv/3.0/mapped_joint_bam.csv --tools haplotypecaller --step variant_calling --joint_germline --outdir results --nucleotides_per_second 100
tags:
- germline
- joint_germline
- variant_calling
files:
- path: results/csv/variantcalled.csv
md5sum: d2dffdbd2b4f1f26a06637592d24dab3
- path: results/multiqc
- path: results/preprocessing/recalibrated/test/test.recal.cram
should_exist: false
- path: results/preprocessing/recalibrated/test/test.recal.cram.crai
should_exist: false
- path: results/reports/bcftools/haplotypecaller/joint_variant_calling/joint_germline.bcftools_stats.txt
# Not stable enough
- path: results/reports/vcftools/haplotypecaller/joint_variant_calling/joint_germline.FILTER.summary
# Not stable enough
- path: results/reports/vcftools/haplotypecaller/joint_variant_calling/joint_germline.TsTv.count
# Not stable enough
- path: results/reports/vcftools/haplotypecaller/joint_variant_calling/joint_germline.TsTv.qual
# Not stable enough
- path: results/variant_calling/haplotypecaller/joint_variant_calling/joint_germline.vcf.gz
# binary changes md5sums on reruns
- path: results/variant_calling/haplotypecaller/joint_variant_calling/joint_germline.vcf.gz.tbi
# binary changes md5sums on reruns
- path: results/variant_calling/haplotypecaller/testN/testN.haplotypecaller.g.vcf.gz
- path: results/variant_calling/haplotypecaller/testN/testN.haplotypecaller.g.vcf.gz.tbi
- path: results/variant_calling/haplotypecaller/testT/testT.haplotypecaller.g.vcf.gz
- path: results/variant_calling/haplotypecaller/testT/testT.haplotypecaller.g.vcf.gz.tbi
- path: results/haplotypecaller
should_exist: false