Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate release 3.3.1 #1244

Merged
merged 45 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
33cbc82
back to dev
asp8200 Sep 14, 2023
2e6c1b9
Fix PR number
asp8200 Sep 14, 2023
24f3dfe
Update CHANGELOG.md
asp8200 Sep 14, 2023
d22d60b
[automated] Fix linting with Prettier
nf-core-bot Sep 14, 2023
8c167bf
Merge pull request #1231 from asp8200/prepare_release_3_4
asp8200 Sep 14, 2023
0f8a8b3
Fix Zenodo ID in manifest
FriederikeHanssen Sep 14, 2023
578ac62
Update nextflow.config
FriederikeHanssen Sep 14, 2023
b0494a8
update to v2
FriederikeHanssen Sep 14, 2023
1ede558
remove v2
FriederikeHanssen Sep 14, 2023
a0c0cbd
Merge pull request #1232 from FriederikeHanssen/zenodo
FriederikeHanssen Sep 14, 2023
b2dde77
update CHANGELOG
maxulysse Sep 15, 2023
15206c9
fixing folder checks
maxulysse Sep 15, 2023
841ed94
add meta map to channel
maxulysse Sep 15, 2023
09553a7
more complete error message
maxulysse Sep 15, 2023
9e27d77
fix map
maxulysse Sep 15, 2023
0918d31
simplify logic
maxulysse Sep 15, 2023
a3d57b4
remove usage of sentieon secrets in cache.config
asp8200 Sep 15, 2023
bede8ab
introducing profile sentieon_test_licence
asp8200 Sep 15, 2023
ed0e052
more safeguards
maxulysse Sep 15, 2023
e745db6
code polish
maxulysse Sep 15, 2023
c6ec5dc
Merge pull request #1236 from maxulysse/fix_annotation_unused
maxulysse Sep 15, 2023
137e2ca
Forgot profile sentieon_test_licence in some tests
asp8200 Sep 15, 2023
6827e45
update all gatk modules with disabling JVM hotspot fix
maxulysse Sep 18, 2023
638538f
update CHANGELOG
maxulysse Sep 18, 2023
a774c91
Fix typo in nf secrets cmd
asp8200 Sep 18, 2023
6242c31
Update controlfreec version
FriederikeHanssen Sep 18, 2023
35b42ce
Merge pull request #1240 from maxulysse/gatk4_hotspot
maxulysse Sep 18, 2023
c070ea4
Merge branch 'dev' into update_freec
maxulysse Sep 18, 2023
3c568e7
Merge branch 'sentieon-license-fixing2' of github.com:nf-core/sarek i…
maxulysse Sep 18, 2023
a55df91
use profile from configs
maxulysse Sep 18, 2023
2882b0c
update CHANGELOG
maxulysse Sep 18, 2023
0298c65
forgot this test
maxulysse Sep 18, 2023
d50e63b
Merge pull request #1241 from FriederikeHanssen/update_freec
maxulysse Sep 18, 2023
ebf0897
improve schema json for input
maxulysse Sep 18, 2023
b1407ba
update CHANGELOG
maxulysse Sep 18, 2023
607ecd6
Merge pull request #1243 from nf-core/improve_nextflow_schema
maxulysse Sep 18, 2023
a071f26
update tests
maxulysse Sep 18, 2023
83da7c0
renamed file
maxulysse Sep 18, 2023
8617e92
Merge branch 'dev' into sentieon-license-fixing3
maxulysse Sep 18, 2023
56c1916
Apply suggestions from code review
maxulysse Sep 18, 2023
c12ed5b
Update tests/test_umi.yml
maxulysse Sep 18, 2023
647b664
Merge pull request #1242 from nf-core/sentieon-license-fixing3
maxulysse Sep 18, 2023
10fccc6
prepare release
FriederikeHanssen Sep 18, 2023
176d292
Add release name
FriederikeHanssen Sep 18, 2023
8785be8
Merge pull request #1245 from FriederikeHanssen/prepare_release_331
FriederikeHanssen Sep 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .nf-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ lint:
- docs/images/nf-core-sarek_logo_light.png
- lib/NfcoreTemplate.groovy
- lib/NfcoreSchema.groovy
schema_params: False
template_strings: False
multiqc_config: False
26 changes: 26 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,32 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.3.1](https://github.com/nf-core/sarek/releases/tag/3.3.1) - Biellorippjávrre

A lake near the Rapaselet delta.

### Added

- [#1231](https://github.com/nf-core/sarek/pull/1231) - Back to dev

### Changed

- [#1242](https://github.com/nf-core/sarek/pull/1242) - Simplify sentieon nf-core test license usage
- [#1243](https://github.com/nf-core/sarek/pull/1243) - Improve json schema usage for input

### Fixed

- [#1232](https://github.com/nf-core/sarek/pull/1232) - Fix Zenodo IDs in manifest
- [#1236](https://github.com/nf-core/sarek/pull/1236) - Fix annotation cache folder verification when no annotation
- [#1240](https://github.com/nf-core/sarek/pull/1240) - Disable JVM Hotspot in all modules/gatk4 ([#1030](https://github.com/nf-core/sarek/issues/1030))
- [#1241](https://github.com/nf-core/sarek/pull/1241) - Fix axis text of controlfreec plots closing [#921](https://github.com/nf-core/sarek/issues/921)

### Dependencies

| Dependency | Old version | New version |
| ------------- | ----------- | ----------- |
| Control-FREEC | 11.6 | 11.6b |

## [3.3.0](https://github.com/nf-core/sarek/releases/tag/3.3.0) - Rapaselet

Rapaselet is a delta formed by the Rapaätno river between the Bielloriehppe massif (formerly written Piellorieppe) and the Skårki massif.
Expand Down
8 changes: 6 additions & 2 deletions CITATIONS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# nf-core/sarek: Citations

## [nf-core/sarek 3](https://www.biorxiv.org/content/10.1101/2023.07.19.549462v2)

> Hanssen F, Garcia MU, Folkersen L, Pedersen AS, Lescai F, Jodoin S, Miller E, Wacker O, Smith N, nf-core community, Gabernet G, Nahnsen S. Scalable and efficient DNA sequencing analysis on different compute infrastructures aiding variant discovery. bioRxiv. 2023 Jul 19:2023-07.

## [nf-core/sarek](https://pubmed.ncbi.nlm.nih.gov/32269765/)

> Garcia MU, Juhos S, Larsson M, Olason PI, Martin M, Eisfeldt J, DiLorenzo S, Sandgren J, Díaz De Ståhl T, Ewels PA, Wirta V, Nistér M, Käller M, Nystedt B. Sarek: A portable workflow for whole-genome sequencing analysis of germline and somatic variants. F1000Res. 2020 Jan 29;9:63. eCollection 2020. doi: 10.12688/f1000research.16665.2. PubMed PMID: 32269765.
Expand Down Expand Up @@ -74,6 +78,8 @@

> McKenna A, Hanna M, Banks E, et al.: The Genome Analysis Toolkit: a MapReduce framework for analyzing next-generation DNA sequencing data. Genome Res. 2010 Sep;20(9):1297-303. doi: 10.1101/gr.107524.110. Epub 2010 Jul 19. PubMed PMID: 20644199; PubMed Central PMCID: PMC2928508.

- [GNU sed](http://www.gnu.org/software/sed/)

- [HaplotypeCaller Joint Germline](https://www.biorxiv.org/content/10.1101/201178v3)

> Poplin R. et al, Scaling accurate genetic variant discovery to tens of thousands of samples, bioRxiv 2018. doi: 10.1101/201178
Expand Down Expand Up @@ -110,8 +116,6 @@

> Li H, Handsaker B, Wysoker A, Fennell T, Ruan J, Homer N, Marth G, Abecasis G, Durbin R; 1000 Genome Project Data Processing Subgroup. The Sequence Alignment/Map format and SAMtools. Bioinformatics. 2009 Aug 15;25(16):2078-9. doi: 10.1093/bioinformatics/btp352. Epub 2009 Jun 8. PubMed PMID: 19505943; PubMed Central PMCID: PMC2723002.

- [GNU sed](http://www.gnu.org/software/sed/)

- [snpEff](https://pubmed.ncbi.nlm.nih.gov/22728672/)

> Cingolani P, Platts A, Wang le L, et al.: A program for annotating and predicting the effects of single nucleotide polymorphisms, SnpEff: SNPs in the genome of Drosophila melanogaster strain w1118; iso-2; iso-3. Fly (Austin). Apr-Jun 2012;6(2):80-92. doi: 10.4161/fly.19695. PubMed PMID: 22728672; PubMed Central PMCID: PMC3679285.
Expand Down
5 changes: 0 additions & 5 deletions conf/test/cache.config
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ params {
}

process {
withLabel: 'sentieon' {
ext.sentieon_auth_mech_base64 = secrets.SENTIEON_AUTH_MECH_BASE64
ext.sentieon_auth_data_base64 = secrets.SENTIEON_AUTH_DATA_BASE64
}

// This must contain .* in order to properly overwrite the standard config in test cases
withName:'.*:FREEC_SOMATIC'{
ext.args = {
Expand Down
2 changes: 1 addition & 1 deletion docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ In particular, Sentieon contains what may be view as speedup version of some sta
Sentieon supply license in the form of a string-value (a url) or a file. It should be base64-encoded and stored in a nextflow secret named `SENTIEON_LICENSE_BASE64`. If a license string (url) is supplied, then the nextflow secret should be set like this:

```bash
nextflow secret set SENTIEON_LICENSE_BASE64 $(echo -n <sentieon_license_string> | base64 -w 0)
nextflow secrets set SENTIEON_LICENSE_BASE64 $(echo -n <sentieon_license_string> | base64 -w 0)
```

If a license file is supplied, then the nextflow secret should be set like this:
Expand Down
63 changes: 32 additions & 31 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,28 +77,29 @@
},
"controlfreec/assesssignificance": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "053564d29a20d45323547973c4023914923823df",
"installed_by": ["modules"]
},
"controlfreec/freec": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "053564d29a20d45323547973c4023914923823df",
"installed_by": ["modules"]
},
"controlfreec/freec2bed": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "053564d29a20d45323547973c4023914923823df",
"installed_by": ["modules"]
},
"controlfreec/freec2circos": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "053564d29a20d45323547973c4023914923823df",
"installed_by": ["modules"]
},
"controlfreec/makegraph": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"installed_by": ["modules"]
"git_sha": "053564d29a20d45323547973c4023914923823df",
"installed_by": ["modules"],
"patch": "modules/nf-core/controlfreec/makegraph/controlfreec-makegraph.diff"
},
"custom/dumpsoftwareversions": {
"branch": "master",
Expand Down Expand Up @@ -163,127 +164,127 @@
},
"gatk4/applybqsr": {
"branch": "master",
"git_sha": "240937a2a9c30298110753292be041188891f2cb",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/applybqsrspark": {
"branch": "master",
"git_sha": "bd8092b67b5103bdd52e300f75889442275c3117",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/applyvqsr": {
"branch": "master",
"git_sha": "359dcb06bda60c43955752e356e25c91cfd38ae0",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/baserecalibrator": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/baserecalibratorspark": {
"branch": "master",
"git_sha": "4b7d4863a5883b76e6bff13b6e52468fab090c5b",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/calculatecontamination": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/cnnscorevariants": {
"branch": "master",
"git_sha": "8c4542e5d421c4690cf1fa6ec729e9304763fdaf",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/createsequencedictionary": {
"branch": "master",
"git_sha": "541811d779026c5d395925895fa5ed35e7216cc0",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/estimatelibrarycomplexity": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/filtermutectcalls": {
"branch": "master",
"git_sha": "2df2a11d5b12f2a73bca74f103691bc35d83c5fd",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/filtervarianttranches": {
"branch": "master",
"git_sha": "541811d779026c5d395925895fa5ed35e7216cc0",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/gatherbqsrreports": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/gatherpileupsummaries": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/genomicsdbimport": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/genotypegvcfs": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/getpileupsummaries": {
"branch": "master",
"git_sha": "2df2a11d5b12f2a73bca74f103691bc35d83c5fd",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/haplotypecaller": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/intervallisttobed": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/learnreadorientationmodel": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/markduplicates": {
"branch": "master",
"git_sha": "0a261469640941da2488e1a5aa023b64db837c70",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/markduplicatesspark": {
"branch": "master",
"git_sha": "0a261469640941da2488e1a5aa023b64db837c70",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/mergemutectstats": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/mergevcfs": {
"branch": "master",
"git_sha": "911696ea0b62df80e900ef244d7867d177971f73",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/mutect2": {
"branch": "master",
"git_sha": "2df2a11d5b12f2a73bca74f103691bc35d83c5fd",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"gatk4/variantrecalibrator": {
"branch": "master",
"git_sha": "359dcb06bda60c43955752e356e25c91cfd38ae0",
"git_sha": "cf8f9ace77aac01caa5c7cb92af5bbda7adb77bd",
"installed_by": ["modules"]
},
"manta/germline": {
Expand Down
6 changes: 3 additions & 3 deletions modules/nf-core/controlfreec/assesssignificance/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions modules/nf-core/controlfreec/freec/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions modules/nf-core/controlfreec/freec2bed/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions modules/nf-core/controlfreec/freec2circos/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions modules/nf-core/controlfreec/makegraph/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions modules/nf-core/controlfreec/makegraph/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion modules/nf-core/gatk4/applybqsr/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading