Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add NGSCheckMate in as part of a cram sampleQC subworkflow #1252
[DRAFT] Add NGSCheckMate in as part of a cram sampleQC subworkflow #1252
Changes from 5 commits
94ca07d
21d38a2
2e72d1c
cee8614
9c48c87
a2496de
05f681e
9d9105c
2ab1e4d
ac649e0
a0e5f43
2c95984
97e1fa6
64273f3
ad97096
7378fe9
d37c24e
4e73bdb
8f59abc
3acaef9
e1706a3
01ae112
13df981
32227d3
10185fa
ac87102
cf1e116
5f25439
4e55d5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
sampleqc
and notngscheckmate
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that the other tools that have been discussed (sexdeterrmine, somalier) would go into the same subworkflow. So I thought they might be all controlled together, but if they should be more granular that is fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather be granular, as we already have some qc tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. maybe someone wants to run checkmate but not somalier etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, for most our QC tools, they enabled by default and disabled à la demande with --skip_tools, should we do that there?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.