Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light refactoring #1422

Merged
merged 27 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e8464fb
initialize params from the genome map
maxulysse Feb 23, 2024
1f3235d
add modules_testdata_base_path
maxulysse Feb 23, 2024
9b362ec
proper usage of logo
maxulysse Feb 23, 2024
e6b5ec5
Merge branch 'dev' into refactor_light
maxulysse Feb 23, 2024
b31e299
exclude tests
maxulysse Feb 23, 2024
396f026
sort tests exclusion
maxulysse Feb 23, 2024
64927c9
Merge branch 'dev' into refactor_light
maxulysse Feb 23, 2024
9dacebe
why is this file still there
maxulysse Feb 23, 2024
cadfd86
remove more lib
maxulysse Feb 26, 2024
d4d8eae
fix duplication
maxulysse Feb 26, 2024
9a1e0f2
Merge branch 'dev' into refactor_light
maxulysse Mar 5, 2024
501c5cb
small reorganization
maxulysse Mar 8, 2024
76fc410
all should work
maxulysse Mar 8, 2024
9c3fd40
small code polish
maxulysse Mar 8, 2024
cf2411c
update CHANGELOG
maxulysse Mar 8, 2024
1bf5222
Merge branch 'dev' into refactor_light
maxulysse Mar 11, 2024
62b4ea4
Adding .collect() to Channel.fromPath(params.fasta) and Channel.fromP…
asp8200 Mar 12, 2024
cbb2a62
fix getGenomeAttribute
maxulysse Mar 12, 2024
f9d1723
remove duplication
maxulysse Mar 12, 2024
5ac371d
Adding .collect() in the construction of the channels dict and fasta_fai
asp8200 Mar 21, 2024
5bd9856
Adding ascat_loci_gc in input definition for SAMPLESHEET_TO_CHANNEL
asp8200 Mar 21, 2024
4575cba
Adding params.ascat_loci_gc in call to SAMPLESHEET_TO_CHANNEL
asp8200 Mar 21, 2024
0e86cc2
refactor: chmod +x on main.nf
maxulysse Apr 3, 2024
853f7d1
Merge branch 'refactor_light' of github.com:maxulysse/nf-core_sarek i…
maxulysse Apr 3, 2024
ce5b800
refactor: no need for params to be ignored
maxulysse Apr 3, 2024
b065df0
fix: restore proper aligner usage
maxulysse Apr 3, 2024
100f9ea
prettier
maxulysse Apr 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ jobs:
- tags: "sentieon/haplotyper"
- tags: "sentieon/haplotyper_joint_germline"
- tags: "sentieon/haplotyper_skip_filter"
- NXF_VER: "latest-everything"
tags: "joint_germline"
env:
NXF_ANSI_LOG: false
TEST_DATA_BASE: "${{ github.workspace }}/test-datasets"
Expand Down Expand Up @@ -217,7 +219,6 @@ jobs:
- tags: "bwamem2/mem"
- tags: "cat/cat"
- tags: "cat/fastq"
- tags: "custom/dumpsoftwareversions"
- tags: "dragmap/align"
- tags: "fastp"
- tags: "fastqc"
Expand All @@ -230,8 +231,8 @@ jobs:
- tags: "multiqc"
- tags: "samtools/mpileup"
- tags: "samtools/stats"
- tags: "untar"
- tags: "subworkflows/utils_nfvalidation_plugin"
- tags: "untar"
env:
NXF_ANSI_LOG: false
TEST_DATA_BASE: "${{ github.workspace }}/test-datasets"
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#1360](https://github.com/nf-core/sarek/pull/1360) - Sync `TEMPLATE` with `tools` `2.11`
- [#1408](https://github.com/nf-core/sarek/pull/1408), [#1412](https://github.com/nf-core/sarek/pull/1412) - Updating samtools to v1.19.2 - except in GATK/markduplicates. (Temporarily disabled nf-test for bwamem2/mem.)
- [#1411](https://github.com/nf-core/sarek/pull/1411) - Temporarily disable sentieon related tests
- [#1414](https://github.com/nf-core/sarek/pull/1414) - Sync `TEMPLATE` with `tools` `2.13`
- [#1419](https://github.com/nf-core/sarek/pull/1419) - Updating GATK to v4.5, and updating samtools to v1.19.2 in GATK/markduplicates.
- [#1426](https://github.com/nf-core/sarek/pull/1426) - Updating certain modules in order to fix the testdata-path in the nf-tests of those modules. Setting Docker runOptions for params.use_gatk_spark.
- [#1428](https://github.com/nf-core/sarek/pull/1428) - Sync `TEMPLATE` with `tools` `2.13.1`
- [#1422](https://github.com/nf-core/sarek/pull/1422) - Refactoring following `TEMPLATE` sync with `tools` `2.13`
- [#1431](https://github.com/nf-core/sarek/pull/1431) - Using docker.containerOptions instead of docker.runOptions. Clearing containerOptions for SPARK modules for any kind of supported container engine.

### Fixed
Expand All @@ -43,6 +45,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#1390](https://github.com/nf-core/sarek/pull/1390) - Fix badges in README
- [#1400](https://github.com/nf-core/sarek/pull/1400) - Fixed input channel for ASSESS_SIGNIFICANCE module, updated makegraph to makegraph2.
- [#1403](https://github.com/nf-core/sarek/pull/1403) - Fix intervals usage with dot in chromosome names
- [#1407](https://github.com/nf-core/sarek/pull/1407) - Fix CI tests name
- [#1420](https://github.com/nf-core/sarek/pull/1420) - Make `-a` a default argument for `bcftools` concat
- [#1422](https://github.com/nf-core/sarek/pull/1422) - Fix `Cannot serialize context map` warning

### Removed

Expand Down
364 changes: 0 additions & 364 deletions lib/NfcoreTemplate.groovy

This file was deleted.

71 changes: 0 additions & 71 deletions lib/WorkflowMain.groovy

This file was deleted.

149 changes: 0 additions & 149 deletions lib/WorkflowSarek.groovy

This file was deleted.

Loading
Loading