Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parabricks alignment #1444

Closed
wants to merge 8 commits into from
Closed

Parabricks alignment #1444

wants to merge 8 commits into from

Conversation

Furentsu
Copy link

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @Furentsu,

It looks like this pull-request is has been made against the lescailab/sarek-devel master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the lescailab/sarek-devel dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3c05085

+| ✅ 181 tests passed       |+
#| ❔  14 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowSarek.groovy
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sarek/sarek/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-11 13:43:56

@Furentsu Furentsu self-assigned this Mar 21, 2024
@Furentsu Furentsu added the help wanted Extra attention is needed label Mar 21, 2024
@maxulysse maxulysse changed the base branch from master to dev March 27, 2024 13:52
maxulysse
maxulysse reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So looking fairly good, I have some ideas for improvements.
Sorry it took so long to check it out properly.
I'll be merging #1422 soon.
Do you mind if I push some commits here afterwards to ease the pain of solving the merge conflicts?

@Furentsu
Copy link
Author

Furentsu commented Apr 4, 2024

No problem, thanks for helping out :)

@Furentsu
Copy link
Author

Furentsu commented Apr 9, 2024

Hi @maxulysse, is there anything else I should do to merge this PR?

@maxulysse
Copy link
Member

Hi @maxulysse, is there anything else I should do to merge this PR?

I was thinking more doing a release this week and then merging it in, as this would be a major change, and that would be a good point for introducing a bit of refactoring.

I'll try to have a look and solve all merge conflicts once we merged #1457

@maxulysse maxulysse added this to the 3.5 milestone May 7, 2024
@Furentsu Furentsu requested a review from maxulysse June 19, 2024 08:57
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
@Furentsu Furentsu closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen FriederikeHanssen will be requested when the pull request is marked ready for review FriederikeHanssen is a code owner

Assignees

@Furentsu Furentsu

Labels
help wanted Extra attention is needed
Projects
No open projects
Hackathon: May 2024
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Furentsu @maxulysse @FriederikeHanssen