-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Minimap2 alignment #1459
Added Minimap2 alignment #1459
Conversation
💥 nice. I'll take a more in depth look later, but i noticed there are no changes to the igenomes config, so the user would regenerate the index file each time, right? Is the index available in igenomes? |
We didn't find index in igenomes |
ok we should pregenerate it and put it there. No need for users to recompute it everytime |
Did this get closed because it was merged in a separate PR? This seems like a useful feature to merge in now that the big 3.4.1 refactor is published. |
Indeed, @EgorGuga any reason for the closing? |
I messed up a bit with rebasing into 3.4.1. |
Overview
In this pull-reqest, we added the ability to align reads using the minimap2 tool. The use of the tool is justified by the fact that this tool is popular and is used in commercial solutions, particularly in MegaBOLT.
P.S.
As long as the sort_bam variable is hardcoded as true a call of the minimap2 tool will not cause any problems.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).