Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Minimap2 alignment #1459

Closed
wants to merge 257 commits into from
Closed

Added Minimap2 alignment #1459

wants to merge 257 commits into from

Conversation

EgorGuga
Copy link

Overview

In this pull-reqest, we added the ability to align reads using the minimap2 tool. The use of the tool is justified by the fact that this tool is popular and is used in commercial solutions, particularly in MegaBOLT.

P.S.
As long as the sort_bam variable is hardcoded as true a call of the minimap2 tool will not cause any problems.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Copy link
Contributor

💥 nice. I'll take a more in depth look later, but i noticed there are no changes to the igenomes config, so the user would regenerate the index file each time, right? Is the index available in igenomes?

@EgorGuga
Copy link
Author

We didn't find index in igenomes

@FriederikeHanssen
Copy link
Contributor

ok we should pregenerate it and put it there. No need for users to recompute it everytime

@EgorGuga EgorGuga closed this Apr 25, 2024
@kenibrewer
Copy link
Member

Did this get closed because it was merged in a separate PR? This seems like a useful feature to merge in now that the big 3.4.1 refactor is published.

@maxulysse
Copy link
Member

Did this get closed because it was merged in a separate PR? This seems like a useful feature to merge in now that the big 3.4.1 refactor is published.

Indeed, @EgorGuga any reason for the closing?
do you need any help into syncing the branch?

@EgorGuga
Copy link
Author

I messed up a bit with rebasing into 3.4.1.
I'm planning to make a separate pull-request for the new version ( the code is already written, but it needs to be tested).

@EgorGuga EgorGuga mentioned this pull request Apr 25, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants