Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Convert bcf_annotations.tbi from empty() to value channel to prevent stalling #1624

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Fix: Convert bcf_annotations.tbi from empty() to value channel to prevent stalling #1624

merged 5 commits into from
Nov 17, 2024

Conversation

bounlu
Copy link
Contributor

@bounlu bounlu commented Aug 16, 2024

Fixes #1622

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 15809f7

+| ✅ 215 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-15 22:43:17

FriederikeHanssen
FriederikeHanssen previously requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upadte the Changelog please?

@maxulysse
Copy link
Member

good catch

@FriederikeHanssen FriederikeHanssen changed the title Fixes bug Fix: Convert bcf_annotations.tbi from empty() to value channel to prevent stalling Aug 16, 2024
@allyssonallan allyssonallan mentioned this pull request Nov 6, 2024
Open
This was referenced Nov 6, 2024
Closed
Draft
soccin added a commit to soccin/sarek that referenced this pull request Nov 9, 2024
@soccin
Bug fix nf-core#1624
25a829b 
Convert bcf_annotations.tbi from empty() to value
channel to prevent stalling.
nf-core#1622
maxulysse
maxulysse previously approved these changes Nov 15, 2024
View reviewed changes
@maxulysse maxulysse merged commit 0f66cc2 into dev Nov 17, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bounlu @maxulysse @FriederikeHanssen