Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumor-only mode for Mutect2 and MSIsensor #354

Merged
merged 17 commits into from
Mar 10, 2021
Merged

Conversation

jfnavarro
Copy link
Contributor

@jfnavarro jfnavarro commented Feb 24, 2021

Currently the tumor samples are processed with Strelka (if included in --tools) which is not really designed
to process tumor samples. Changes have been made so to process tumor samples with
Mutect2 in tumor-only mode. The same has been done to MSIsensor to be able to compute
MSI scores for tumor samples in tumor-only mode (this required an upgrade to msisensor-pro).

Notes:

  • This is not meant to be merged into master since the next release is expected to switch to dsl2.
  • The documentation has not been updated to reflect these changes.
  • In this PR all the tumor samples are processed in tumor-only mode with Mutect2 and Strelka but the
    correct behaviour would be to process only the tumor-only samples with Mutect2 and the germline (normal)
    samples with Strelka (if there are any of course and if these tools are included in the --tools option).
  • This is an improvements over the current master branch and it has been tested on read data.
  • This is meant to be used for any user missing out these features or for the developers working on
    the next release (dsl2).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

main.nf Outdated
@@ -564,7 +564,7 @@ process get_software_versions {
freebayes --version &> v_freebayes.txt 2>&1 || true
freec &> v_controlfreec.txt 2>&1 || true
gatk ApplyBQSR --help &> v_gatk.txt 2>&1 || true
msisensor &> v_msisensor.txt 2>&1 || true
msisensor-pro &> v_msisensor.txt 2>&1 || true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep msisensor here, msisensor-pro is not in the main container, but just used for the msi processes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot about this one ;-)

Copy link
Contributor Author

@jfnavarro jfnavarro Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought you wanted to keep msisensor there instead of msisensor-pro

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got spot, I forgot again about that...

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like what you did there.

@maxulysse maxulysse merged commit 7c44773 into nf-core:dev Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants