Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metro map #512

Merged
merged 12 commits into from
Mar 25, 2022
Merged

Add metro map #512

merged 12 commits into from
Mar 25, 2022

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Mar 24, 2022 •
edited
Loading

Continue and replace / close #507 by @chelauk and close #503

thanks @chelauk @nickhsmith @FriederikeHanssen @FranBonath @jfy133

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse requested a review from a team March 25, 2022 14:38
FriederikeHanssen
FriederikeHanssen approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks a lot @ggabernet, @LaurenceKuhl , @christopher-hakkaart for feedback and suggestions

@maxulysse maxulysse merged commit 12b7e1c into nf-core:dev Mar 25, 2022
@maxulysse maxulysse deleted the dev_metromap branch March 25, 2022 14:54
@FriederikeHanssen FriederikeHanssen mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @FriederikeHanssen @chelauk