Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dragmap #514

Merged
merged 12 commits into from
Mar 25, 2022
Merged

Add dragmap #514

merged 12 commits into from
Mar 25, 2022

Conversation

maxulysse
Copy link
Member

Continue and replace #464 by @emiller88

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Copy link
Contributor

❤️ @emiller88 and @maxulysse only thing I see missing is adding Dragmap to the Citations, but I think we are way behind there anyways. Can update it at the very end

@maxulysse maxulysse merged commit 7f8c3b0 into nf-core:dev Mar 25, 2022
@maxulysse maxulysse deleted the dev_dragmap branch March 25, 2022 10:59
edmundmiller
edmundmiller reviewed Mar 25, 2022
View reviewed changes
conf/modules.config
@@ -52,6 +52,17 @@ process {
]
}

withName: 'DRAGMAP_HASHTABLE' {
ext.when = { !params.bwa && params.step == "mapping" && params.aligner == "dragmap" }
Copy link
Contributor

@edmundmiller edmundmiller Mar 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, I see how the when get's used now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller left review comments

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @FriederikeHanssen @edmundmiller