Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subway update #719

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Subway update #719

merged 6 commits into from
Sep 2, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen FriederikeHanssen requested review from jfy133 and chelauk and removed request for chelauk August 30, 2022 15:05
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 1c9b886

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-02 10:38:07

lassefolkersen
lassefolkersen approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@lassefolkersen lassefolkersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

@maxulysse
Copy link
Member

Changelog?

jfy133
jfy133 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Much cleaner now IMO!

Only comment I would have is you could replace the slight red background to a light grey, but that's me being fussy ;)

@FriederikeHanssen
Copy link
Contributor Author

Really nice! Much cleaner now IMO!

Only comment I would have is you could replace the slight red background to a light grey, but that's me being fussy ;)

um what? where is a red background?

@maxulysse
Copy link
Member

Really nice! Much cleaner now IMO!
Only comment I would have is you could replace the slight red background to a light grey, but that's me being fussy ;)

um what? where is a red background?

the gray background looks a little reddish, what is the gray you used?

@maxulysse maxulysse merged commit 4c469cb into nf-core:dev Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@lassefolkersen lassefolkersen lassefolkersen approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FriederikeHanssen @maxulysse @lassefolkersen @jfy133