Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove label memory_max from BaseRecalibrator process #73

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Remove label memory_max from BaseRecalibrator process #73

merged 1 commit into from
Dec 4, 2019

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Dec 3, 2019 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse requested a review from a team December 3, 2019 19:40
@maxulysse maxulysse self-assigned this Dec 3, 2019
@maxulysse maxulysse changed the title remove label memory_max from BaseRecalibrator process to fix #72 Remove label memory_max from BaseRecalibrator process Dec 3, 2019
szilvajuhos
szilvajuhos approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tack, will re-test the whole ICGC once we have enough disk space left (next week maybe)

apeltzer
apeltzer approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxulysse maxulysse merged commit fc08c2e into nf-core:dev Dec 4, 2019
@maxulysse maxulysse deleted the MemoryBaseRecalibrator branch December 4, 2019 09:42
@maxulysse maxulysse mentioned this pull request Dec 13, 2019
Closed
This was referenced Dec 23, 2019
Merged
Closed
Merged
@VivianRobin VivianRobin mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szilvajuhos szilvajuhos szilvajuhos approved these changes

@apeltzer apeltzer apeltzer approved these changes

Assignees

@maxulysse maxulysse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @apeltzer @szilvajuhos