Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More input checks #742

Merged
merged 6 commits into from
Sep 9, 2022
Merged

More input checks #742

merged 6 commits into from
Sep 9, 2022

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Sep 8, 2022

Closes #717

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0c2fb2d

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-09 07:09:51

@asp8200 asp8200 requested review from maxulysse and removed request for maxulysse September 8, 2022 20:01
maxulysse
maxulysse reviewed Sep 9, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
maxulysse
maxulysse approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@maxulysse
Copy link
Member

@nf-core-bot fix linting

@maxulysse maxulysse merged commit 046a7aa into nf-core:dev Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asp8200 @maxulysse @nf-core-bot