Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 950: samplesheet validation - no spaces in sample or patient names #978

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Issue 950: samplesheet validation - no spaces in sample or patient names #978

merged 3 commits into from
Mar 28, 2023

Conversation

matrulda
Copy link
Contributor

@matrulda matrulda commented Mar 28, 2023 •
edited
Loading

This fixes #950

Note that the pipeline is terminated using System.exit() which isn't recommended (nf-core/tools#1840). But I leave that for another PR since it has to be changed in multiple places.

Tested successfully (locally) with:

TMPDIR=~ PROFILE=docker pytest --tag sample_with_space  --symlink --kwdof --git-aware --color=yes

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matrulda matrulda changed the title Issue 950 samplesheet validation no spaces Issue 950: samplesheet validation - no spaces in sample or patient names Mar 28, 2023
@matrulda matrulda marked this pull request as draft March 28, 2023 09:16
@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit d48cc24

+| ✅ 152 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-28 11:28:41

@matrulda matrulda force-pushed the issue-950_samplesheet_validation_no_spaces branch from a579ed2 to 3e52960 Compare March 28, 2023 10:54
@matrulda matrulda force-pushed the issue-950_samplesheet_validation_no_spaces branch from 3e52960 to 8227588 Compare March 28, 2023 11:01
@matrulda matrulda marked this pull request as ready for review March 28, 2023 11:05
@maxulysse
Copy link
Member

maxulysse commented Mar 28, 2023 •
edited
Loading

Can you add this bit in tests/config/tags.yml? (EDIT: before L53)

validation_checks:
  - conf/modules/**
  - main.nf
  - modules/**
  - nextflow.config
  - nextflow_schema.json
  - subworkflows/**
  - tests/test_skip_markduplicates.yml
  - workflows/**

@maxulysse
Copy link
Member

And also this part in .github/workflows/pytest-workflow.yml in the exclude part (around L41-L57)

          - profile: "singularity"
            tags: validation_checks
          - profile: "conda"
            tags: validation_checks

matrulda and others added 2 commits March 28, 2023 13:21
@matrulda @maxulysse
Add validation_checks tag to spaces test
4174f0d 
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
@matrulda
Add new test to github actions workflow
d48cc24
@matrulda
Copy link
Contributor Author

Thanks @maxulysse ! I think I fixed it all now :)

@matrulda matrulda merged commit ee7656f into nf-core:dev Mar 28, 2023
@matrulda matrulda mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matrulda @maxulysse