Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.4.0 #256

Merged
merged 52 commits into from
Aug 24, 2023
Merged

Release v2.4.0 #256

merged 52 commits into from
Aug 24, 2023

Conversation

grst
Copy link
Member

@grst grst commented Aug 16, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

adamrtalbot and others added 30 commits June 7, 2023 12:03
…-multiqc

fix (231): Null object accessed in multiqc channel
…llranger

Fix_file_collision_when_using_cellranger
Add singularity.registry = 'quay.io' and bump NF version to 23.04.0
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d2648a4

+| ✅ 155 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-24 06:16:00

@matq007
Copy link
Member

matq007 commented Aug 16, 2023

There is a missing smartseq support in the nextflow_schema.json

@matq007
Copy link
Member

matq007 commented Aug 16, 2023

Also, there is a missing support if the experiment is single-read for StarSolo. Here is my quick fix solution starting from here

    // separate forward from reverse pairs
    def (forward, reverse) = reads.collate(2).transpose()

    if (meta.single_end) {
        forward = ''
        reverse = reads.join( "," )
    } else {
        reverse = reverse.join( "," )
        forward = forward.join( "," )
    }

    """
    STAR \\
        --genomeDir $index \\
        --readFilesIn $reverse $forward \\
        --runThreadN $task.cpus \\
        --outFileNamePrefix $prefix. \\
        --soloCBwhitelist <(gzip -cdf $whitelist) \\
        --soloType $protocol \\
        --soloFeatures $star_feature \\
        $other_10x_parameters \\
        $out_sam_type \\
        $ignore_gtf \\
        $seq_center \\
        $cell_filter \\
        $args \\

@grst
Copy link
Member Author

grst commented Aug 17, 2023

Hi @matq007,

smart-seq is not a multiplexed experiment, you can process it with the nf-core/rnaseq pipeline.
While we are definitely interested in supporting more platforms, it is out-of-scope for the v2.4.0 release.
Feel free to open an issue to discuss it further.

@matq007
Copy link
Member

matq007 commented Aug 17, 2023

Hi @matq007,

smart-seq is not a multiplexed experiment, you can process it with the nf-core/rnaseq pipeline. While we are definitely interested in supporting more platforms, it is out-of-scope for the v2.4.0 release. Feel free to open an issue to discuss it further.

I see, got it!

@grst grst requested a review from fmalmeida August 18, 2023 08:51
@fmalmeida
Copy link
Contributor

It seems that all is there.

@grst grst merged commit 61d1919 into master Aug 24, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants