-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge alpha into dev #279
Merged
Merge alpha into dev #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues to preferences
Co-authored-by: Bastiaan Verhaar <bastiaanv@users.noreply.github.com>
Co-authored-by: kskandis <kskandis@users.noreply.github.com>
…ts method to delete pump state used for testing only
* revert get and clean property value to original * add resetLoopDocuments method to delete pump state used for testing only
Added ability to add min and max values to decimals in preferences page
Add an option to confirm boluses faster on Apple Watch
Merge dev into alpha
PreferencesEditorDataFlow: commit Xcode auto formatting related to #232
Migrate fix for PumpManager: Use pump limit from pumpManager instead of UI
# You cannot revert from this without losing pod! Port over pump loss fix via LoopKit/Loop#1702
…raph - Resolves (Trio issue #289)[#289] - Implements Nightscout's provided graph display for fat and protein in meal entries - Trio had partially implemented this but did not pass fat and protein values to Nightscout (it dropped them but carried carbs) - This PR follows the identical pattern used for carbs and carries fat and protein values along for NS to display
Resolve issue #289: implement NS-provided display of fat/protein
Merged alpha into dev locally to test on a phone (iPhone 13 mini, iOS 17.5.1)
|
Sjoerd-Bo3
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Already running Live for a day :)
dnzxy
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging with two approvals. |
Merged
Merged
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Jun 15, 2024
Merge alpha into dev
4 tasks
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
Display remote commands from Nightscout in MainChart. Bolus, Temp basal, Open loop, Closed loop, Pump suspend, Pump resume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge of the alpha branch into dev brings a breaking change for backwards compatibility:
You cannot revert from this without losing a paired pod!
PR #277 "Port over pump loss fix via LoopKit/Loop#1702" changes the storage of pump connection details from "UserDefaults" to binary plist files stored in the documents directory of the app. This is ported from Loop, and is an attempt to avoid a bug where the connection to a paired pod could be lost unexpectedly.
After having connected a pod with this version of the app, it is not possible to transfer the pod to an older version of the app, the connection to pod will be lost. It should be possible to recover by rebuilding a version that includes 8a682e3, this should bring the connected pod back.