Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: refactor get_format #53872

Merged
merged 1 commit into from
Jul 18, 2024
Merged

esm: refactor get_format #53872

merged 1 commit into from
Jul 18, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 16, 2024

Extracted from aadf162

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 16, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60383/

@aduh95 aduh95 mentioned this pull request Jul 17, 2024
Merged
mcollina
mcollina approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60390/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit cafd44d into nodejs:main Jul 18, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cafd44d

ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@aduh95 @ehsankhfr
esm: refactor get_format
d6a2f0b 
PR-URL: nodejs#53872
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@aduh95 aduh95 deleted the get_format-refactor branch July 18, 2024 21:23
targos pushed a commit that referenced this pull request Jul 28, 2024
@aduh95 @targos
esm: refactor get_format
dcca9ba 
PR-URL: #53872
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @mcollina @ShogunPanda @GeoffreyBooth @targos