doc: add documentation for process.features #54897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
marco-ippolito
force-pushed
the
fix/document-process-features
branch
3 times, most recently
from
95d9102 to
26cf87c
Compare
aduh95
reviewed
Sep 12, 2024
| ## `process.features.cached_builtins` | ||
|
|
||
| <!-- YAML | ||
| added: REPLACEME |
There was a problem hiding this comment.
Suggested change
| added: REPLACEME | |
| added: v12.0.0 |
There was a problem hiding this comment.
I don't understand, why were all these suggestions resolved but not applied?
There was a problem hiding this comment.
I see I have overwritten the commit with the suggestions with a rebase, probably not updated the remote and force pushed https://github.com/nodejs/node/compare/15d260e6bef2c00f1ca9ef84fa361a551d82976e..e3f91db3ae988513599915ad8f6e73068f2bb0da
There was a problem hiding this comment.
I've opened #54982 to fix this.
avivkeller
added
the
commit-queue-squash
Ethan-Arrowood
approved these changes
Sep 12, 2024
marco-ippolito
added
the
author ready
trivikr
approved these changes
Sep 13, 2024
lpinca
added
the
commit-queue
aduh95
approved these changes
Sep 13, 2024
legendecas
reviewed
Sep 13, 2024
marco-ippolito
force-pushed
the
fix/document-process-features
branch
from
15d260e to
e3f91db
Compare
legendecas
approved these changes
Sep 13, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in cb20c5b |
Merged
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54897 Refs: nodejs#54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito
added
the
backport-requested-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54897 Refs: nodejs#54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting
process.features.Refs: #54295