repl: runtime deprecate instantiating without new #54869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RedYetiDev
force-pushed
the
repl-deprecate-2
branch
from
bb00db5
to
ae8d325
Compare
RedYetiDev
added
semver-major
RedYetiDev
force-pushed
the
repl-deprecate-2
branch
from
ae8d325
to
7f70642
Compare
anonrig
reviewed
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54869 +/- ##
==========================================
- Coverage 88.43% 88.32% -0.11%
==========================================
Files 654 654
Lines 187662 187673 +11
Branches 36120 36044 -76
==========================================
- Hits 165955 165763 -192
- Misses 14948 15133 +185
- Partials 6759 6777 +18
|
|
CC @nodejs/repl |
jasnell
requested changes
Sep 10, 2024
There was a problem hiding this comment.
I think we need a documentation-only deprecation on this first and we need to get a sense of how impactful a runtime deprecation would be on the ecosystem here. Given the nature of the repl module, this would most likely lead to a fair bit of console output noise for modules that are using the repl and users may not actually be able to do anything about it. So let's be careful.
FWIW It has already been doc-deprecated (but very recently). |
RedYetiDev
force-pushed
the
repl-deprecate-2
branch
from
7f70642
to
1ada6a0
Compare
LiviaMedeiros
approved these changes
Sep 13, 2024
|
@jasnell would you be opposed to landing this in v23 entirely-I'm happy to wait until v24? |
|
I prefer to wait |
|
Got it. While I'd prefer for this to release in v23, I respect your opinion. I'll look into other optimizations in the meantime. |
|
@nodejs/tsc per nodejs/Release#1034 My main question is: is this something that could happen in v23? Or should it wait (like @jasnell suggested)? |
|
I agree with James on this |
|
Let's give people some time to make arrangements, before polluting their console. |
|
I've added the blocked label, as this should go out with v24. @jasnell, Putting aside the 'dont release yet', could you re-review? |
RedYetiDev
added
dont-land-on-v23.x
RedYetiDev
force-pushed
the
repl-deprecate-2
branch
from
4235f74
to
e9a2c30
Compare
RedYetiDev
added
the
commit-queue-squash
aduh95
reviewed
Oct 26, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
RedYetiDev
force-pushed
the
repl-deprecate-2
branch
from
1106f9b
to
1974e39
Compare
|
Hey, I assume this needs a new CI since there has been commits since the latest change, can someone start it? The CITGM shouldn't need a rerun tho (IIUC) |
github-actions
bot
removed
the
request-ci
|
Can someone restart the fialed build so this can land? Thanks! |
|
The CI is 📗, can this land 🚀? |
JakobJingleheimer
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54869 ✔ Done loading data for nodejs/node/pull/54869 ----------------------------------- PR info ------------------------------------ Title repl: runtime deprecate instantiating without new (#54869) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:repl-deprecate-2 -> nodejs:main Labels util, repl, semver-major, author ready, deprecations, needs-ci, needs-citgm, commit-queue-squash Commits 6 - repl: runtime deprecate instantiating without new - fixup! - fixup! fixup! - fixup! fixup! fixup! - fix flaky test - fixup! fix flaky test Committers 2 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/54869 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54869 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - repl: runtime deprecate instantiating without new ⚠ - fixup! ⚠ - fixup! fixup! ⚠ - fixup! fixup! fixup! ⚠ - fix flaky test ⚠ - fixup! fix flaky test ℹ This PR was created on Mon, 09 Sep 2024 23:11:31 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54869#pullrequestreview-2383013809 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54869#pullrequestreview-2302928904 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54869#pullrequestreview-2374242695 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54869#pullrequestreview-2397344156 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-03T06:43:31Z: https://ci.nodejs.org/job/node-test-pull-request/63402/ ℹ Last CITGM CI on 2024-10-24T21:16:40Z: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3494/ - Querying data for job/node-test-pull-request/63402/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11712304862 |
RedYetiDev
removed
the
commit-queue-failed
JakobJingleheimer
approved these changes
Nov 7, 2024
JakobJingleheimer
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0368f2f |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54869 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #54842
This PR runtime-deprecates instantiating the REPL classes without the
newkeyword.