forked from argoproj/argo-cd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(repo-server): excess git requests, cache lock on revisions #2
Open
nromriell
wants to merge
263
commits into
lsremote-part2
Choose a base branch
from
lsremote-part3
base: lsremote-part2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1597b4c
to
c32957c
Compare
31f0ef7
to
6e08acf
Compare
…16603) * fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * chore: update message and simplify code Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't warn on partial sync Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix(ui): lint Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat: Implement Server-Side Diff Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * propagate the refreshtype to the diff config Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Create the serverSideDiff config Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * chore: add featureflag utility package Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * remove featureflag package Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * add param Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * make ssd configurable with app annotation Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * add server-side-diff flags Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * apply the same logic regardless of the refresh type Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix gitops-engine reference Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * docs: add docs related to server-side-diff Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * docs: update doc Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Add config to include mutation webhooks Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Address review comments Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * go mod update Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Add sdd cache test case Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix ssd cache unit test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Update clidocs Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * update manifests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix procfile Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * additional doc changes Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * update gitops-engine version Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
* add extension Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename to status panel Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add docs Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add key Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix copy/paste Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * lint Signed-off-by: Alexy Mantha <alexy@mantha.dev> * document flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename Signed-off-by: Alexy Mantha <alexy@mantha.dev> * linting Signed-off-by: Alexy Mantha <alexy@mantha.dev> --------- Signed-off-by: Alexy Mantha <alexy@mantha.dev>
…#16645) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
…r alternative. (argoproj#16690) Signed-off-by: Sanchaai Mathiyarasan <sanchaai.mathi@gmail.com>
…ion guide (argoproj#16691) Signed-off-by: Mark Estiller <markalestiller@gmail.com>
…ist (argoproj#16659) Based on https://github.com/argoproj/gitops-engine/blob/master/pkg/sync/hook/delete_policy.go#L13 multiple hook delete policies are also allowed. Signed-off-by: Nenad Strainovic <nenad.strainovic@asseco-see.rs>
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs: remove core install commands from getting started I often accidentally run the core install commands when quickly copying and pasting commands from the getting started guide, which leads to confusion. I've also spent plenty of time helping newcomers to Argo CD who have done the same and are confused when they can't reach the UI. Given that this is a "getting started" guide, it's ideal to provide only the commands required. I've removed the commands and left the link out to the core install page for those who are interested in going down that path. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * fix: use link to install commands in core docs Signed-off-by: Nicholas Morey <nicholas@morey.tech> * fix: use tip and improve wording Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Greg Werner <werner.greg@gmail.com>
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <yicai@redhat.com> * Updated log line-height Signed-off-by: Yi Cai <yicai@redhat.com> --------- Signed-off-by: Yi Cai <yicai@redhat.com>
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Missing \ in example Signed-off-by: mfreeman451 <mfreeman451@gmail.com>
Signed-off-by: Lie Ryan <lie.1296@gmail.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
… in argocd-server (argoproj#16786) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* add list permissions for deployments to application controller Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert redis-ha chart changes Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert redis-ha chart changes Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
…for one chart (argoproj#17518) * fix: Argo CD unnecessary enforce sequential helm manifest generation for one chart Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Update docs/operator-manual/high_availability.md Signed-off-by: Dan Garfield <dan@codefresh.io> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3df4ab11eba7bda6032a0b82a6bb43b11571feac to 8410ad0602e1e429cee44a835ae9f77f654a6694. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8410ad0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…on (argoproj#17521) * Add error messages to return statements in BlockingDial function Signed-off-by: danqixu <yzxudanqi@gmail.com> * amend error wrapping from %s to %w Signed-off-by: danqixu <yzxudanqi@gmail.com> --------- Signed-off-by: danqixu <yzxudanqi@gmail.com>
* chore(deps): upgrade helm to 3.14.3 Signed-off-by: David Bunn <david.bunn@prodigygame.com> * chore(deps): upgrade helm to 3.14.3 Signed-off-by: David Bunn <david.bunn@prodigygame.com> --------- Signed-off-by: David Bunn <david.bunn@prodigygame.com>
…roj#17537) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.2.0 to 5.3.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@af5a7ed...2cdde99) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…proj#17485) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
…ta to stable (argoproj#17529) * Update the status of the feature, app in any namespace, from beta to stable Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * adding warning and removing **Current feature state** Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> --------- Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
* feat: pick random user and exclude admin user and current user from deletion candidates Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: increase default max cache size Signed-off-by: pashakostohrys <pavel@codefresh.io> * add nil protection Signed-off-by: pashakostohrys <pavel@codefresh.io> * Update util/session/sessionmanager.go Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Dan Garfield <dan@codefresh.io> * chore: fix linter issues Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io>
* fix: Fix concurrency issue in session manager Signed-off-by: jannfis <jann@mistrust.net> * Add note that modification to the map must be done in a thread safe manner * chore: fix linter issues Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: pashakostohrys <pavel@codefresh.io> Co-authored-by: Dan Garfield <dan@codefresh.io> Co-authored-by: pashakostohrys <pavel@codefresh.io>
…17555) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.35 to 8.4.36. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.35...8.4.36) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps library/registry from `f4e1b87` to `fb9c9ae`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#15950) * doc(cli): update argocd_app_diff Adding the fact that secrets are ignored by the diff (not really stated in the doc so far) Signed-off-by: ario0 <118843430+ario0@users.noreply.github.com> * doc: remove whitespace Signed-off-by: ario0 <118843430+ario0@users.noreply.github.com> --------- Signed-off-by: ario0 <118843430+ario0@users.noreply.github.com> Signed-off-by: Alexis Renard <renard.alexis@hotmail.fr> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
…rce application (argoproj#17425) * "feat:add cli commands to create/set/unset/edit sources for multi-source app" Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fixed the ci failure Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update commands Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * error out if source-index not specified for multi-source applications Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fixed the ci failure Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * set 0 as default source index for app create Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * add index to ParameterOverrides function Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * do not allow overrides for applications with multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * remove create with override example Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update examples in docs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update logs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add test and update docs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* cluster-add-link Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * docs Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * docs-panel Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * added Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * fixed Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
…17573) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.36 to 8.4.37. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.36...8.4.37) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: jannfis <jann@mistrust.net>
Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#17598) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.1 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.1...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…17582) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.37 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.37...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…proj#17542) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7524) Bumps [docker/login-action](https://github.com/docker/login-action) from 2.2.0 to 3.1.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@465a078...e92390c) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9. - [Commits](indutny/node-ip@v1.1.5...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: nromriell <nateromriell@gmail.com>
Signed-off-by: nromriell <nateromriell@gmail.com>
Signed-off-by: nromriell <nateromriell@gmail.com>
Signed-off-by: nromriell <nateromriell@gmail.com>
cdddedd
to
d8c2313
Compare
* fix: invalid badge validation Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use util methods Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * rfc accept both lower and upper Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix unit test affecting each other with var modification Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
Signed-off-by: nromriell <nateromriell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes argoproj#14725
Third part of a split of the argoproj#16309 and follow-up to argoproj#16410
Another piece of the fixes for argoproj#14725. This resolves the excess ls-remote requests that still occur in high application count environments due to the fact that all active processes get their cache invalidated at the same time. When this happens they all try to re-fetch the remotes at the same time and all miss the cache.
The solution is to add a soft cache level lock on the key, the first process to try and access that key on a miss will obtain the lock and attempt to refresh the cache.
This changed required adding the ability to use "set only if not exists" on the util/cache (redis NX or memcached add) interface. Without this option all of the processes could still end up in a position where they think they own the lock, so there are some minor changes to the util/cache interface:
DisableOverwrite
option to represent the NX/add during set optionItem
struct now also contains options for the cache set actions. This allows passingDelete
andDisableOverwrite
in a shared options value and replaces the position of the currentdelete
option in the SetItem callThis is the final major logic portion of the changes to remove all the excess git calls, but we can get some good performance improvements by also adding the two layer cache to the caching layer for revisions. So I'll be following up with another PR to add that. Most of the abstraction to prepare for that was handled as part of this PR.
Baseline v2.9.0 with 200 multi-source applications with a ref only source:

With all the changes up to and including this PR under the same conditions:

Checklist: