feat: dotmailer views

[cewei8483]

This change is 

[KamilPawel]

Reviewed 11 of 82 files at r1, 69 of 69 files at r2, all commit messages.
Reviewable status: 80 of 82 files reviewed, 8 unresolved discussions (waiting on @cewei8483)

---

backend/Pipfile line 39 at r2 (raw file):

google-cloud-container = "==2.3.0"
"django-anymail[amazon_ses]" = "==7.0.*"
django-cors-headers = "*"

Use pip freeze to get the current version of django-cors-headers and set it to that version :)

---

backend/portal/views/dotmailer.py line 16 at r2 (raw file):

import json

@csrf_exempt

I do think it is easier to disable csrf in settings rather than for every view?

---

backend/portal/views/dotmailer.py line 24 at r2 (raw file):

            validate_email(user_email)
        except ValidationError:
            return JsonResponse(status=200, data={'success': False})

If validation is false should possible return a bad request; code 400?

---

backend/portal/views/dotmailer.py line 32 at r2 (raw file):

@csrf_exempt

Same here

---

backend/portal/views/dotmailer.py line 48 at r2 (raw file):

            return JsonResponse(status=200, data={'success': True})
        
    return HttpResponse(status=405)

New empty line at the end of the file

---

backend/service/settings.py line 72 at r2 (raw file):

    "corsheaders.middleware.CorsMiddleware",
    "django.middleware.common.CommonMiddleware",
    "django.middleware.csrf.CsrfViewMiddleware",

if you comment this out, it will disable csrf

Code quote:

 "django.middleware.csrf.CsrfViewMiddleware",

---

frontend/src/app/api.ts line 10 at r2 (raw file):

  FetchBaseQueryError
} from '@reduxjs/toolkit/query';
import { useNavigate } from 'react-router-dom';

Why did you remove it and used window object?

---

frontend/src/features/footer/SignUp.tsx line 41 at r2 (raw file):

  const handleSubmit = (values: SignUpValues, { setSubmitting }: FormikHelpers<SignUpValues>): void => {
    setSubmitting(false);

setSubmitting should be done if the request fails, so in the catch block. Otherwise if we submit and something goes wrong and the form in some way relies on this, the user will not be able to submit

[KamilPawel]

Reviewable status: 80 of 82 files reviewed, 9 unresolved discussions (waiting on @cewei8483)

---

frontend/src/app/api.ts line 15 at r2 (raw file):

const baseQuery = fetchBaseQuery({
  // baseUrl: process.env.REACT_APP_API_BASE_URL
  baseUrl: 'http://localhost:8000/'

Should ideally overwrite value in the .env file 🤔

Code quote:

  // baseUrl: process.env.REACT_APP_API_BASE_URL
  baseUrl: 'http://localhost:8000/'

[cewei8483]

Reviewable status: 77 of 82 files reviewed, 9 unresolved discussions (waiting on @KamilPawel)

---

backend/Pipfile line 39 at r2 (raw file):

Previously, KamilPawel wrote…

Use pip freeze to get the current version of django-cors-headers and set it to that version :)

Done.

---

backend/portal/views/dotmailer.py line 16 at r2 (raw file):

Previously, KamilPawel wrote…

I do think it is easier to disable csrf in settings rather than for every view?

This one is there in the old repo so I'll keep it.

---

backend/portal/views/dotmailer.py line 24 at r2 (raw file):

Previously, KamilPawel wrote…

If validation is false should possible return a bad request; code 400?

If the BE returns 400 it will be redirected to error pages, which is not our intended behaviour.

---

backend/portal/views/dotmailer.py line 32 at r2 (raw file):

Previously, KamilPawel wrote…

Same here

Done.

---

backend/portal/views/dotmailer.py line 48 at r2 (raw file):

Previously, KamilPawel wrote…

New empty line at the end of the file

Done.

---

backend/service/settings.py line 72 at r2 (raw file):

Previously, KamilPawel wrote…

if you comment this out, it will disable csrf

Got it. But I think we should keep it enabled on main branch?

---

frontend/src/app/api.ts line 10 at r2 (raw file):

Previously, KamilPawel wrote…

Why did you remove it and used window object?

If you use hook inside this, it will complain about Invalid hook call since RTK query is already using hook to wrap it up. I discussed with Stefan the other day about this and he suggested using window object to avoid hook.

---

frontend/src/app/api.ts line 15 at r2 (raw file):

Previously, KamilPawel wrote…

Should ideally overwrite value in the .env file 🤔

Done.

---

frontend/src/features/footer/SignUp.tsx line 41 at r2 (raw file):

Previously, KamilPawel wrote…

setSubmitting should be done if the request fails, so in the catch block. Otherwise if we submit and something goes wrong and the form in some way relies on this, the user will not be able to submit

I thought once the form is submitted, isSubmitted should be set to false?

[KamilPawel]

Reviewed 2 of 82 files at r1, 2 of 3 files at r3, all commit messages.
Reviewable status: 80 of 82 files reviewed, 1 unresolved discussion (waiting on @cewei8483)

---

backend/service/settings.py line 72 at r2 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Got it. But I think we should keep it enabled on main branch?

Yea for dev purposes :)

---

frontend/src/features/footer/SignUp.tsx line 41 at r2 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

I thought once the form is submitted, isSubmitted should be set to false?

I was thinking that once the submission is done, then you would set submission to false right ?

[KamilPawel]

Reviewable status: 80 of 82 files reviewed, 1 unresolved discussion (waiting on @cewei8483)

---

frontend/src/app/api.ts line 15 at r2 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Done.

👍

[cewei8483]

Reviewable status: 76 of 82 files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

---

frontend/src/features/footer/SignUp.tsx line 41 at r2 (raw file):

Previously, KamilPawel wrote…

I was thinking that once the submission is done, then you would set submission to false right ?

Done.

[KamilPawel]

Reviewed 1 of 3 files at r3, 1 of 1 files at r4, 4 of 4 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @cewei8483)

[KamilPawel]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @cewei8483)

---

backend/portal/urls.py line 9 at r5 (raw file):

    url(r"^api/news_signup/$", process_newsletter_form, name="process_newsletter_form"),
    url(r"^api/consent_form/$", dotmailer_consent_form, name="consent_form"),
    url(r".*", render_react, name="react_app"),

I tested the api views, and the react one is still being called when pulling?

[KamilPawel]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @cewei8483)

---

frontend/src/app/api.ts line 49 at r5 (raw file):

        url: 'news_signup/',
        method: 'POST',
        body: payload

Did we say we are going with JSON or QS encoding?

[KamilPawel]

Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @cewei8483)