feat: 158 teacher teach edit student details

[KamilPawel]

This change is 

[cewei8483]

Please fix all the eslint errors (I didn't mark them all)

Reviewable status: 0 of 20 files reviewed, 16 unresolved discussions (waiting on @KamilPawel)

---

backend/portal/views/teacher/dashboard.py line 95 at r1 (raw file):

from django.core.exceptions import ObjectDoesNotExist

move import to top

---

backend/portal/views/teacher/teach.py line 616 at r1 (raw file):

                "onboarding_done": True,
                "query_data": students_info,  # this field could be redundant
                # "class_url": request.build_absolute_uri(

delete if not used

---

backend/portal/views/teacher/teach.py line 977 at r1 (raw file):

# @csrf_exempt
# def teacher_print_reminder_cards(request, access_code):

delete these comments if not used and not going to be referred

---

backend/portal/views/teacher/teach.py line 1088 at r1 (raw file):

@csrf_exempt

remove this (and its import)

---

frontend/src/components/form/StudentNameField.tsx line 15 at r1 (raw file):

  helperText = 'Choose a name',
  disabled = false,
  style,

eslint

---

frontend/src/features/newStudentsTable/NewStudentsTable.tsx line 96 at r1 (raw file):

    }
  };
  const buttonStyles = isButtonBanner ? {

eslint

---

frontend/src/features/newStudentsTable/NewStudentsTable.tsx line 230 at r1 (raw file):

                <Typography marginRight={2}>Class link:</Typography>
                <Typography className="nowrap-ellipsis">
                  {classLink} {'lol'}

lol

---

frontend/src/pages/login/MyDocument.tsx line 5 at r1 (raw file):

import CflLogo from '../../images/cfl_logo.png';

eslint

---

frontend/src/pages/teacherDashboard/classes/editClass/EditClass.tsx line 85 at r1 (raw file):

  };

  const { data, error, isLoading } = useGetStudentsByAccessCodeQuery({ accessCode });

should be disappeared after merging dev

---

frontend/src/pages/teacherDashboard/classes/editClass/EditClass.tsx line 204 at r1 (raw file):

  );
};

eslint

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 84 at r1 (raw file):

  const initialValues: Values = {
    password: '',
    confirmPassword: '',

eslint

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 92 at r1 (raw file):

      password: values.password,
      studentId,
      confirmPassword: values.confirmPassword,

eslint

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 141 at r1 (raw file):

          marginBottom={theme.spacing(11.5)}
        >
          Edit student details for Florian from class Class 1 ({accessCode})

replace Florian with student name

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/UpdatedStudentCredentials.tsx line 4 at r1 (raw file):

import ClassCredentials from '../../../../../teacherOnboarding/ClassCredentials';
import Page from 'codeforlife/lib/esm/components/page';
import { Print } from '@mui/icons-material';

eslint

---

frontend/src/pages/teacherOnboarding/ClassCredentials.tsx line 42 at r1 (raw file):

    path = paths.teacher.dashboard.classes._;
    buttonText = 'Back to class';
  }

Use consts to make them conciser, e.g. const startIcon = studentData ? <ChevronLeftOutlined /> : <></>;

---

frontend/src/pages/teacherOnboarding/ClassCredentials.tsx line 44 at r1 (raw file):

  }

  // TODO: get from API.

remove this line if the data is already from API

[cewei8483]

Reviewable status: 0 of 20 files reviewed, 17 unresolved discussions (waiting on @KamilPawel)

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/UpdatedStudentCredentials.tsx line 16 at r2 (raw file):

      header={`${className}, (${accessCode})`}
      textAlign='center'
      subheader='Class and class access code:' />

swap the header & subheader

[KamilPawel]

Reviewable status: 0 of 25 files reviewed, 17 unresolved discussions (waiting on @cewei8483)

---

backend/portal/views/teacher/dashboard.py line 95 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

move import to top

Done.

---

backend/portal/views/teacher/teach.py line 616 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

delete if not used

Done.

---

backend/portal/views/teacher/teach.py line 977 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

delete these comments if not used and not going to be referred

this may be needed similar to csv, added TODO as well, where it has the analytic

---

backend/portal/views/teacher/teach.py line 1088 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

remove this (and its import)

Done.

---

frontend/src/features/newStudentsTable/NewStudentsTable.tsx line 96 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

Done.

---

frontend/src/features/newStudentsTable/NewStudentsTable.tsx line 230 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

lol

Done.

---

frontend/src/pages/login/MyDocument.tsx line 5 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

?

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 84 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

Done.

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 92 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

Done.

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 141 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

replace Florian with student name

Done.

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/UpdatedStudentCredentials.tsx line 4 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

Done.

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/UpdatedStudentCredentials.tsx line 16 at r2 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

swap the header & subheader

Done.

---

frontend/src/pages/teacherOnboarding/ClassCredentials.tsx line 42 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Use consts to make them conciser, e.g. const startIcon = studentData ? <ChevronLeftOutlined /> : <></>;

Done.

---

frontend/src/pages/teacherOnboarding/ClassCredentials.tsx line 44 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

remove this line if the data is already from API

Done.

---

frontend/src/components/form/StudentNameField.tsx line 15 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

Done.

---

frontend/src/pages/teacherDashboard/classes/editClass/EditClass.tsx line 85 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

should be disappeared after merging dev

Done.

---

frontend/src/pages/teacherDashboard/classes/editClass/EditClass.tsx line 204 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

eslint

Done.

[cewei8483]

Reviewable status: 0 of 25 files reviewed, 6 unresolved discussions (waiting on @KamilPawel)

---

backend/portal/views/teacher/teach.py line 586 at r6 (raw file):

        domain = settings.SERVICE_DOMAIN
        login_url = (
            f"{protocol}://{domain}/api/u/{student.new_user.id}/{uuidstr}/"

port

---

backend/portal/views/teacher/teach.py line 1084 at r6 (raw file):

def teacher_print_reminder_cards(request, access_code):

add @login_required

---

backend/portal/views/teacher/teach.py line 1141 at r6 (raw file):

def get_student_data(request):

comment this as well (it seems that it's only called by teacher_download_csv)

---

frontend/src/pages/privacyNotice/ForAdults/HowWeUseInfo.tsx line 16 at r6 (raw file):

const CustomTableRow: React.FC<{
  left: string,
  right: any;

remove the semicolon as it's not needed and not relevant to the task

---

frontend/src/pages/teacherDashboard/classes/editClass/EditClass.tsx line 252 at r6 (raw file):

  const studentData = data?.studentsPerAccessCode;

eslint 😂

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/EditStudent.tsx line 76 at r6 (raw file):

  const [editStudentPassword] = useEditStudentPasswordMutation();
  const location = useLocation();
  console.log(location);

remove console.log

[cewei8483]

Reviewable status: 0 of 25 files reviewed, 6 unresolved discussions (waiting on @KamilPawel)

[faucomte97]

Reviewed 1 of 20 files at r1, 2 of 9 files at r2, 1 of 12 files at r3, 1 of 1 files at r9, 2 of 3 files at r10, 1 of 4 files at r12, 4 of 14 files at r13, 1 of 7 files at r14, 16 of 29 files at r15, all commit messages.
Reviewable status: 33 of 52 files reviewed, 14 unresolved discussions (waiting on @cewei8483 and @KamilPawel)

---

backend/Pipfile line 31 at r15 (raw file):

google-cloud-container = "==2.3.0"
"django-anymail[amazon_ses]" = "==7.0.*"
codeforlife = {ref = "158-teacher-teach-edit-student-details", git = "https://github.com/ocadotechnology/codeforlife-package-python.git"}

Reminder of branch install

---

backend/portal/urls/teacher/dashboard.py line 95 at r15 (raw file):

        r"^class/student/(?P<student_id>[0-9]+)/$",
        get_student_details,
        name="get_student_details",

Please double check whether these two endpoints are needed in this file (they don't seem like teacher dashboard features to me)

Code quote:

    re_path(
        rf"^class/students/(?P<access_code>{ACCESS_CODE_REGEX})/$",
        get_students_from_access_code,
        name="get_students_from_acccess_code",
    ),
    re_path(
        r"^class/student/(?P<student_id>[0-9]+)/$",
        get_student_details,
        name="get_student_details",

---

backend/portal/views/school.py line 7 at r15 (raw file):

class SchoolViewSet(_SchoolViewSet):
    http_method_names = ["get", "post", "patch", "delete"]

Users don't actually have the functionality to delete schools yet.
Schools as of now never get deleted unless we do so in the django admin.

---

backend/portal/views/teacher/dashboard.py line 99 at r15 (raw file):

def get_student_details(request, student_id):

Just questioning again why this endpoint and the one above are here in the dashboard file. Seems like class specific endpoints to me.
Now that I'm typing this I'm thinking this endpoint might be needed in the dashboard for the independent student join requests, but still not sure about the one above.

---

backend/portal/views/teacher/teach.py line 535 at r15 (raw file):

    if request.method == "POST":
        if "name" in request.POST:

Why replace the old check with this one?

---

backend/portal/views/teacher/teach.py line 568 at r15 (raw file):

        return JsonResponse(
            {
                "message": "Your details were not updated due to incorrect details"

I can't think of a case where this would happen? (basically do we need that piece of code?)

---

backend/portal/views/teacher/teach.py line 939 at r15 (raw file):

# to fix the dictionary issue, feel free to use it and
# delete this method
def expand_key(dictionary):

Not sure what the issue in question here is, also not sure if it's worth being more specific.

---

backend/portal/views/teacher/teach.py line 1113 at r15 (raw file):

# TODO: before deploying make sure the count_student_details_click is implemented

Not too sure what is going on in this file. Not yet able to tell which parts are implemented or not (I do have a lot of the review left)

---

frontend/src/app/api/klass.ts line 111 at r15 (raw file):

      }),
      invalidatesTags: (result, error, { accessCode }) => !error
        ? [{ type: 'school', id: accessCode }]

why type school? Should be class no?

---

frontend/src/app/api/school.ts line 25 at r15 (raw file):

    country: string;
    county: null | string;
    isActive?: boolean;

Not too sure why some of these are optional and others aren't. County could very well be optional imo.
I think there were similar inconsistencies in the Class model too.

Code quote:

    county: null | string;
    isActive?: boolean;

---

frontend/src/app/api/user.ts line 27 at r15 (raw file):

    lastName: string;
    email: string;
    password: null | string;

Didn't you say the password field should be writeOnly?

---

frontend/src/app/api/user.ts line 124 at r15 (raw file):

        : []
    }),
    updateUser: build.mutation<

no BulkUpdateUsers?

---

frontend/src/app/api/user.ts line 140 at r15 (raw file):

        : []
    }),
    destroyUser: build.mutation<

no BulkDestroyUsers?

---

frontend/src/app/api/teacher/dashboard.ts line 116 at r15 (raw file):

      invalidatesTags: ['teacher']
    }),
    oldUpdateSchool: build.mutation<void, {

Can this be updated / removed?

[faucomte97]

Reviewed 1 of 9 files at r2, 1 of 5 files at r4, 5 of 14 files at r13, 1 of 7 files at r14, 13 of 29 files at r15.
Reviewable status: all files reviewed, 22 unresolved discussions (waiting on @KamilPawel)

---

frontend/src/app/api/teacher/teach.ts line 102 at r15 (raw file):

      query: ({ studentId, password, confirmPassword }) => ({
        url: `teach/student/edit/${studentId}`,
        method: 'POST',

Why is this POST and not PATCH? Same for the update class mutation above.

---

frontend/src/app/api/teacher/teach.ts line 118 at r15 (raw file):

      query: ({ studentId, name }) => ({
        url: `teach/student/edit/${studentId}`,
        method: 'POST',

Same question here

---

frontend/src/app/api/teacher/teach.ts line 132 at r15 (raw file):

      query: ({ accessCode }) => ({
        url: `teach/class/delete/${accessCode}`,
        method: 'POST',

why is this a POST and not a DELETE?

---

frontend/src/app/api/teacher/teach.ts line 145 at r15 (raw file):

      query: (body) => ({
        url: 'teach/move_class/',
        method: 'POST',

Same here - shouldn't this be a PATCH? 😕

---

frontend/src/app/api/teacher/teach.ts line 159 at r15 (raw file):

      query: ({ accessCode, data }) => ({
        url: `teach/onboarding-class/${accessCode}/print-reminder-cards/`,
        method: 'POST',

Post or get?

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 201 at r15 (raw file):

  const schoolPostcode = schoolData.postcode;
  const schoolCountry = schoolData.country;
  const [updateSchool] = useOldUpdateSchoolMutation();

Can we replace / remove this?

---

frontend/src/pages/teacherDashboard/classes/editClass/student/editStudent/StudentCredentials.tsx line 66 at r15 (raw file):

          header='Class and class access code:'
        />
        <Page.Notification>

Does this notification have the right icon like we discussed?

---

frontend/src/pages/teacherOnboarding/TeacherOnboarding.tsx line 103 at r15 (raw file):

              <AddStudentsForm
                key={generateKey(2)}
                // classId={activeStep.classId as number}

please remove if not needed then

[SKairinos]

Reviewable status: 51 of 52 files reviewed, 22 unresolved discussions (waiting on @faucomte97 and @KamilPawel)

[SKairinos]

Reviewable status: 51 of 52 files reviewed, 22 unresolved discussions (waiting on @faucomte97 and @KamilPawel)

---

frontend/src/app/api/klass.ts line 111 at r15 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

why type school? Should be class no?

done

[SKairinos]

Reviewable status: 47 of 52 files reviewed, 22 unresolved discussions (waiting on @faucomte97 and @KamilPawel)

---

backend/portal/urls/teacher/dashboard.py line 95 at r15 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Please double check whether these two endpoints are needed in this file (they don't seem like teacher dashboard features to me)

will address in another task

---

frontend/src/app/api/user.ts line 124 at r15 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

no BulkUpdateUsers?

done

---

frontend/src/app/api/user.ts line 140 at r15 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

no BulkDestroyUsers?

done

[faucomte97]

Reviewed 1 of 3 files at r8, 1 of 1 files at r16, 3 of 4 files at r17, 9 of 9 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

[faucomte97]

Reviewed 1 of 12 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)