fix: altered the padding to match prod

[KamilPawel]

This change is 

[cewei8483]

Please adjust Page.Section paddings based on the latest js package since the issue has been addressed before.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @KamilPawel)

---

frontend/src/components/Introduction.tsx line 28 at r1 (raw file):

        <Grid xs={12} md={6}>
          <Stack sx={{ height: '100%' }}>
            <Typography sx={{ lineHeight: 0.7 }} variant="h5">

Is this about the alignment issue?

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 147 at r1 (raw file):

      <>
        <Button endIcon={<Add />}>Make admin </Button>
        {twoFactorAuthentication ? (

ESlint complaint: Expected newline between test and consequent of ternary expressio multiline-ternary

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 214 at r1 (raw file):

    <>
      <Page.Section
        sx={{

See review discussion

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 217 at r1 (raw file):

          paddingTop: theme.spacing(6),
          paddingBottom: theme.spacing(1),
          border: '1px dashed red'

Coloured borders:question:

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 234 at r1 (raw file):

      <Page.Section
        sx={{
          border: '1px dashed orange',

Same

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 243 at r1 (raw file):

      <Page.Section
        sx={{
          border: '1px dashed lime',

Same

[KamilPawel]

Reviewable status: 1 of 6 files reviewed, 6 unresolved discussions (waiting on @cewei8483)

---

frontend/src/components/Introduction.tsx line 28 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Is this about the alignment issue?

This got caried over from another PR, removed

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 147 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

ESlint complaint: Expected newline between test and consequent of ternary expressio multiline-ternary

Done.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 214 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

See review discussion

I tried to make it as close as possible to the production site. Is the code too cluttered? If so I can remove it :)

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 217 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Coloured borders:question:

Done.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 234 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Same

Done.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 243 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Same

Done.

[cewei8483]

Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @KamilPawel)

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 214 at r1 (raw file):

Previously, KamilPawel wrote…

I tried to make it as close as possible to the production site. Is the code too cluttered? If so I can remove it :)

A little bit for me, but it's fine.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 240 at r4 (raw file):

      <Page.Section
        sx={{
          marginTop: theme.spacing(2),

Just nitpicking - any particular reason to use marginTop here instead of paddingTop like you did to the other two page sections? If not it would be better to use the same attribute.

[KamilPawel]

Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @cewei8483)

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 214 at r1 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

A little bit for me, but it's fine.

ok

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 240 at r4 (raw file):

Previously, cewei8483 (Chi-En Wei) wrote…

Just nitpicking - any particular reason to use marginTop here instead of paddingTop like you did to the other two page sections? If not it would be better to use the same attribute.

for padding I needed a larger number, while margin comes in larger increments

[cewei8483]

Reviewed 1 of 2 files at r2, 3 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

[KamilPawel]

https://development-portal-dot-decent-digit-629.appspot.com/teacher/dashboard/school