feat: teacher views dashboard

[cewei8483]

This change is 

[KamilPawel]

Reviewed 7 of 11 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @cewei8483)

---

backend/portal/views/teacher/dashboard.py line 256 at r2 (raw file):

    form_data = request.POST
    invite_teacher_form = InviteTeacherForm(request.POST)

Why not use the form_data in the InviteTeacherForm 🤔

---

backend/portal/views/teacher/dashboard.py line 294 at r2 (raw file):

    if teacher == user or (teacher.school != user.school or not user.is_admin):
        return False

return True 😂

---

backend/portal/views/teacher/dashboard.py line 505 at r2 (raw file):

    Check student is awaiting decision on request
    """
    if not student.pending_class_request:

I don't know if we should do the same here with only returning either a boolean or a HttpResponse? Feels a bit odd.. since we are just transferring the logic it could be fine I guess

---

frontend/src/app/api/organisation.ts line 33 at r2 (raw file):

    }),
    leaveOrganisation: build.mutation<{
      source?: string;

Is this to check how was the invite sent?

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 122 at r2 (raw file):

const UpdateSchoolDetailsForm: React.FC<{
  schoolData: any;

Can we please define the type 😅

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 314 at r2 (raw file):

}> = ({ isUserAdmin, teachersData, sentInvites }) => {
  // const { email } = getUser();
  const email = 'alberteinstein@codeforlife.com';

Can this not be pulled from the API?

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 400 at r2 (raw file):

const YourSchool: React.FC<{
  data: any;

Here as well

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 413 at r2 (raw file):

        if (res?.classes) {
          navigate(paths.teacher.dashboard.school.leave._, {
            state: {

If we use Stefan's approach with { state: { index: , props: { children: [ ..... we do't need to redifine the page.notification

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 427 at r2 (raw file):

  return <>
    {location.state?.message &&

Then this can be removed

---

frontend/src/pages/teacherDashboard/classes/Classes.tsx line 237 at r2 (raw file):

  const findNewTeacherId = (name: string): number => {
    const t = teacherList.find((t: teacherListType) => (t.fullName === name));
    return t ? (t.id) : -1;

A bit more descriptive name please 😂

---

frontend/src/pages/teacherDashboard/classes/Classes.tsx line 322 at r2 (raw file):

    <>
      <Page.Notification>
        {location.state.source === 'organisationKick'

Can we not reuse the Stefan Notification as well?

[cewei8483]

Reviewable status: 6 of 12 files reviewed, 11 unresolved discussions (waiting on @KamilPawel)

---

backend/portal/views/teacher/dashboard.py line 256 at r2 (raw file):

Previously, KamilPawel wrote…

Why not use the form_data in the InviteTeacherForm 🤔

Done.

---

backend/portal/views/teacher/dashboard.py line 294 at r2 (raw file):

Previously, KamilPawel wrote…

return True 😂

Done.

---

backend/portal/views/teacher/dashboard.py line 505 at r2 (raw file):

Previously, KamilPawel wrote…

I don't know if we should do the same here with only returning either a boolean or a HttpResponse? Feels a bit odd.. since we are just transferring the logic it could be fine I guess

This function is not used in this task, so I left it as it is.

---

frontend/src/app/api/organisation.ts line 33 at r2 (raw file):

Previously, KamilPawel wrote…

Is this to check how was the invite sent?

The endpoint will be called by two functions, organisationKick and leaveOrganisation. This variable is to distinguish them.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 122 at r2 (raw file):

Previously, KamilPawel wrote…

Can we please define the type 😅

Done.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 314 at r2 (raw file):

Previously, KamilPawel wrote…

Can this not be pulled from the API?

Done.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 400 at r2 (raw file):

Previously, KamilPawel wrote…

Here as well

Done.

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 413 at r2 (raw file):

Previously, KamilPawel wrote…

If we use Stefan's approach with { state: { index: , props: { children: [ ..... we do't need to redifine the page.notification

As you said, the notification will then appear above the page banner

---

frontend/src/pages/teacherDashboard/YourSchool.tsx line 427 at r2 (raw file):

Previously, KamilPawel wrote…

Then this can be removed

Explained above

---

frontend/src/pages/teacherDashboard/classes/Classes.tsx line 237 at r2 (raw file):

Previously, KamilPawel wrote…

A bit more descriptive name please 😂

Done.

---

frontend/src/pages/teacherDashboard/classes/Classes.tsx line 322 at r2 (raw file):

Previously, KamilPawel wrote…

Can we not reuse the Stefan Notification as well?

Same reason above

[KamilPawel]

Reviewed 3 of 6 files at r3, 4 of 4 files at r4, 6 of 6 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @cewei8483)

---

frontend/src/app/api/teacher/dashboard.ts line 76 at r6 (raw file):

      providesTags: ['teacher']
    }),
    inviteTeacher: build.mutation<any, {

if the function doesn't need the attribute replace any with null, else define the type

[cewei8483]

Reviewable status: 9 of 12 files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

---

frontend/src/app/api/teacher/dashboard.ts line 76 at r6 (raw file):

Previously, KamilPawel wrote…

if the function doesn't need the attribute replace any with null, else define the type

Done.

[KamilPawel]

Reviewed 3 of 3 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cewei8483)