Merge current main #1783
Merged
Merge current main #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[GEN-1340] chore: connect form validation
[GEN-1359] chore: merge upstream
[GEN-1341] chore: delete old setup files
[GEN-1136] chore: overview header
[GEN-1361] feat: get destination - gql
[GEN-1400] feat: get actual sources
[GEN-1402] chore: get actual actions
[GEN-1043] chore: insert destinations and action to cp and create resolvers
[GEN-1405] chore: change api to new schema and delete unused files
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
…s-io#1741) Define a minimum k8s version for odigos being installed. This is defined both in helm and the CLI. Currently, the minimum version is 1.23.0, but we might change that in the future.
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
This PR is a general housekeeping, removing some auto-generated comments with trivial or non-up-to-date info, that does not give any value to our code base.
…-io#1757) This PR: - shifts to use the common predicates in `k8sutils` over writing them specifically in the controllers. - splits logic into smaller parts and combine them with `predicate.And` for better readability. - adds few straight forward predicates to places where they are currently missing
…ler for instrumentation (odigos-io#1754) Following odigos-io#1666, this PR includes the following: 1. Change the predicate for ebpf instrumentation to only pass events where all the containers in a pod become ready. This will fix cases where the reconciliation was called too early and missed the relevant process. 2. Create an `AllContainersReadyPredicate` which is common to the runtime details reconciler (the predicate was added in odigos-io#1666 ) and the ebpf instrumentation reconciler. 3. Create a common `DeletionPredicate` predicate - for the instrumentation reconcilation it is an OR between the containers ready predicate and the delete one.
Co-authored-by: David <david@odigos.io>
…luster details once for all commands (odigos-io#1759) Add `PersistentPreRun` which will be inherited by all sub-commands of the root command. Perform a client initialzation in that function and set the cluster kind and k8s version as well - so they can be used by all commands. Both the kube client and the cluster details are set on the command context and can be used by all the commands. The helper function from k8sutils `GetKubernetesVersion` can't be used outside of the cluster by the CLI since it as using a rest client which states: > // InClusterConfig returns a config object which uses the service account // kubernetes gives to pods. It's intended for clients that expect to be // running inside a pod running on kubernetes. It will return ErrNotInCluster // if called from a process not running in a kubernetes environment. func InClusterConfig() (*Config, error) { Hence, removing the use of this function from the CLI, and using the k8s version which was calculated in the `PersistentPreRun` function. Before this change `odigos upgrade` resulted in errors such as: > Syncing customresourcedefinitionsDeleteOldOdigosSystemObjects failed to get k8s version, proceeding.. :unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined ✔ Syncing deploymentsDeleteOldOdigosSystemObjects failed to get k8s version, proceeding.. :unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined ✔ Syncing daemonsetsDeleteOldOdigosSystemObjects failed to get k8s version, proceeding.. :unable to load in-cluster
Simplified the `SetInjectInstrumentationLabel` function by removing the `odigosTier` variable and the conditional check for the community tier, ensuring that the instrumentation label is always injected.
…ok (odigos-io#1738) This is a special exception, used to temporarly filter out a specific value that is known to be managed by a webhook. For this case, we only want to populate the odigos value --------- Co-authored-by: Eden Federman <eden@keyval.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.