Add documentation that exists on the Wiki page also in the doc folder #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheo89
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
Sep 22, 2023
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
Sep 27, 2023
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
Sep 29, 2023
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Add the documentation that is on the Wiki page also in the doc folder (#179) * Add documentation for recommended accelerators annotation (#177) * Add test cases for the pytorch notebooks * Add test notebook suite for tensorflow notebook Add test cases for the tensorflow notebook * docs(readme): fix typo in image names * updates to makefile and readme, plus fixed wrong python version * Fix UBI version used on particular places with regards the Pyton version * Use RHEL9 repository for UBI9 and CentOs Stream 9 Cuda images * Add tests for minimal notebooks Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com> * Add tests for datascience notebooks Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com> * updates to makefile and readme * upgrade trustyai notebook images to version 0.3.0 (#209) * Add test case to convert a pytorch model to onnx format (#213) * Fix of UBI and Python version used for Jupyter TrustyAI image (#224) This is a similar fix as the #199 was. Was brought in via #164 that was merged later. * Set correctly for redirects on vscode and rstudio nginx (#226) * adding elyra to imagestream (#222) --------- Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com> Co-authored-by: aTheo <atheodor@redhat.com> Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com> Co-authored-by: atheo89 <atheodorak@outlook.com> Co-authored-by: Tommaso Teofili <tteofili@redhat.com> Co-authored-by: Jan Stourac <jstourac@redhat.com> Co-authored-by: Diamond Bryant <135062655+dibryant@users.noreply.github.com>
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
May 31, 2024
…mMain [fix] hadolint warnings to base and rstudio Dockerfiles
harshad16
added a commit
to harshad16/odh-notebooks
that referenced
this pull request
Jun 28, 2024
…o-release-2024a [release-2024a] Cherry pick opendatahub-io#179, opendatahub-io#253 and opendatahub-io#254 to release-2024a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the documentation that is on the Wiki page also in the doc folder.
Description
Since all of the rest repos keep the documentation in a particular folder on the repo we want to do the same.
Related to:
Documentation about the Workbenches and Architecture of the repo. #160
Documentation about the getting started and contribution guideline for notebooks repo. #161
Documentation on Selecting the workbench images from the dashboard. #162
The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work