Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of UBI and Python version used for Jupyter TrustyAI image #224

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix of UBI and Python version used for Jupyter TrustyAI image #224

merged 1 commit into from
Sep 25, 2023

Conversation

jstourac
Copy link
Member

This is a similar fix as the #199 was. Was brought in via #164 that was merged later.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac
Fix of UBI and Python version used for Jupyter TrustyAI image
82b0370 
This is a similar fix as the opendatahub-io#199 was. Was brought in via opendatahub-io#164 that was
merged later.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

Hi @jstourac. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harshad16
harshad16 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

/ok-to-test

@harshad16
Copy link
Member

/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit c507e77 into opendatahub-io:main Sep 25, 2023
@jstourac jstourac deleted the fixUbiVersion branch September 26, 2023 12:35
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 28, 2023
@jstourac @harshad16
Fix of UBI and Python version used for Jupyter TrustyAI image (openda…
fdf072d 
…tahub-io#224)

This is a similar fix as the opendatahub-io#199 was. Was brought in via opendatahub-io#164 that was
merged later.
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 29, 2023
@jstourac @harshad16
Fix of UBI and Python version used for Jupyter TrustyAI image (openda…
f0b927c 
…tahub-io#224)

This is a similar fix as the opendatahub-io#199 was. Was brought in via opendatahub-io#164 that was
merged later.
openshift-merge-robot pushed a commit that referenced this pull request Sep 29, 2023
@harshad16 @ide-developer
@rkpattnaik780 @atheo89 @tteofili @jstourac @dibryant
Update the 2023a branch with the commit from main. (#221)
03193f1 
* Add the documentation that is on the Wiki page also in the doc folder (#179)

* Add documentation for recommended accelerators annotation (#177)

* Add test cases for the pytorch notebooks

* Add test notebook suite for tensorflow notebook

Add test cases for the tensorflow notebook

* docs(readme): fix typo in image names

* updates to makefile and readme, plus fixed wrong python version

* Fix UBI version used on particular places with regards the Pyton version

* Use RHEL9 repository for UBI9 and CentOs Stream 9 Cuda images

* Add tests for minimal notebooks

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>

* Add tests for datascience notebooks

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>

* updates to makefile and readme

* upgrade trustyai notebook images to version 0.3.0 (#209)

* Add test case to convert a pytorch model to onnx format (#213)

* Fix of UBI and Python version used for Jupyter TrustyAI image (#224)

This is a similar fix as the #199 was. Was brought in via #164 that was
merged later.

* Set  correctly for redirects on vscode and rstudio nginx (#226)

* adding elyra to imagestream (#222)

---------

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
Co-authored-by: aTheo <atheodor@redhat.com>
Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com>
Co-authored-by: atheo89 <atheodorak@outlook.com>
Co-authored-by: Tommaso Teofili <tteofili@redhat.com>
Co-authored-by: Jan Stourac <jstourac@redhat.com>
Co-authored-by: Diamond Bryant <135062655+dibryant@users.noreply.github.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/notebooks that referenced this pull request Apr 15, 2024
@harshad16
Merge pull request opendatahub-io#224 from red-hat-data-services/dige…
d31ce6d 
…st-updater-8663654195

[Digest Updater Action] Update Runtime Images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@dibryant dibryant Awaiting requested review from dibryant

Assignees

@harshad16 harshad16

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstourac @harshad16 @openshift-merge-robot