Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding elyra to imagestream #222

Merged
merged 1 commit into from
Sep 29, 2023
Merged

adding elyra to imagestream #222

merged 1 commit into from
Sep 29, 2023

Conversation

dibryant
Copy link
Contributor

fixes: #207

Description

I have added the elyra package opendatahub.io/notebook-python-dependencies annotation of imagestream.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

harshad16
harshad16 requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good
just one change required, we don't need to update the n-1, as we wont be updating the images of the n-1.

manifests/base/jupyter-datascience-notebook-imagestream.yaml Outdated Show resolved Hide resolved
@opendatahub-io opendatahub-io deleted a comment from openshift-ci bot Sep 26, 2023
@atheo89
Copy link
Member

atheo89 commented Sep 26, 2023

/test all

@harshad16
Copy link
Member

/retest-required

harshad16
harshad16 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Sep 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Sep 29, 2023

/test images
/override ci/prow/notebooks-e2e-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/test images
/override ci/prow/notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023 •
edited
Loading

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror 3cb8b4e link true /test notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror 3cb8b4e link true /test notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror
ci/prow/notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror 3cb8b4e link true /test notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror
ci/prow/habana-notebooks-e2e-tests 3cb8b4e link true /test habana-notebooks-e2e-tests
ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror 3cb8b4e link true /test jupyter-datascience-anaconda-python-3-8-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harshad16
Copy link
Member

/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 13430f2 into opendatahub-io:main Sep 29, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 29, 2023
@dibryant @harshad16
adding elyra to imagestream (opendatahub-io#222)
e868e30
openshift-merge-robot pushed a commit that referenced this pull request Sep 29, 2023
@harshad16 @ide-developer
@rkpattnaik780 @atheo89 @tteofili @jstourac @dibryant
Update the 2023a branch with the commit from main. (#221)
03193f1 
* Add the documentation that is on the Wiki page also in the doc folder (#179)

* Add documentation for recommended accelerators annotation (#177)

* Add test cases for the pytorch notebooks

* Add test notebook suite for tensorflow notebook

Add test cases for the tensorflow notebook

* docs(readme): fix typo in image names

* updates to makefile and readme, plus fixed wrong python version

* Fix UBI version used on particular places with regards the Pyton version

* Use RHEL9 repository for UBI9 and CentOs Stream 9 Cuda images

* Add tests for minimal notebooks

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>

* Add tests for datascience notebooks

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>

* updates to makefile and readme

* upgrade trustyai notebook images to version 0.3.0 (#209)

* Add test case to convert a pytorch model to onnx format (#213)

* Fix of UBI and Python version used for Jupyter TrustyAI image (#224)

This is a similar fix as the #199 was. Was brought in via #164 that was
merged later.

* Set  correctly for redirects on vscode and rstudio nginx (#226)

* adding elyra to imagestream (#222)

---------

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
Co-authored-by: aTheo <atheodor@redhat.com>
Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com>
Co-authored-by: atheo89 <atheodorak@outlook.com>
Co-authored-by: Tommaso Teofili <tteofili@redhat.com>
Co-authored-by: Jan Stourac <jstourac@redhat.com>
Co-authored-by: Diamond Bryant <135062655+dibryant@users.noreply.github.com>
@dibryant dibryant deleted the elyra branch October 4, 2023 16:25
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/notebooks that referenced this pull request Apr 15, 2024
@harshad16
Merge pull request opendatahub-io#222 from harshad16/update-manifests…
160dc13 
…-2024a

Update manifest for code-freeze 2.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@atheo89 atheo89 Awaiting requested review from atheo89

@rkpattnaik780 rkpattnaik780 Awaiting requested review from rkpattnaik780

Assignees

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List Elyra in the imagestream annotation
4 participants
@dibryant @atheo89 @harshad16 @openshift-merge-robot