Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case on the PyTorch notebook to convert a pytorch model to onnx format #213

Merged

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 15, 2023

Add test case on the PyTorch notebook to convert a pytorch model to onnx format

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@harshad16
Copy link
Member

/lgtm
/approve

thanks 💯

/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror
/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror, ci/prow/notebooks-e2e-tests

In response to this:

/lgtm
/approve

thanks 💯

/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror
/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror
/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror, ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror
/override ci/prow/notebooks-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 47e9a1c into opendatahub-io:main Sep 22, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 22, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 29, 2023
openshift-merge-robot pushed a commit that referenced this pull request Sep 29, 2023
* Add the documentation that is on the Wiki page also in the doc folder (#179)

* Add documentation for recommended accelerators annotation (#177)

* Add test cases for the pytorch notebooks

* Add test notebook suite for tensorflow notebook

Add test cases for the tensorflow notebook

* docs(readme): fix typo in image names

* updates to makefile and readme, plus fixed wrong python version

* Fix UBI version used on particular places with regards the Pyton version

* Use RHEL9 repository for UBI9 and CentOs Stream 9 Cuda images

* Add tests for minimal notebooks

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>

* Add tests for datascience notebooks

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>

* updates to makefile and readme

* upgrade trustyai notebook images to version 0.3.0 (#209)

* Add test case to convert a pytorch model to onnx format (#213)

* Fix of UBI and Python version used for Jupyter TrustyAI image (#224)

This is a similar fix as the #199 was. Was brought in via #164 that was
merged later.

* Set  correctly for redirects on vscode and rstudio nginx (#226)

* adding elyra to imagestream (#222)

---------

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
Co-authored-by: aTheo <atheodor@redhat.com>
Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com>
Co-authored-by: atheo89 <atheodorak@outlook.com>
Co-authored-by: Tommaso Teofili <tteofili@redhat.com>
Co-authored-by: Jan Stourac <jstourac@redhat.com>
Co-authored-by: Diamond Bryant <135062655+dibryant@users.noreply.github.com>
atheo89 pushed a commit to atheo89/notebooks that referenced this pull request Apr 11, 2024
…st-updater-8581586298

[Digest Updater Action] Update Notebook Images
@atheo89 atheo89 deleted the add-onnx-test-case branch October 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants