Skip to content

Transcripts phase 2 #17718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mushtaqak merged 27 commits into from
May 7, 2018
Merged

Transcripts phase 2 #17718

mushtaqak merged 27 commits into from
May 7, 2018

Conversation

@muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Mar 19, 2018

@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

8 similar comments
@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 20, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 20, 2018

Your PR has finished running tests.

@Qubad786 Qubad786 force-pushed the transcripts-phase-2 branch from 11a943b to d4a2db4 Compare March 20, 2018 18:54
@edx-status-bot
Copy link

edx-status-bot commented Mar 20, 2018

Your PR has finished running tests.

@Qubad786 Qubad786 mentioned this pull request Mar 20, 2018
Merged
@edx-status-bot
Copy link

edx-status-bot commented Mar 21, 2018

Your PR has finished running tests.

2 similar comments
@edx-status-bot
Copy link

edx-status-bot commented Mar 23, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Mar 26, 2018

Your PR has finished running tests.

@Qubad786
Copy link
Contributor

Qubad786 commented Mar 26, 2018

jenkins run python

@edx-status-bot
Copy link

edx-status-bot commented Mar 27, 2018

Your PR has finished running tests.

1 similar comment
@edx-status-bot
Copy link

edx-status-bot commented Mar 28, 2018

Your PR has finished running tests.

@muhammad-ammar muhammad-ammar mentioned this pull request Apr 4, 2018
Closed
@edx-status-bot
Copy link

edx-status-bot commented Apr 11, 2018

Your PR has finished running tests.

1 similar comment
@edx-status-bot
Copy link

edx-status-bot commented Apr 17, 2018

Your PR has finished running tests.

@irfanuddinahmad
Copy link
Contributor

irfanuddinahmad commented Apr 17, 2018

jenkins run all

@edx-status-bot
Copy link

edx-status-bot commented Apr 17, 2018

Your PR has finished running tests.

1 similar comment
@edx-status-bot
Copy link

edx-status-bot commented Apr 17, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 18, 2018

Your PR has finished running tests.

Merge pull request #17976 from edx/mushtaq/html5_sources_transcript
1ba833f 
Update the get_transcript util with html5_sources
@edx-status-bot
Copy link

edx-status-bot commented Apr 25, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 26, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented Apr 30, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented May 3, 2018

Your PR has finished running tests.

@edx-status-bot
Copy link

edx-status-bot commented May 4, 2018

Your PR has finished running tests.

@muhammad-ammar muhammad-ammar changed the title [WIP] Transcripts phase 2 Transcripts phase 2 May 7, 2018
mushtaqak
mushtaqak approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@mushtaqak mushtaqak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to merge 👍

@muhammad-ammar
Copy link
Contributor Author

muhammad-ammar commented May 7, 2018

👍
ship it 🚀 🎆

@irfanuddinahmad
Copy link
Contributor

irfanuddinahmad commented May 7, 2018

Good to go!

@mushtaqak mushtaqak merged commit f4b1da1 into master May 7, 2018
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented May 7, 2018

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, May 08, 2018.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented May 8, 2018

EdX Release Notice: This PR has been deployed to the production environment.

@UmanShahzad UmanShahzad deleted the transcripts-phase-2 branch May 9, 2018 20:42
@farhan farhan mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irfanuddinahmad irfanuddinahmad irfanuddinahmad approved these changes

@Qubad786 Qubad786 Awaiting requested review from Qubad786

+1 more reviewer

@mushtaqak mushtaqak mushtaqak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@muhammad-ammar muhammad-ammar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@muhammad-ammar @edx-status-bot @Qubad786 @irfanuddinahmad @edx-pipeline-bot @mushtaqak