MySensors binding added #1243

tobof · 2016-09-19T12:08:38Z

New binding that adds support for the MySensors protocol / network.

https://www.mysensors.org

Discussion about the binding development can be found here: https://forum.mysensors.org/topic/1598/openhab-2-0-binding

kubawolanin · 2016-12-14T13:41:23Z

Quick question - would this binding work with ESP8266 Gateway? I'm pretty newbie in MySensors and would like to play around with your binding 🙂
Thanks!

tobof · 2016-12-22T12:51:41Z

@kubawolanin Yes it works with the Gateway you mentioned. Just use the "ethernet gateway" configuration described in the wiki.

fab33 · 2016-12-27T08:40:53Z

@kaikreuzer can you merge this branch with openhab2-addon ?

kaikreuzer · 2016-12-27T08:49:19Z

@tobof There seems to be still development going on on that branch. I'll definitely wait until it is squashed to a single commit and the code respects all the guidelines. Meanwhile, I have plenty of other bindings in the queue to review...

kaikreuzer · 2016-12-27T16:08:58Z

Meanwhile, I have plenty of other bindings in the queue to review...

Actually, I have just catched up and this one would be the next to be reviewed :-)

So @tobof, please be so kind to check your code against the guidelines and ping me when you think it is good to go - thanks!

hakan42

Could you please rename the readme file to README.md to be in sync with all other addons

openhab/openhab-docs#169

hakan42 · 2017-01-05T10:28:49Z

addons/binding/org.openhab.binding.mysensors/pom.xml

+
+  <groupId>org.openhab.binding</groupId>
+  <artifactId>org.openhab.binding.mysensors</artifactId>
+  <version>2.0.0-SNAPSHOT</version>


Please remove groupId and version from the pom, that way it will be inherited from the parent.

hakan42 · 2017-01-05T10:29:55Z

...nsors/src/main/java/org/openhab/binding/mysensors/internal/exception/NoMoreIdsException.java

+package org.openhab.binding.mysensors.internal.exception;
+
+/**
+ * Exception occures if no more ids are available.


Typo - "occurs" :)

hakan42 · 2017-01-05T10:31:17Z

...ors/src/main/java/org/openhab/binding/mysensors/internal/handler/MySensorsBridgeHandler.java

+    }
+
+    @Override
+    public void handleCommand(ChannelUID channelUID, Command command) {


please remove empty handleCommand() if not necessary.

The abstract method handleCommand() needs to be implemented. That's what eclipse tells me. :)

hakan42 · 2017-01-05T10:32:34Z

...sors/src/main/java/org/openhab/binding/mysensors/internal/handler/MySensorsThingHandler.java

+    }
+
+    @Override
+    public void handleUpdate(ChannelUID channelUID, org.eclipse.smarthome.core.types.State newState) {


please remove empty handleUpdate() if not necessary.

hakan42 · 2017-01-05T10:33:18Z

...sors/src/main/java/org/openhab/binding/mysensors/internal/handler/MySensorsThingHandler.java

+     */
+    private void handleIncomingMessageEvent(MySensorsMessage msg) {
+        // Am I the all knowing node that receives all messages?
+        if (nodeId == 999 && childId == 999) {


Could you please create constants for those "all knowing node and child ids" ?

hakan42 · 2017-01-05T10:35:25Z

.../src/main/java/org/openhab/binding/mysensors/internal/protocol/message/MySensorsMessage.java

+     * Write message to DEBUG.
+     */
+    public void printDebug() {
+        logger.debug(String.format("nodeId: %d, childId: %d, msgType: %d, ack: %d, revert: %b, subType: %d ,msg: %s",


could this be replaced by logger.debug(getDebugInfo())? the two strings look very similiar.

hakan42 · 2017-01-05T10:35:59Z

.../src/main/java/org/openhab/binding/mysensors/internal/protocol/message/MySensorsMessage.java

+    public boolean isIConfigMessage() {
+        boolean ret = false;
+
+        if (childId == 0 || childId == 255) {


Please create constants for magic childIds (in this case 255?)

hakan42 · 2017-01-05T10:37:10Z

...n/java/org/openhab/binding/mysensors/internal/protocol/serial/MySensorsSerialConnection.java

+        try {
+            String[] namePart = devName.split("/");
+            File lockFile = new File("/var/lock/LCK.." + namePart[namePart.length - 1]);
+            if (lockFile.exists()) {


The path /var/lock/... only exists on Unix, right? Does this serial interface library work on Windows or MacOS?

hakan42 · 2017-01-05T10:38:31Z

addons/binding/pom.xml

@@ -65,6 +65,7 @@
    <module>org.openhab.binding.toon</module>
    <module>org.openhab.binding.urtsi</module>
    <module>org.openhab.binding.vitotronic</module>
+    <module>org.openhab.binding.mysensors</module>


Please keep list of bindings in pom alphabetically sorted.

hakan42 · 2017-01-05T10:38:57Z

addons/binding/pom.xml~

@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please remove accidentally committed backup file

tobof · 2017-01-05T12:26:18Z

Thank you for your suggestions @hakan42 !
I've made some changes and I'm open to new suggestions! :)

fab33 · 2017-01-05T13:05:18Z

Thanks a lot !

kaikreuzer · 2017-01-13T13:12:46Z

@tobof Once you are done and feel like it is ready to be reviewed/merged, please make sure to squash your commits first - 184 is an awful number of commits 😲

ThomDietrich · 2017-01-13T13:20:36Z

Out of interest: Why are many commits not better for the review? I feel like they would help understand the result and a squash should be done only right before the merge. But maybe that's just my thinking, not being involved in the review process and all... 😃

kaikreuzer · 2017-01-13T13:30:04Z

If "many" would mean 10, this could be better, yes.
But having 184, many of which are not signed-off, others being merge commits, is simply not helpful.

tobof · 2017-01-13T13:38:44Z

@kaikreuzer I'm done preparing, but I need some help to squash / rebase. I've read a few tutorials and tried it with the local repository. My main problem: If I start a rebase and start here: f69bf36 (first commit). The list ist about 700 commits long (only a few from me). Most tutorials state: "Don't do a rebase on a remote repository!" Could you please give me a hint?

hakan42

Please see a few in-line comments I added to your code.

hakan42 · 2017-01-13T13:26:46Z

addons/binding/org.openhab.binding.mysensors/META-INF/MANIFEST.MF

+Import-Package: 
+ com.google.common.base,
+ com.google.common.collect,
+ com.google.gson;version="2.2.4",


Do you need that specific version of gson? If not, please remove version constraint.

hakan42 · 2017-01-13T13:28:13Z

addons/binding/org.openhab.binding.mysensors/.gitignore

@@ -0,0 +1 @@
+/*.cached


Does something in your project create the *.cached files / directories? If not, please remove project specific gitignore file

hakan42 · 2017-01-13T13:29:24Z

addons/binding/org.openhab.binding.mysensors/ESH-INF/thing/thing-types.xml

+			<parameter name="baudRate" type="integer" required="false" min="300" max="250000">
+				<label>Baudrate</label>
+				<description>Baudrate for serial port
+                </description>


Once remarked for this, file, happens many times: Please use tabs instead of spaces for indenting.

hakan42 · 2017-01-13T13:32:39Z

...binding.mysensors/src/main/java/org/openhab/binding/mysensors/MySensorsBindingConstants.java

+     * Mapping MySensors subtypes to channels.
+     */
+    public final static Map<Number, String> CHANNEL_MAP = new HashMap<Number, String>() {
+        /**


Remove empty Javadoc please

hakan42 · 2017-01-13T13:34:58Z

...sors/src/main/java/org/openhab/binding/mysensors/internal/factory/MySensorsCacheFactory.java

+
+    private static MySensorsCacheFactory singleton = null;
+
+    private static final String CACHE_BASE_PATH = "./mysensors/cache";


Where would this cache be written in a production environment? I believe it should belong into userdata, but not into the current working directory of the process. To which you might even not have write access....

It is written to userdata. In my production environment it is written to: /var/lib/openhab2/mysensors/cache/given_ids.cached

hakan42 · 2017-01-13T13:40:01Z

...mysensors/src/main/java/org/openhab/binding/mysensors/internal/protocol/MySensorsWriter.java

+                                            + MySensorsBindingConstants.MYSENSORS_RETRY_TIMES[msg.getRetries() - 1]);
+                                    mysCon.addMySensorsOutboundMessage(msg);
+                                } else {
+                                    logger.warn("NO ACK from nodeId: " + msg.getNodeId());


Please use parametrized logging instead of string concatenation.

hakan42 · 2017-01-13T13:40:27Z

.../src/main/java/org/openhab/binding/mysensors/internal/protocol/ip/MySensorsIpConnection.java

+
+                ret = startReaderWriterThread(mysConReader, mysConWriter);
+            } catch (UnknownHostException e) {
+                logger.error("Error while trying to connect to: " + ipAddress + ":" + tcpPort);


Please use parametrized logging instead of string concatenation.

hakan42 · 2017-01-13T13:41:08Z

...sors/src/main/java/org/openhab/binding/mysensors/internal/protocol/ip/MySensorsIpWriter.java

+            outs = new PrintWriter(outStream);
+        } catch (IOException e) {
+            // TODO Auto-generated catch block
+            e.printStackTrace();


Please use slf4j instead of e.printStackTrace() 😈

hakan42 · 2017-01-13T13:42:39Z

...ors/src/main/java/org/openhab/binding/mysensors/internal/sensors/MySensorsDeviceManager.java

+    @SuppressWarnings("unused")
+    private void checkChildFound(MySensorsMessage msg) {
+        synchronized (nodeMap) {
+            if (msg.childId != 255 && !nodeMap.containsKey(msg.childId)) {


Magic Child ID 255. I believe we have constants for that?

hakan42 · 2017-01-13T13:43:07Z

...ors/src/main/java/org/openhab/binding/mysensors/internal/sensors/MySensorsDeviceManager.java

+        int newId = 0;
+        try {
+            newId = reserveId();
+            MySensorsMessage newMsg = new MySensorsMessage(255, 255, 3, 0, false, 4, newId + "");


More magic numbers, please replace with constants where appropiate.

hakan42 · 2017-01-13T13:48:05Z

@tobof , actually, you could create a new clone on your computer, then locally delete your branch ("git branch -D your-name), check out master again, create a new branch with the same name ("git checkout -b your-name"), add all your files from your backup directory, then do one big commit and the force-push that branch.

That way, this PR will automatically have only the one commit. I prefer this way when master and my base have diverged too much.

tobof · 2017-01-13T15:13:57Z

@hakan42 Thank you for the suggestion! Currently the PR is from my master branch. If I delete my master branch (is that even possible?) are you sure this will preserve the PR.

The ideal solution in my opinion is:

MySensors branch with all commits
--> squashed in my master branch to one commit
--> PR to the official openhab2-addons master branch.

This way I would preserve the original history and all contributors in the MySensors branch and there's only one commit in the PR to openhab2-addons. But how to achieve that AND preserve this PR? :)

hakan42 · 2017-01-13T15:24:16Z

As far as I understand, you would develop in your own master branch of your own repo as you want (perfectly o.k.), and then create a seperate branch only for the PR. Effectively, you are "exporting" your complete changeset as one huge commit.

I believe preserving this PR will be a little bit hard. you could rename your master to "real-master" (see for example https://gist.github.com/lttlrck/9628955 ), create a new "master", add everything from "real-master" in one commit, and force-push that.

As soon as this PR is merged, you could rename your "real-master" back to master and return to normal development.

A bit dangerous, all that branch hacking. Better keep good backups of your repositories before trying any of that stupid stuff I mentioned 😄

ThomDietrich · 2017-01-13T15:37:26Z

As far as I understand, you would develop in your own master branch

That's actually something you should never do. Always develop in a feature branch.

Anyways. @tobof you have two options: You can squash all your commits or simply re-commit everything. Whatever you do, you can check the results before pushing, so nothing should go wrong. To be safe create a copy of your local project. If anything happens you can restore from there.

Edit: @tobof If I got you right, you want to additionally have one branch in your fork with all commits preserved. In this case do the following:

Create a new feature branch at your current master head
Reset your master branch to the parent commit of your first commit
Squash merge your feature branch into master
Double check the result
Force push -> Good luck!

This takes into account, that this PR is already looking at the master branch. As I said before, you'd normally not do that ;) I hope the instructions are helpful

Actually everyone should have a look at this project: http://i.got.nothing.to/code/on/git-repo:_the_utility_for_services ;) Takes away all the pain

hakan42 · 2017-01-13T15:52:01Z

@ThomDietrich you are right with "never develop in master", I was just trying to come up with an idea to rescue this PR 😄

That said, if one of my team members at $WORKPLACE would have dared to develop in master.... I am the bastard operator who takes away push privileges 😈

kubawolanin · 2017-01-13T16:48:10Z

@tobof for the future try this solution. I found it when I was in similar situation while ago :)

git remote add upstream https://github.com/openhab/openhab2-addons.git
git checkout -b feature/yourfeature upstream/master
// develop develop develop, code code code ...
git commit -a -s -m "Terminator T-800 Binding initial commit"
git push origin feature/yourfeature

Now if you list your remote repositories (git remote -v) you'll see that origin is equal to your github fork.
It worked for me, hope it'll help you too! :)

tobof · 2017-01-14T22:27:12Z

Ok, so I've reduced the number of commits to one, thank you for all the suggestions. I've tried @ThomDietrich suggestions, but that didn't work out, because I squashed all upstream commits into my commit. I suppose I've done something wrong. After that I got along with @hakan42 suggestion.

@hakan42 : I've implemented all your request for changes!

tobof · 2017-01-30T15:30:55Z

@kaikreuzer Pls remove awaiting feedback flag, I'm done. Thank you! :-)

kaikreuzer · 2017-01-30T15:44:55Z

Thanks for the ping.
The code will need some further review, though.
While waiting, you might want to check it yourself against the coding guidelines, at a first glance I saw problems with A.2 (old headers), B.4 and B.5. Please also be so kind to update the version to 2.1.0 already - thanks!

tobof · 2017-02-01T13:22:45Z

@kaikreuzer Thank you for the hint! I've corrected A.2, B.4 and B.5.

According other guidelines: D.2 may be a problem, because threads are used within the binding.

mcinnes01 · 2017-02-25T11:19:40Z

Hi just wondered if there is any update on this pull request and idea when it will be released?

hakan42 · 2017-03-21T13:07:09Z

@tobof , do you want to abandon this binding or continue development in a new PR? Would be a shame if you abandoned it, you seem to have lots of users on the mysensors.org forums 😄

tobof · 2017-03-21T13:32:22Z

@hakan42 We've done a major refactoring of the binding (credits go to @andreacioni) and I'm cleaning up my fork atm.
I'll open a new PR after checking the code against the coding guidelines again and after I'm finished struggling with the static code analysis tool. :)

… handler is missing (openhab#1243) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

@Confectrician

* Update README (2.5.x) (openhab#1153) Change branch name. Signed-off-by: Yannick Schaus <github@schaus.net> * Update items.md (openhab#1156) * Added var and VA units to UoM (openhab#1146) VA (Volt-Ampere - apparent power) and var (Volt-Ampere reactive) are used to measure power and energy consumption in AC circuits. Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> * Fix filepath to keystore (openhab#1148) Default openHAB userdata environment variable should be `$OPENHAB_USERDATA`, not `$USER_DATA` shouldn't it? At least, this is the default on my fresh openHABian and also the most popular variant to find in the docs. * Slight language corrections (openhab#1150) I think it reads better this way Signed-off-by: Richard Davies <rwdrich@gmail.com> * additional example for non default persistence service (openhab#1152) For me it was confusing how to pass on the serviceId into methods that already had an argument. An extra example is always good. Signed-off-by: jaco <jaco.waes@gmail.com> * Adding 12 new logos for OH Add-Ons page on website (openhab#1158) Signed-off-by: bracklanna bracklanna@users.noreply.github.com * Added missing preset variables (openhab#1104) * Added missing preset variables Signed-off-by: Scott Rushworth <openhab@5iver.com> * Cleaned up blank lines, fixed table, and added file name for SimpleRule Signed-off-by: Scott Rushworth <openhab@5iver.com> * Fix broken link (openhab#1165) * Added Hotlink from "label" section to "state presentation" (openhab#1167) * Added note about broken action (openhab#1164) * Added note about broken action See openhab/openhab-core#1374 Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Update index.md (openhab#1170) Link appears to be wrong and does not work when I click on it in Edge. Loads the same page again instead of loading the correct new page from the hyperlink. https://www.openhab.org/docs/developer/guidelines.html * Added Airthings logo (openhab#1171) * typo in exambp (openhab#1172) `Temperature.averageSince(now.minusMinutes(5),"influxdb")` * file.encoding=UTF-8 (openhab#1173) * Update demo URL and add demo.rules URL (openhab#1174) Based on: https://community.openhab.org/t/demo-setup-missing/94850 Old Link is broken leading to 404. The link to the demo.rules on github is an extra :) * Replace outdated zulu.org link. (openhab#1177) * Replace outdated zulu.org link. As of 3/23/2020 zulu.org has an SSL cert that expired on 9/28/2019. Changed link to azul.com/downloads, since that appears to be the new official source. Signed-off-by: Billy Stevens <contact@wasv.me> * Changed all http links to https for installation/index.md. All changed links working, tested on 3/24/2020. Signed-off-by: Billy Stevens <contact@wasv.me> * Minor language tweak (openhab#1178) * Ending an active scan/stopScan (openhab#1179) Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Add files via upload (openhab#1184) * Update persistence.md (openhab#1185) Clarify return objects for max/min rules extensions. Signed-off-by: Ross Kennedy rossko@culzean.clara.co.uk * Update things.md (openhab#1186) Amended example code to include using label and location when defining a Thing with a bridge that is defined elsewhere. * Correct typos (openhab#1190) * Correct usage of its/it's "It's" is always a contraction of "it is" or "it has". "Its" is a possessive. Correct a few places where they were used backwards. Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com> * Correct "Z-Wave" spelling Per https://www.z-wave.com/, the canonical spelling appears to be "Z-Wave". Most places use "Z-Wave" already; change the remaining references to match. Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com> * Correct typos and grammatical errors Correct some typos and grammatical errors. Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com> * Update sitemap.md section charts (openhab#1191) I observed that the unique first word in the labels of items charted in a group isn't causing an empty chart anymore. I'm on openHAB 2.5.1. Signed-off-by: Juergen Baginski opus42@gmx.de * Add image for insteon binding (openhab#1196) Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> * typo (openhab#1198) Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Installation details (openhab#1197) Added more details around the installation and configuration process. Fixed that engine no longer logs "Activated scripting support..." Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Update sitemaps.md (openhab#1202) Added full item definition for usage of visibility. See https://community.openhab.org/t/sitemap-visibility-basic-ui/97304/9 * Updated ecobee logo (https://brand.ecobee.com/) (openhab#1203) Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> * tutorial: Fix description of sitemap 'type' (openhab#1204) In the tutorial, the generic sitemap description says that ItemType has to be the same as the type defined in default.items. Looking at https://www.openhab.org/docs/configuration/items.html#type and https://www.openhab.org/docs/configuration/sitemaps.html#element-types this is incorrect as they take different values. The example is even mislading as `Switch` is one of the only types which is common between items and sitemaps. Might be better to describe `Default` instead. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> * Added information about DateTime Group functions LATEST/EARLIEST (openhab#1206) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Add section for documentation contributions (openhab#1205) Hopefully this will lower the hurdle for people to submit documentation contributions. I know from myself that I didn't submit various documentation improvements, because I didn't know git and thought it would be a much more involved process. Ideally there would be a separate documentation section, but submitting this under the development contribution page for now (as per discussion with @Confectrician in openhab/openhab-docs#1179 (comment)). Note that I am addressing the issue of DCO failures wrt specifying the full name that I ran into myself in openhab/openhab-docs#1197 (comment). I found a good discussion of the issue at dcoapp/app#43. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * fix typo (openhab#1209) * add description of Ephemeris localization support (openhab#1210) Add a new section to describe the localization support and how-to steps Signed-off-by: Michael Roßner Schrott.Micha@web.de * Line 115 broken link - should be: (openhab#1217) * Line 115 broken link - should be: ({{base}}/docs/configuration/sitemaps.html#element-types) was: ({{base}}/configuration/configuration/sitemaps.html#element-types) * Removed diplicated docs breadcrumb Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * add missing space between words (openhab#1212) * Update configuration.md (openhab#1215) I'm a beginner myself. Though I liked this tutorial very much, it took me some time trying and erroring and finally reading forum posts to get behind this. I didn't even know there was something like a more modern ping. So maybe others are happy to learn this right from the beginning. * Remove architecture from Docker tags (openhab#1220) Docker automatically detects the architecture and downloads the appropriate image (openhab/openhab-docker#213). BuildKit will no longer generate new tags having the architecture (openhab/openhab-docker#293). Signed-off-by: Wouter Born <github@maindrain.net> * slight readability improvements (openhab#1221) * slight readability improvements * Update introduction.md * Update introduction.md * minor wording update * Update eclipse.md (openhab#1225) Clarifying that it's no longer possible to make changes in the Core Framework for 2.5.x. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * [fmiweather] logo for FMI Weather binding (openhab#929) Signed-off-by: Sami Salonen <ssalonen@gmail.com> * Update eclipse.md (openhab#1226) Added additional structure around install, run, debug and update steps. Provided more pointers to interactions with Eclipse, Maven and Git. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Update contributing.md (openhab#1227) Need to escape \< and \> in the sign off message format so users see them explicitly in the Contributing to the Documentation section. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Update contributing.md (openhab#1228) Small refinement on documentation change submission flow. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Add doc folder to the binding directory structure (openhab#1230) Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Make Subheadings Use Proper Subheading Syntax (openhab#1234) This way they render out as proper markdown and don't look weird on the website Signed-off-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de> * Remove unnecessary isCancelled() from code example (openhab#1235) Cancelling an already canceled task has no effect. IMHO this check is not necesssary and removal would simplify the code. I came to this because I saw this pattern in many bindings during reviewing. Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update thing-xml.md (openhab#1236) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Fix broken ESH links (openhab#1231) Signed-off-by: Wouter Born <github@maindrain.net> * Update logging.md (openhab#1238) Add information on how to find out the symbolic names of the bundles * Remove Apache Commons from Default Libraries (openhab#1229) See openhab#7722 Signed-off-by: Fabian Wolter <git@fabian-wolter.de> * Update introduction.md (openhab#1239) * Update introduction.md Signed-off-by: Markus Storm markus.storm@gmx.net * Update introduction.md * Revise Java recommendations (openhab#1240) * Revise Java recommendations * Delete pine.md Do not recommend PINE, it's not supported any longer by openHABian. * Removed sidebar link in config Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Update security.md (openhab#1241) Been using FreeDNS for many years (ever since all these companies got rid of their free tiers) and never an issue! * Fix DecimalType hex conversion example (openhab#1243) See: openhab/openhab-core#1526 Signed-off-by: Wouter Born <github@maindrain.net> * Fix typo (openhab#1244) Signed-off-by: Wouter Born <github@maindrain.net> * Update persistence.md (openhab#1246) Fixes link to quartz docs page. * Revision. (openhab#1187) (openhab#1237) * Revision. (openhab#1187) - Update of screenshots, removal of old screenshots - Chapters for better formatting - Removal of ZWave chapter (one example of adding things should be enough IMHO) - Adding items in simple mode and in "manual" mode Signed-off-by: Sascha Billian <sascha.billian@googlemail.com> * Use one line per sentence Signed-off-by: Sascha Billian <sascha.billian@googlemail.com> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Add notes for configuring Synology Diskstation (openhab#1219) * Add notes for configuring Synology Diskstation I have a working set up for SSL enabled remote access on a Synology diskstation, taking advantage of the GUI as much as possible, to ensure automatic renewal of certs from Let's Encrypt, etc. It took me about 8 hours to suss it all out, but it could be achieved in about 30 mins if you knew exactly what to do... may not be widely useful, but since Synology is officially supported, I figured this might be a good addition. There's also a minor error in the 'allow' masks - these should be 192.168.0.0/24 to allow access to anything in the 192.168.0.xxx range. * Updated to use one line per sentence Updated to use one line per sentence - sorry for the delay! * Update security.md * Updated for one line per sentence Updated for one line per sentence Signed-off-by: Andrew Mills mills@prettymachine.co.nz * Bad subnet (openhab#1245) Nginx warns about low address bits of `192.168.0.1/24` because they are meaningless. The correct subnet mask should be `192.168.0.0/24` Signed-off-by: Olivier Béraud <olivierberaud@free.fr> * Fixed broken images. (openhab#1247) * Fixed broken images. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix image path Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * [documentation] clarification of representation property (openhab#1248) * [documentation] clarification of representation property Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] adopt suggestions of reviewers Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] commas Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] addopted suggestions of @bobadair Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentaion] example added back Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentaion] simplified text Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] adopted reviewer comment Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Add Alexa mapping along side a channel mapping (openhab#1249) * Add Alexa mapping along side a channel mapping It took me a while to find this https://community.openhab.org/t/tagging-devices-for-alexa-support/98155/3 on the Forum and its not clearly documented in the openHAB Amazon Alexa Smart Home Skill or here in Item Metadata. I originally suggested this as an update to the openHAB Amazon Alexa Smart Home Skill documentaion, but it fits better here, then other integrations using metadata (e.g. HomeKit or Google Assistant) could refer to it as well. * Update items.md * Mention defaults for element type setpoint. (openhab#1250) Mention defaults for min, max and step value for element type setpoint. Signed-off-by: Thomas Weiler <toweosp@gmail.com> * Update index.md (openhab#1251) I thought 'workl' was probably intended to be 'work'. * Items - Bedroom_Light written as Light_Bedroom (openhab#1252) Fix small error which might mislead some readers. * Added example for time-weighted averages (openhab#1253) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Remove deprecated UIs, Eclipse Marketplace from sidebar Signed-off-by: Yannick Schaus <github@schaus.net> * Update branch name in README Signed-off-by: Yannick Schaus <github@schaus.net> Co-authored-by: Markus Storm <markus.storm@gmx.net> Co-authored-by: Nagy Attila Gábor <mrbig@sneaker.hu> Co-authored-by: Christoph Thiede <38782922+LinqLover@users.noreply.github.com> Co-authored-by: Richard Davies <rwdrich@gmail.com> Co-authored-by: jwaes <50528773+jwaes@users.noreply.github.com> Co-authored-by: bracklanna <16140600+bracklanna@users.noreply.github.com> Co-authored-by: Scott Rushworth <openhab@5iver.com> Co-authored-by: cpmeister <mistercpp2000@gmail.com> Co-authored-by: Ross Kennedy <rossko@culzean.clara.co.uk> Co-authored-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Skinah <32607303+Skinah@users.noreply.github.com> Co-authored-by: pali <pauli.anttila@gmail.com> Co-authored-by: ljsquare <laurens-jan@merkx-ewals.nl> Co-authored-by: PatrikG <40170469+PatrikG8@users.noreply.github.com> Co-authored-by: Elias H <E.Hackradt@web.de> Co-authored-by: Billy Stevens <contact@wasv.me> Co-authored-by: theiding <mark.theiding@gmail.com> Co-authored-by: jadcx <60408305+jadcx@users.noreply.github.com> Co-authored-by: Bjorn Helgaas <bjorn@helgaas.com> Co-authored-by: Jürgen Baginski <opus42@gmx.de> Co-authored-by: robnielsen <rob.nielsen@yahoo.com> Co-authored-by: GumbyMan82 <40233411+GumbyMan82@users.noreply.github.com> Co-authored-by: Christophe Fergeau <teuf@gnome.org> Co-authored-by: Paulo "JCranky" Siqueira <paulo.siqueira@gmail.com> Co-authored-by: Michael Rossner <Schrott.Micha@web.de> Co-authored-by: BugSmurF <52825547+bugsmurf@users.noreply.github.com> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: josefscript <64727123+josefscript@users.noreply.github.com> Co-authored-by: Wouter Born <github@maindrain.net> Co-authored-by: Sami Salonen <ssalonen@gmail.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de> Co-authored-by: TRS-80 <25938297+TRSx80@users.noreply.github.com> Co-authored-by: sihui <10405486+sihui62@users.noreply.github.com> Co-authored-by: Andrew Mills <amil109@users.noreply.github.com> Co-authored-by: Olivier Béraud <olivbd@users.noreply.github.com> Co-authored-by: Andrew Fiddian-Green <software@whitebear.ch> Co-authored-by: LeeC77 <LeeC77@users.noreply.github.com> Co-authored-by: Thomas Weiler <18066810+toweosp@users.noreply.github.com> Co-authored-by: garretcook <garretcook@gmail.com> Co-authored-by: Michael Fielding <michael.fielding@gmail.com>

kaikreuzer added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 19, 2016

kaikreuzer added the awaiting feedback Awaiting feedback from the pull request author label Dec 27, 2016

hakan42 requested changes Jan 5, 2017

View reviewed changes

hakan42 reviewed Jan 5, 2017

View reviewed changes

hakan42 requested changes Jan 5, 2017

View reviewed changes

kaikreuzer mentioned this pull request Jan 13, 2017

Add Section Heading: Add-ons - Bindings - Non-Native 2.0 Bindings openhab/openhab-docs#188

Closed

hakan42 requested changes Jan 13, 2017

View reviewed changes

tobof closed this Jan 14, 2017

tobof force-pushed the master branch from 2c0acf3 to 268ea27 Compare January 14, 2017 21:22

tobof reopened this Jan 14, 2017

kaikreuzer removed the awaiting feedback Awaiting feedback from the pull request author label Jan 30, 2017

tobof closed this Mar 21, 2017

tobof force-pushed the master branch from ce1c834 to f1a3062 Compare March 21, 2017 12:36

tobof mentioned this pull request Mar 22, 2017

[mysensors] MySensors Binding initial contribution #2066

Closed

Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021

Set UNINITIALIZED -> HANDLER_MISSING_ERROR after enabling a Thing and…

0046774

… handler is missing (openhab#1243) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>


		private static MySensorsCacheFactory singleton = null;

		private static final String CACHE_BASE_PATH = "./mysensors/cache";

		@@ -0,0 +1 @@
		/*.cached

MySensors binding added #1243

MySensors binding added #1243

Conversation

tobof commented Sep 19, 2016

kubawolanin commented Dec 14, 2016

tobof commented Dec 22, 2016

fab33 commented Dec 27, 2016

kaikreuzer commented Dec 27, 2016

kaikreuzer commented Dec 27, 2016

hakan42 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tobof commented Jan 5, 2017

fab33 commented Jan 5, 2017

kaikreuzer commented Jan 13, 2017

ThomDietrich commented Jan 13, 2017

kaikreuzer commented Jan 13, 2017

tobof commented Jan 13, 2017

hakan42 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hakan42 commented Jan 13, 2017

tobof commented Jan 13, 2017

hakan42 commented Jan 13, 2017

ThomDietrich commented Jan 13, 2017 • edited Loading

hakan42 commented Jan 13, 2017 • edited Loading

kubawolanin commented Jan 13, 2017 • edited Loading

tobof commented Jan 14, 2017

tobof commented Jan 30, 2017

kaikreuzer commented Jan 30, 2017

tobof commented Feb 1, 2017

mcinnes01 commented Feb 25, 2017

hakan42 commented Mar 21, 2017

tobof commented Mar 21, 2017

ThomDietrich commented Jan 13, 2017 •

edited

Loading

hakan42 commented Jan 13, 2017 •

edited

Loading

kubawolanin commented Jan 13, 2017 •

edited

Loading