[sony][WIP] Sony Binding initial contribution #1249

tmrobert8 · 2016-09-21T19:11:23Z

New Sony binding

Signed-off-by: Tim Roberts troberts@bigfoot.com

tmrobert8 · 2016-09-21T19:16:31Z

Discussion at openhab community

tmrobert8 · 2016-09-22T14:00:40Z

Attached is the latest build of this binding. Please make sure you read the README file within the zip file for setup.

org.openhab.binding.sony.zip

tmrobert8 · 2016-10-22T01:50:16Z

Attached is the latest build of this binding. This includes the IRCC service which should provide access to any sony IRCC device (tvs, blurays, avrs).

org.openhab.binding.sony.zip

watou · 2016-10-22T09:21:14Z

Would it be possible to give this binding a more specific name? Calling the binding "sony" is problematic, as Sony has a massive range of products, and this binding is not nor should it be intended to cover all of Sony's devices. Perhaps "sonybravia" or "sonysimpleip" or ?

kaikreuzer

I'm done with my review. Please let me know if you have any questions - if not, please ping me once you are done. Thanks!

kaikreuzer · 2016-12-27T16:11:08Z

addons/binding/org.openhab.binding.sony/.project

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>org.openhab.binding.sony</name>


I'd also opt for changing the binding id to sonybravia

but Bravia is TVs only. This binding supports also other devices like BR Player

kaikreuzer · 2016-12-27T16:11:34Z

addons/binding/org.openhab.binding.sony/ESH-INF/binding/binding.xml

+        xsi:schemaLocation="http://eclipse.org/smarthome/schemas/binding/v1.0.0 http://eclipse.org/smarthome/schemas/binding-1.0.0.xsd">
+
+    <name>Sony Binding</name>
+    <description>This is the binding for Sony Products.</description>


"Sony Products" -> be a bit more specific here.

kaikreuzer · 2016-12-27T16:11:42Z

addons/binding/org.openhab.binding.sony/ESH-INF/i18n/sony_xx_XX.properties

@@ -0,0 +1,11 @@
+# binding


remove this file

kaikreuzer · 2016-12-27T16:12:31Z

addons/binding/org.openhab.binding.sony/ESH-INF/thing/thing-types.xml

+        xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">
+
+    <!-- Sample Thing Type -->
+    <thing-type id="bravia">


could you apply the auto code formatter? There should usually be tabs instead of spaces here.

kaikreuzer · 2016-12-27T16:14:04Z

addons/binding/org.openhab.binding.sony/ESH-INF/thing/thing-types.xml

+            <parameter name="ipAddress" type="text" required="true">
+                <context>network-address</context>
+                <label>IP or Host Name</label>
+                <description>The IP or host name of the Russound RIO access point</description>


Russound???

kaikreuzer · 2016-12-27T16:47:01Z

...nhab.binding.sony/src/main/java/org/openhab/binding/sony/internal/bravia/BraviaProtocol.java

+     */
+    private void handleTogglePIPPosition(String parms) {
+        if (RSP_ERROR.equals(parms)) {
+            logger.debug(TOGGLE_PIP_POSITION + " command failed: " + parms);


change to parameterized logging

kaikreuzer · 2016-12-27T16:47:05Z

...nhab.binding.sony/src/main/java/org/openhab/binding/sony/internal/bravia/BraviaProtocol.java

+        } else if (RSP_SUCCESS.equals(parms)) {
+            // success!
+        } else {
+            logger.warn("Unknown " + TOGGLE_PIP_POSITION + " response: " + parms);


change to parameterized logging

kaikreuzer · 2016-12-27T16:47:18Z

...nhab.binding.sony/src/main/java/org/openhab/binding/sony/internal/bravia/BraviaProtocol.java

+            return;
+        }
+
+        logger.warn("Unparsable notification: " + response);


change to parameterized logging

kaikreuzer · 2016-12-27T16:47:39Z

...nhab.binding.sony/src/main/java/org/openhab/binding/sony/internal/bravia/BraviaProtocol.java

+    @Override
+    public void responseException(Exception e) {
+        _callback.statusChanged(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR,
+                "Exception occurred reading from the socket: " + e);


change to + e.getMessage()

kaikreuzer · 2016-12-27T16:50:16Z

addons/binding/pom.xml

@@ -1,59 +1,60 @@
-<?xml version="1.0" encoding="UTF-8"?>


not sure why it shows this whole file being changed. Maybe revert the change and only add the single new line with your binding.

Please also add the binding here: https://github.com/openhab/openhab2-addons/blob/master/features/openhab-addons/src/main/feature/feature.xml

tmrobert8 · 2016-12-28T03:34:30Z

Ack - sorry you went through the process of reviewing this. This addon isn't even CLOSE to being ready yet and I only put it out here to allow people to test it. Very much still evolving and the code has changed (alot) since the last commit here. Since this commit - I've added DIAL support and have started the new WebScalarAPI. Once I'm done with those - I plan to wrap all the APIs into discoverable product lines. As you can see, still alot of work. If you would, don't bother reviewing this until I give a thumbs up

BTW - the comment about the name is something I've struggled with since it's too limiting. The reason I say this is because these services are across a wide product range. SimpleIP is for bravia only, IRCC is for tvs/blurays/avrs (100+ products actually), DIAL is for tvs/blurays (possibly avrs) and WebScalarAPI is on tvs/blurays/uhd blurays. Usually there is more than one service on each product and some work in conjunction with each other (ie DIAL on blurays is 'unsecured' but on tvs relies on the WebScalarAPI to login then DIAL works, etc). So naming it via products doesn't make sense because these services are over a huge range of products and naming it via service doesn't make sense since the services interact with each other. Because of that "sony" made the most sense with services (and eventually products) being directories within it. The only real thing missing on the sony side is playstations (and I have both a PS3 & PS4 that I may tackle after this) - so it would be pretty complete anyway...

kaikreuzer · 2016-12-28T09:55:48Z

@tmrobert8 Thanks for the update! I can see that you are still planning many changed and enhancements. Seeing the huge interest of the community in this binding, I would nonetheless encourage you to check whether you can clean the code in a way that we could push out a first official version of it, while adding further enhancements later on.

Wrt the name, I get your argument and don't have any better suggestion. @watou as you raised this, would you be ok to stick to "sony", acknowledging that it is meant to cover a wide range of products?

tmrobert8 · 2016-12-30T13:25:47Z

Latest build - fixes channel parsing issue and implements new DIAL service (please read the README.MD for details). DIAL ONLY works on blurays at this time (I have yet to figure out the authentication scheme on bravias and have no idea if this works on avrs or not).

org.openhab.binding.sony.zip

tmrobert8 · 2016-12-30T15:41:17Z

Kai,

I committed everything I have (including many of the changes you requested). Note: I have not gone through to fix the comments (generally is the very last thing I do when I'm happy with the code - which I'm not). Atleast this now reflects the latest jar that people are testing with. Still will have changes forthcoming I'm sure...

Tim

kaikreuzer · 2016-12-30T15:52:59Z

Thanks Tim! So I take this as a "please don't yet consider it for merging" at the moment, right? I'll have a second review round once you give me a go (because you are happy with the code yourself).

One question: I'd have the same comment as on Russound regarding the readonlystring, string and button channel-types: Would it be too much to ask you to re-modell these as specific channel-types instead?

tmrobert8 · 2016-12-30T16:50:53Z

Yes - not worth reviewing yet. I'll do the same with the channels (note: I'll also apply it to the atlona one as well).

tmrobert8 · 2017-01-24T20:08:03Z

Attached is the latest binding

Notes - many things have changed and it would be worth removing your current setup and rediscoverying. If you used IRCC - all the channels have changed (they are now using channel groups and some of the names have changed) - please see the readme within the zip file for the new names.

Autodiscovery has been changed to actually interrogate the device to make sure it works (doesn't depend on what it advertises anymore). If your device use to show up and no longer does - the device doesn't support it).

sony-binding.zip

tmrobert8 · 2017-02-22T19:51:00Z

Testing zip:

sony-binding-2017-02-22-1.zip

berre73 · 2017-03-09T15:27:00Z

Hi Tim,
I have a Bravia KDL55W805A and I installed your last binding. The TV is recognised but it remains offline. On the console i get the following:
sony:scalar:00000000-0000-1010-8000-3c0771d47ee6 (Type=Thing, Status=OFFLINE (COMMUNICATION_ERROR): Error connecting to IRCC device (may need to turn it on manually), Label=BRAVIA KDL-55W805A, Bridge=null)

Even if the TV is turned on then I get the same. Tried rebooting, manually addinf things but no luck. Simple IP is not on this TV. Any advise?

Regards,

Bert

martinvw · 2017-06-16T12:25:24Z

Hello @tmrobert8 what are your plans wrt finishing it? Do you have an ETA?

jacksteraz · 2017-06-19T04:35:58Z

Comment removed. This was more of a bug report. Will repost in https://community.openhab.org/t/sony-devices-binding/14052/241

mhilbush · 2017-07-21T10:57:05Z

Thanks, @tmrobert8. I should be able to start looking at this on Sunday or Monday.

openhab-bot · 2017-08-20T03:46:08Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/exec-binding-to-control-sony-bravia/33362/14

tmrobert8 · 2017-08-22T14:18:24Z

New binding
sony-binding-20170822.zip

davidvanlaatum · 2017-09-10T05:34:00Z

Latest binding detects my TV but not my sound bar which is a Sony HT RT5. The sound bar is detected by the chromecast binding and it seems to have a lot of the same http endpoints

openhab-bot · 2017-09-12T17:02:45Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sony-devices-binding/14052/309

tmrobert8 · 2017-09-12T17:21:15Z

@davidvanlaatum Could you repost in the community link above with the debug log from the binding. You're the first soundbar - so I'd like to see what is being discovered (or not!)

openhab-bot · 2017-10-14T06:51:22Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sony-devices-binding/14052/338

openhab-bot · 2017-11-08T23:18:59Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sony-devices-binding/14052/364

tmrobert8 · 2017-11-08T23:19:26Z

@martinvw
Nope - still trying to solve some issues

valvebg · 2017-12-04T23:24:44Z

@davidvanlaatum did you manage to integrate the binding with Sony HT RT5?
More specially to change the source, power or volume?

davidvanlaatum · 2017-12-05T09:06:55Z

@valvebg no the chromecast plugin allows changing the volume

tmrobert8 · 2017-12-05T14:17:09Z

@valvebg @davidvanlaatum
Just to let you know - I just received an HT NT5 (which is similar) - once I get the NEEO binding/transport wrapped up, I'll be swinging back around to this to see if I can get it working

Mattrees007 · 2018-01-06T19:58:34Z

@tmrobert8
Hi. im probably being slow here. ive installed the snapshot jar and the binding is showing in OH2.2 but the binding does seem to do an autodiscover and i cant configure the binding.

Any ideas?

WizBangCrash · 2018-01-21T21:23:09Z

I have the same issue as @Mattrees007 . I've installed the binding into a 2.2.0 system. The binding is showing in the PaperUI and "bundles:list" shows it as active, but it is not auto discovering my Blu-ray player.

I get the following message in openhab.log if I try to force a discovery using "smarthome:discovery start 235" where I got the bundle id from "bundle:list"

2018-01-21 21:48:13.124 [WARN ] [nternal.DiscoveryServiceRegistryImpl] - No discovery service for binding id '235' found!

Even though "bundle:list | grep Sony" reports:
235 │ Active │ 80 │ 2.2.0.201711082312 │ Sony Binding

valic · 2018-01-22T15:27:24Z

Error at startup, is there a solution?

Error starting bundle 213: Could not resolve module: org.openhab.binding.sony [213]
Unresolved requirement: Import-Package: org.apache.http

lsiepel · 2018-01-23T23:53:17Z

The binding is not OH2.2 compatible due to some depricated http module. Details: https://community.openhab.org/t/sony-devices-binding/14052/445

openhab-bot · 2018-06-06T20:35:00Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sony-devices-binding/14052/483

openhab-bot · 2018-07-24T10:47:58Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/contributing-a-new-binding/48232/4

wborn · 2019-01-28T13:36:47Z

I don't see any new commits so I assume this is still WIP @tmrobert8?

tmrobert8 · 2019-02-01T16:14:29Z

Yes WIP - I'm hopefully going to commit something that will need a review in a few weeks - but for now a WIP

openhab-bot · 2019-10-06T10:50:48Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/import-and-use-httputil-directly-in-rule/83016/11

tmrobert8 · 2020-01-10T14:32:49Z

@kaikreuzer
Just a heads up - I should finally be at the point where I'm requesting a PR next week (solving the last issue right now, have finished all the documentation and will make a final beta release next week). This has become a MONSTROUS binding in size (I think the zwave binding was the biggest - this is about 4 times the size of that atleast - the jar file is 1.28Mb itself) and I'm not sure how you want to handle it review wise and merging wise, resource wise, etc. Giving you a heads up to think about it prior to the official PR request.

Note - I have updated it to 2.5.1 (rebased to 2.5.x) already. If you want a preview - I have it sitting in a different branch at 1234-Sony.

Note2 - this will also completely replace the sonyaudio binding (already had @freke test this one) - I don't know what the measures are to deprecate or remove an binding.

Note3 - I'd like to eventually pull the sony beamer addon into this one as well to make it complete (there are a number of advantages to having it pulled into this project - mainly the ability to dynamically generate thing types and use of the database). However, we probably should make that a post PR thing.

Note4 - should I close this one and start a new PR as well?

kaikreuzer · 2020-01-10T21:10:06Z

Hey @tmrobert8, thanks for the heads-up!

this will also completely replace the sonyaudio binding (already had @freke test this one)

Does the binding get @freke's absolution as a replacement?

I don't know what the measures are to deprecate or remove an binding.

It means that we cannot do it for 2.5.x anymore as no backward compatibility breaking changes are allowed. So you should create the PR against master (and thus do a namespace refactoring, e.g. using a script like this).

I'd like to eventually pull the sony beamer addon into this one as well to make it complete

Are there any technical similarities wrt the protocol or do you just want to avoid any confusion about the binding name? Do you consider "sony" future-proof, i.e. is it highly unlikely that other Sony products are turning up that might require their dedicated binding? Normally, we have bindings for products, not for brands.

should I close this one and start a new PR as well?

Yes, I think that would be best.

tmrobert8 · 2020-01-12T18:04:10Z

I haven't heard from @freke for awhile now. The last communication I had from him was that the addon correctly worked against the device(s) he has access to. Not sure if he's still there or just hasn't been checking. How about this - as part of my PR I simply change the README for the sony audio to say "deprecated - use sony plugin instead"?

As for the sony projects - my personal opinion is that it should be by brand rather than by product (I don't want to figure out and install all the various products - want to install something that handles the brand that works with all my products). However, from a tech standpoint it could gain alot from being rebased on my sony framework. But that's a different argument and I won't address with this at all (maybe in the future).

I'll submit a new PR (and close this one) later this upcoming week..

kaikreuzer · 2020-01-14T07:43:01Z

How about this - as part of my PR I simply change the README for the sony audio to say "deprecated - use sony plugin instead"?

As your PR goes against master, there currently is no "sonyaudio" binding, so no need to touch it in any way. If your binding is successfully reviewed, merged and considered a full replacement, we simply won't port the sonyaudio binding from 2.5 to 3.0 and leave an according note in the release notes.

freke · 2020-01-14T09:44:00Z

@kaikreuzer (@tmrobert8) feel free to replace the current sonyaudio binding with this one, since this is more complete. It includes everything that my binding does and more.

tmrobert8 · 2020-01-14T15:18:34Z

As your PR goes against master

You are sure you want me to go against the 3.x master rather than the 2.5.x branch? If we are leaving the audio alone for now - seems like the 2.5.x branch would be best?

Plus - I'd rather not go against 3.x as I'd be maintaining three separate versions for awhile (we are currently maintains 2.4 and a 2.5 since there are people not wanting to move off of 2.4 yet - I know I should probably push them - but the point remains - would really not like to maintain a 2.5 and 3.0 at the very least).

Note: I have atleast 50 people I know of and atleast 100+ unique (sony) things running right now - so I have too large of a base to not maintain 2.5...

kaikreuzer · 2020-01-14T20:45:38Z

Ok, understood. Then create your PR against 2.5.x and we can do the review and evolution there. But we should only merge it then once we make master the main dev branch again.

tmrobert8 · 2020-01-21T14:28:02Z

Just created new PR #6884 and closing this one...

@Confectrician

* Update README (2.5.x) (openhab#1153) Change branch name. Signed-off-by: Yannick Schaus <github@schaus.net> * Update items.md (openhab#1156) * Added var and VA units to UoM (openhab#1146) VA (Volt-Ampere - apparent power) and var (Volt-Ampere reactive) are used to measure power and energy consumption in AC circuits. Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> * Fix filepath to keystore (openhab#1148) Default openHAB userdata environment variable should be `$OPENHAB_USERDATA`, not `$USER_DATA` shouldn't it? At least, this is the default on my fresh openHABian and also the most popular variant to find in the docs. * Slight language corrections (openhab#1150) I think it reads better this way Signed-off-by: Richard Davies <rwdrich@gmail.com> * additional example for non default persistence service (openhab#1152) For me it was confusing how to pass on the serviceId into methods that already had an argument. An extra example is always good. Signed-off-by: jaco <jaco.waes@gmail.com> * Adding 12 new logos for OH Add-Ons page on website (openhab#1158) Signed-off-by: bracklanna bracklanna@users.noreply.github.com * Added missing preset variables (openhab#1104) * Added missing preset variables Signed-off-by: Scott Rushworth <openhab@5iver.com> * Cleaned up blank lines, fixed table, and added file name for SimpleRule Signed-off-by: Scott Rushworth <openhab@5iver.com> * Fix broken link (openhab#1165) * Added Hotlink from "label" section to "state presentation" (openhab#1167) * Added note about broken action (openhab#1164) * Added note about broken action See openhab/openhab-core#1374 Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Update index.md (openhab#1170) Link appears to be wrong and does not work when I click on it in Edge. Loads the same page again instead of loading the correct new page from the hyperlink. https://www.openhab.org/docs/developer/guidelines.html * Added Airthings logo (openhab#1171) * typo in exambp (openhab#1172) `Temperature.averageSince(now.minusMinutes(5),"influxdb")` * file.encoding=UTF-8 (openhab#1173) * Update demo URL and add demo.rules URL (openhab#1174) Based on: https://community.openhab.org/t/demo-setup-missing/94850 Old Link is broken leading to 404. The link to the demo.rules on github is an extra :) * Replace outdated zulu.org link. (openhab#1177) * Replace outdated zulu.org link. As of 3/23/2020 zulu.org has an SSL cert that expired on 9/28/2019. Changed link to azul.com/downloads, since that appears to be the new official source. Signed-off-by: Billy Stevens <contact@wasv.me> * Changed all http links to https for installation/index.md. All changed links working, tested on 3/24/2020. Signed-off-by: Billy Stevens <contact@wasv.me> * Minor language tweak (openhab#1178) * Ending an active scan/stopScan (openhab#1179) Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Add files via upload (openhab#1184) * Update persistence.md (openhab#1185) Clarify return objects for max/min rules extensions. Signed-off-by: Ross Kennedy rossko@culzean.clara.co.uk * Update things.md (openhab#1186) Amended example code to include using label and location when defining a Thing with a bridge that is defined elsewhere. * Correct typos (openhab#1190) * Correct usage of its/it's "It's" is always a contraction of "it is" or "it has". "Its" is a possessive. Correct a few places where they were used backwards. Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com> * Correct "Z-Wave" spelling Per https://www.z-wave.com/, the canonical spelling appears to be "Z-Wave". Most places use "Z-Wave" already; change the remaining references to match. Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com> * Correct typos and grammatical errors Correct some typos and grammatical errors. Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com> * Update sitemap.md section charts (openhab#1191) I observed that the unique first word in the labels of items charted in a group isn't causing an empty chart anymore. I'm on openHAB 2.5.1. Signed-off-by: Juergen Baginski opus42@gmx.de * Add image for insteon binding (openhab#1196) Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> * typo (openhab#1198) Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Installation details (openhab#1197) Added more details around the installation and configuration process. Fixed that engine no longer logs "Activated scripting support..." Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Update sitemaps.md (openhab#1202) Added full item definition for usage of visibility. See https://community.openhab.org/t/sitemap-visibility-basic-ui/97304/9 * Updated ecobee logo (https://brand.ecobee.com/) (openhab#1203) Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> * tutorial: Fix description of sitemap 'type' (openhab#1204) In the tutorial, the generic sitemap description says that ItemType has to be the same as the type defined in default.items. Looking at https://www.openhab.org/docs/configuration/items.html#type and https://www.openhab.org/docs/configuration/sitemaps.html#element-types this is incorrect as they take different values. The example is even mislading as `Switch` is one of the only types which is common between items and sitemaps. Might be better to describe `Default` instead. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> * Added information about DateTime Group functions LATEST/EARLIEST (openhab#1206) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Add section for documentation contributions (openhab#1205) Hopefully this will lower the hurdle for people to submit documentation contributions. I know from myself that I didn't submit various documentation improvements, because I didn't know git and thought it would be a much more involved process. Ideally there would be a separate documentation section, but submitting this under the development contribution page for now (as per discussion with @Confectrician in openhab/openhab-docs#1179 (comment)). Note that I am addressing the issue of DCO failures wrt specifying the full name that I ran into myself in openhab/openhab-docs#1197 (comment). I found a good discussion of the issue at dcoapp/app#43. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * fix typo (openhab#1209) * add description of Ephemeris localization support (openhab#1210) Add a new section to describe the localization support and how-to steps Signed-off-by: Michael Roßner Schrott.Micha@web.de * Line 115 broken link - should be: (openhab#1217) * Line 115 broken link - should be: ({{base}}/docs/configuration/sitemaps.html#element-types) was: ({{base}}/configuration/configuration/sitemaps.html#element-types) * Removed diplicated docs breadcrumb Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * add missing space between words (openhab#1212) * Update configuration.md (openhab#1215) I'm a beginner myself. Though I liked this tutorial very much, it took me some time trying and erroring and finally reading forum posts to get behind this. I didn't even know there was something like a more modern ping. So maybe others are happy to learn this right from the beginning. * Remove architecture from Docker tags (openhab#1220) Docker automatically detects the architecture and downloads the appropriate image (openhab/openhab-docker#213). BuildKit will no longer generate new tags having the architecture (openhab/openhab-docker#293). Signed-off-by: Wouter Born <github@maindrain.net> * slight readability improvements (openhab#1221) * slight readability improvements * Update introduction.md * Update introduction.md * minor wording update * Update eclipse.md (openhab#1225) Clarifying that it's no longer possible to make changes in the Core Framework for 2.5.x. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * [fmiweather] logo for FMI Weather binding (openhab#929) Signed-off-by: Sami Salonen <ssalonen@gmail.com> * Update eclipse.md (openhab#1226) Added additional structure around install, run, debug and update steps. Provided more pointers to interactions with Eclipse, Maven and Git. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Update contributing.md (openhab#1227) Need to escape \< and \> in the sign off message format so users see them explicitly in the Contributing to the Documentation section. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Update contributing.md (openhab#1228) Small refinement on documentation change submission flow. Signed-off-by: Mark Theiding <mark.theiding@gmail.com> * Add doc folder to the binding directory structure (openhab#1230) Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Make Subheadings Use Proper Subheading Syntax (openhab#1234) This way they render out as proper markdown and don't look weird on the website Signed-off-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de> * Remove unnecessary isCancelled() from code example (openhab#1235) Cancelling an already canceled task has no effect. IMHO this check is not necesssary and removal would simplify the code. I came to this because I saw this pattern in many bindings during reviewing. Signed-off-by: Fabian Wolter <github@fabian-wolter.de> * Update thing-xml.md (openhab#1236) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Fix broken ESH links (openhab#1231) Signed-off-by: Wouter Born <github@maindrain.net> * Update logging.md (openhab#1238) Add information on how to find out the symbolic names of the bundles * Remove Apache Commons from Default Libraries (openhab#1229) See openhab#7722 Signed-off-by: Fabian Wolter <git@fabian-wolter.de> * Update introduction.md (openhab#1239) * Update introduction.md Signed-off-by: Markus Storm markus.storm@gmx.net * Update introduction.md * Revise Java recommendations (openhab#1240) * Revise Java recommendations * Delete pine.md Do not recommend PINE, it's not supported any longer by openHABian. * Removed sidebar link in config Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Update security.md (openhab#1241) Been using FreeDNS for many years (ever since all these companies got rid of their free tiers) and never an issue! * Fix DecimalType hex conversion example (openhab#1243) See: openhab/openhab-core#1526 Signed-off-by: Wouter Born <github@maindrain.net> * Fix typo (openhab#1244) Signed-off-by: Wouter Born <github@maindrain.net> * Update persistence.md (openhab#1246) Fixes link to quartz docs page. * Revision. (openhab#1187) (openhab#1237) * Revision. (openhab#1187) - Update of screenshots, removal of old screenshots - Chapters for better formatting - Removal of ZWave chapter (one example of adding things should be enough IMHO) - Adding items in simple mode and in "manual" mode Signed-off-by: Sascha Billian <sascha.billian@googlemail.com> * Use one line per sentence Signed-off-by: Sascha Billian <sascha.billian@googlemail.com> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> * Add notes for configuring Synology Diskstation (openhab#1219) * Add notes for configuring Synology Diskstation I have a working set up for SSL enabled remote access on a Synology diskstation, taking advantage of the GUI as much as possible, to ensure automatic renewal of certs from Let's Encrypt, etc. It took me about 8 hours to suss it all out, but it could be achieved in about 30 mins if you knew exactly what to do... may not be widely useful, but since Synology is officially supported, I figured this might be a good addition. There's also a minor error in the 'allow' masks - these should be 192.168.0.0/24 to allow access to anything in the 192.168.0.xxx range. * Updated to use one line per sentence Updated to use one line per sentence - sorry for the delay! * Update security.md * Updated for one line per sentence Updated for one line per sentence Signed-off-by: Andrew Mills mills@prettymachine.co.nz * Bad subnet (openhab#1245) Nginx warns about low address bits of `192.168.0.1/24` because they are meaningless. The correct subnet mask should be `192.168.0.0/24` Signed-off-by: Olivier Béraud <olivierberaud@free.fr> * Fixed broken images. (openhab#1247) * Fixed broken images. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * Fix image path Signed-off-by: Jerome Luckenbach <github@luckenba.ch> * [documentation] clarification of representation property (openhab#1248) * [documentation] clarification of representation property Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] adopt suggestions of reviewers Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] commas Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] addopted suggestions of @bobadair Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentaion] example added back Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentaion] simplified text Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] typo Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * [documentation] adopted reviewer comment Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> * Add Alexa mapping along side a channel mapping (openhab#1249) * Add Alexa mapping along side a channel mapping It took me a while to find this https://community.openhab.org/t/tagging-devices-for-alexa-support/98155/3 on the Forum and its not clearly documented in the openHAB Amazon Alexa Smart Home Skill or here in Item Metadata. I originally suggested this as an update to the openHAB Amazon Alexa Smart Home Skill documentaion, but it fits better here, then other integrations using metadata (e.g. HomeKit or Google Assistant) could refer to it as well. * Update items.md * Mention defaults for element type setpoint. (openhab#1250) Mention defaults for min, max and step value for element type setpoint. Signed-off-by: Thomas Weiler <toweosp@gmail.com> * Update index.md (openhab#1251) I thought 'workl' was probably intended to be 'work'. * Items - Bedroom_Light written as Light_Bedroom (openhab#1252) Fix small error which might mislead some readers. * Added example for time-weighted averages (openhab#1253) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Remove deprecated UIs, Eclipse Marketplace from sidebar Signed-off-by: Yannick Schaus <github@schaus.net> * Update branch name in README Signed-off-by: Yannick Schaus <github@schaus.net> Co-authored-by: Markus Storm <markus.storm@gmx.net> Co-authored-by: Nagy Attila Gábor <mrbig@sneaker.hu> Co-authored-by: Christoph Thiede <38782922+LinqLover@users.noreply.github.com> Co-authored-by: Richard Davies <rwdrich@gmail.com> Co-authored-by: jwaes <50528773+jwaes@users.noreply.github.com> Co-authored-by: bracklanna <16140600+bracklanna@users.noreply.github.com> Co-authored-by: Scott Rushworth <openhab@5iver.com> Co-authored-by: cpmeister <mistercpp2000@gmail.com> Co-authored-by: Ross Kennedy <rossko@culzean.clara.co.uk> Co-authored-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Skinah <32607303+Skinah@users.noreply.github.com> Co-authored-by: pali <pauli.anttila@gmail.com> Co-authored-by: ljsquare <laurens-jan@merkx-ewals.nl> Co-authored-by: PatrikG <40170469+PatrikG8@users.noreply.github.com> Co-authored-by: Elias H <E.Hackradt@web.de> Co-authored-by: Billy Stevens <contact@wasv.me> Co-authored-by: theiding <mark.theiding@gmail.com> Co-authored-by: jadcx <60408305+jadcx@users.noreply.github.com> Co-authored-by: Bjorn Helgaas <bjorn@helgaas.com> Co-authored-by: Jürgen Baginski <opus42@gmx.de> Co-authored-by: robnielsen <rob.nielsen@yahoo.com> Co-authored-by: GumbyMan82 <40233411+GumbyMan82@users.noreply.github.com> Co-authored-by: Christophe Fergeau <teuf@gnome.org> Co-authored-by: Paulo "JCranky" Siqueira <paulo.siqueira@gmail.com> Co-authored-by: Michael Rossner <Schrott.Micha@web.de> Co-authored-by: BugSmurF <52825547+bugsmurf@users.noreply.github.com> Co-authored-by: Jerome Luckenbach <github@luckenba.ch> Co-authored-by: josefscript <64727123+josefscript@users.noreply.github.com> Co-authored-by: Wouter Born <github@maindrain.net> Co-authored-by: Sami Salonen <ssalonen@gmail.com> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de> Co-authored-by: TRS-80 <25938297+TRSx80@users.noreply.github.com> Co-authored-by: sihui <10405486+sihui62@users.noreply.github.com> Co-authored-by: Andrew Mills <amil109@users.noreply.github.com> Co-authored-by: Olivier Béraud <olivbd@users.noreply.github.com> Co-authored-by: Andrew Fiddian-Green <software@whitebear.ch> Co-authored-by: LeeC77 <LeeC77@users.noreply.github.com> Co-authored-by: Thomas Weiler <18066810+toweosp@users.noreply.github.com> Co-authored-by: garretcook <garretcook@gmail.com> Co-authored-by: Michael Fielding <michael.fielding@gmail.com>

kaikreuzer added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 21, 2016

tmrobert8 force-pushed the 1231-Sony branch from 943a105 to e305e48 Compare September 22, 2016 13:57

smyrman mentioned this pull request Sep 29, 2016

[sony] Sony Bravia JSON/XML RPC support #1268

Closed

tmrobert8 changed the title ~~New sony binding - currently only Bravia but will add bluray players~~ New sony binding - simpleip (bravia) and IRCC Oct 22, 2016

kaikreuzer requested changes Dec 27, 2016

View reviewed changes

kaikreuzer added the awaiting feedback Awaiting feedback from the pull request author label Dec 27, 2016

tmrobert8 force-pushed the 1231-Sony branch from 38c8d95 to 4206c9f Compare July 19, 2017 19:31

tmrobert8 force-pushed the 1231-Sony branch from 4206c9f to 1fda306 Compare November 1, 2017 15:07

wborn mentioned this pull request Mar 24, 2018

[sony] Add Sony Binding #1231

Closed

wborn changed the title ~~New sony binding - simpleip (bravia) and IRCC~~ [sony] Sony Binding initial contribution Dec 18, 2018

wborn changed the title ~~[sony] Sony Binding initial contribution~~ [sony][WIP] Sony Binding initial contribution Jan 28, 2019

wborn added work in progress A PR that is not yet ready to be merged and removed awaiting feedback Awaiting feedback from the pull request author labels Jan 28, 2019

J-N-K added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Nov 22, 2019

tmrobert8 closed this Jan 21, 2020

[sony][WIP] Sony Binding initial contribution #1249

[sony][WIP] Sony Binding initial contribution #1249

Conversation

tmrobert8 commented Sep 21, 2016

tmrobert8 commented Sep 21, 2016

tmrobert8 commented Sep 22, 2016

tmrobert8 commented Oct 22, 2016

watou commented Oct 22, 2016

kaikreuzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmrobert8 commented Dec 28, 2016

kaikreuzer commented Dec 28, 2016

tmrobert8 commented Dec 30, 2016

tmrobert8 commented Dec 30, 2016

kaikreuzer commented Dec 30, 2016

tmrobert8 commented Dec 30, 2016

tmrobert8 commented Jan 24, 2017 • edited Loading

tmrobert8 commented Feb 22, 2017

berre73 commented Mar 9, 2017

martinvw commented Jun 16, 2017

jacksteraz commented Jun 19, 2017 • edited Loading

mhilbush commented Jul 21, 2017

openhab-bot commented Aug 20, 2017

tmrobert8 commented Aug 22, 2017

davidvanlaatum commented Sep 10, 2017

openhab-bot commented Sep 12, 2017

tmrobert8 commented Sep 12, 2017

openhab-bot commented Oct 14, 2017

openhab-bot commented Nov 8, 2017

tmrobert8 commented Nov 8, 2017

valvebg commented Dec 4, 2017 • edited Loading

davidvanlaatum commented Dec 5, 2017

tmrobert8 commented Dec 5, 2017

Mattrees007 commented Jan 6, 2018 • edited Loading

WizBangCrash commented Jan 21, 2018 • edited Loading

valic commented Jan 22, 2018

lsiepel commented Jan 23, 2018 • edited Loading

openhab-bot commented Jun 6, 2018

openhab-bot commented Jul 24, 2018

wborn commented Jan 28, 2019

tmrobert8 commented Feb 1, 2019

openhab-bot commented Oct 6, 2019

tmrobert8 commented Jan 10, 2020 • edited Loading

kaikreuzer commented Jan 10, 2020

tmrobert8 commented Jan 12, 2020

kaikreuzer commented Jan 14, 2020

freke commented Jan 14, 2020

tmrobert8 commented Jan 14, 2020

kaikreuzer commented Jan 14, 2020

tmrobert8 commented Jan 21, 2020

tmrobert8 commented Jan 24, 2017 •

edited

Loading

jacksteraz commented Jun 19, 2017 •

edited

Loading

valvebg commented Dec 4, 2017 •

edited

Loading

Mattrees007 commented Jan 6, 2018 •

edited

Loading

WizBangCrash commented Jan 21, 2018 •

edited

Loading

lsiepel commented Jan 23, 2018 •

edited

Loading

tmrobert8 commented Jan 10, 2020 •

edited

Loading