New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Atlona PRO3 binding (#1171) #1252

Merged

kaikreuzer merged 3 commits into openhab:master from tmrobert8:1171-Atlona

Feb 16, 2017

tmrobert8 commented Sep 21, 2016

Implementation of Atlona binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

kaikreuzer added the new binding label

Member

kaikreuzer commented Dec 28, 2016

Ready to be reviewed?

Author

tmrobert8 commented Dec 28, 2016

There is a new firmware about to come out (in beta right now) - but it should have minor changes (if any). I'd say this is probably good to be reviewed

Member

kaikreuzer commented Dec 28, 2016

Ok, so please rebase your branch in order to resolve merge conflicts.
Also, as a quick first feedback, please check the code against the guidelines, e.g.

remove version constraints from imports in the manifest
update the license headers
remove the "version" annotations from the Javadoc headers

Thanks!

Author

tmrobert8 commented Jan 3, 2017

Kai,

Just to let you know - I'm carrying over the comments you've made on the russound one into this one and will commit this week. You may want to hold off on any further review until the new commit.

Tim

kaikreuzer added the awaiting feedback label

Author

tmrobert8 commented Jan 5, 2017

Kai,

I've updated the addon with most of the comments from the other addons (the channel groups really were useful on this one). Feel free to review and rip it apart! :)

Tim

kaikreuzer removed the awaiting feedback label

kaikreuzer requested changes

View reviewed changes

Member

kaikreuzer left a comment

Hey @tmrobert8, I finished my review, it's your turn again :-)

addons/binding/org.openhab.binding.atlona/ESH-INF/thing/thing-types.xml Outdated

+                      <config-description>
+                          <parameter name="ipAddress" type="text">
+                              <label>IP or Host Name</label>

Member

kaikreuzer Jan 10, 2017

add context "network-address"

same for other thing types

addons/binding/org.openhab.binding.atlona/ESH-INF/thing/thing-types.xml Outdated

+                              <advanced>true</advanced>
+                          </parameter>
+                          <parameter name="password" type="text">
+                              <label>Password to login with</label>

Member

kaikreuzer Jan 10, 2017

add context "password"

same for other thing types

addons/binding/org.openhab.binding.atlona/ESH-INF/thing/thing-types.xml Outdated

+                  <!-- AT-UHD-PRO3-44M -->
+                  <thing-type id="pro3-44m">
+                      <label>Atlona Pro3 4x4 Binding</label>

Member

kaikreuzer Jan 10, 2017

remove "Binding" here

same for other thing types

addons/binding/org.openhab.binding.atlona/ESH-INF/thing/thing-types.xml Outdated

+                  <!-- AT-UHD-PRO3-44M -->
+                  <thing-type id="pro3-44m">
+                      <label>Atlona Pro3 4x4 Binding</label>
+                      <description>Atlona Pro3 4x4 Binding</description>

Member

kaikreuzer Jan 10, 2017

remove "Binding" here and either provide more information that the label already has or do an empty description

same for other thing types

addons/binding/org.openhab.binding.atlona/ESH-INF/thing/thing-types.xml Outdated

		</channel-group-type>


		<channel-group-type id="portgroup1">

Member

kaikreuzer Jan 10, 2017

No, that is not meant that way.
You should declare a single type "portgroup" and use it for all your groups (they are all identical, aren't they?)

I am aware that you cannot override label and description yet - this is something to be discussed in eclipse-archived/smarthome#2717.

Author

tmrobert8 Jan 10, 2017

Without the label/description overrides - this becomes a complete mess of not knowing what port is which port (especially on the 16x16) in the paperui and I'd rather not remove it until that issue is resolved. I'd prefer to do this because it's just alot of duplicate junk that's not needed because of the label/description issue. What if I just update it when that issue is closed?

...atlona/src/main/java/org/openhab/binding/atlona/internal/pro3/AtlonaPro3PortocolHandler.java Outdated

+                      }
+                  }
+                  // private void handleRs232Response(Matcher m, String resp) {

Member

kaikreuzer Jan 10, 2017

remove?

...b.binding.sony/src/main/java/org/openhab/binding/sony/internal/net/SocketChannelSession.java Outdated

+                   * (non-Javadoc)
+                   *
+                   * @see
+                   * org.openhab.binding.russound.internal.net.SocketSession#addListener(org.openhab.binding.russound.internal.net.

Member

kaikreuzer Jan 10, 2017

remove the russound references - probably best to completely remove the JavaDoc on overridden methods as they do not bring much value.

Author

tmrobert8 Jan 10, 2017

Yeah - didn't notice that one - thanks!

...b.binding.sony/src/main/java/org/openhab/binding/sony/internal/net/SocketChannelSession.java Outdated

+                          throw new IllegalArgumentException("command cannot be null");
+                      }
+                      // if (command.trim().length() == 0) {

Member

kaikreuzer Jan 10, 2017

remove?

addons/binding/pom.xml Outdated

		@@ -1,72 +1,73 @@
		<?xml version="1.0" encoding="UTF-8"?>

Member

kaikreuzer Jan 10, 2017

please revert these changes and only add a single new line

addons/binding/org.openhab.binding.atlona/META-INF/MANIFEST.MF Outdated

+               org.eclipse.smarthome.core.thing.binding.builder,
+               org.eclipse.smarthome.core.thing.type,
+               org.eclipse.smarthome.core.types,
+               org.jupnp.model.meta,

Member

kaikreuzer Jan 10, 2017

afaics, this is not needed

kaikreuzer added the awaiting feedback label

Author

tmrobert8 commented Jan 11, 2017

Kai - I believe I've made all the changes except for the channel groups. I strongly believe that should wait until the label/description override is available since it is really confusing in the Paper UI without them

kaikreuzer removed the awaiting feedback label

kaikreuzer reviewed

View reviewed changes

...b.binding.sony/src/main/java/org/openhab/binding/sony/internal/net/SocketChannelSession.java Outdated

		@@ -0,0 +1,420 @@
		package org.openhab.binding.sony.internal.net;

Member

kaikreuzer Feb 2, 2017

this file is from the sony binding

Member

kaikreuzer commented Feb 2, 2017

I strongly believe that should wait until the label/description override is available since it is really confusing in the Paper UI without them

Ok, I agree, let's leave it, but keep in mind to refactor it again, once we can define different labels.

There are still some issues regarding moved files, so please resolve this and we should be good to merge. Btw, you should never merge the master branch into your feature branch, but rather rebase your feature branch on the latest master - this should avoid such issues.

kaikreuzer mentioned this pull request

Thing definition: accept a label and a description for a channel group eclipse-archived/smarthome#2717

Closed

tmrobert8 force-pushed the 1171-Atlona branch from 7f2a716 to 281a586 Compare

February 14, 2017 15:29

Author

tmrobert8 commented Feb 14, 2017

Kai - just updated the thing to use label/description overrides - take a look

Member

kaikreuzer commented Feb 15, 2017

Thanks! Just checked, but there is still one file being moved from russound to sony - this must definitely be removed from this PR!

Author

tmrobert8 commented Feb 15, 2017

Kai - I think I made a mess of my branch. Thought I had a handle on git up to now - could you take a look and give me some hints on how I might correct all this?

Author

tmrobert8 commented Feb 15, 2017

BTW - if you take a look at https://github.com/openhab/openhab2-addons/tree/master/addons/binding/org.openhab.binding.atlona/src/main/java/org/openhab/binding

That's on the master tree and should not be there - I think they snuck in with the russound merge. Obviously I need to be more careful with git and copying files around. Not sure how I managed that one either.


          Clean up branch

c038415

tmrobert8 force-pushed the 1171-Atlona branch from 996bbb5 to c038415 Compare

February 15, 2017 15:13


          Fresh update of atlona branch

2fe06bd

Author

tmrobert8 commented Feb 15, 2017

OK - I think I fixed it up - that atlona branch in the master tree was what was causing all the issues. The two last commits should have fixed that and pushed the correct files

Member

kaikreuzer commented Feb 16, 2017

Ok, looks better now indeed!
But since time has gone by, I have two additional wishes:

Please change the version to from 2.0.0 to 2.1.0 (in pom and manifest)
Re-run `mvn license:format' to get the latest (2017) headers


          Updated license headers and moved to version 2.1

bfb29db

Author

tmrobert8 commented Feb 16, 2017

Done

Member

kaikreuzer commented Feb 16, 2017

Cool - let's rock 😎

kaikreuzer merged commit ca6fd3d into openhab:master

fharni pushed a commit to fharni/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

ff97869

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

jarlebh pushed a commit to jarlebh/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

bc034b4

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

cweitkamp pushed a commit to cweitkamp/openhab-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

c6f5a25

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

tratho pushed a commit to tratho/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

2a51386

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

kaikreuzer modified the milestone: 2.1

Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

500391b

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

d064dd8

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

8e2e574

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

3f72c11

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request


          New Atlona PRO3 binding (openhab#1171) (openhab#1252)

2f2a670

New Atlona PRO3 binding

Signed-off-by: Tim Roberts troberts@bigfoot.com (github: tmrobert8)

wborn mentioned this pull request

New Atlona binding #1171

Closed

tmrobert8 deleted the 1171-Atlona branch

July 31, 2018 12:40

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request


          Merge 2.5.x into main (openhab#1266)

d72156a

* Update README (2.5.x) (openhab#1153)

Change branch name.

Signed-off-by: Yannick Schaus <github@schaus.net>

* Update items.md (openhab#1156)

* Added var and VA units to UoM (openhab#1146)

VA (Volt-Ampere - apparent power) and var (Volt-Ampere reactive) are used to measure power and energy consumption in AC circuits.


Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

* Fix filepath to keystore (openhab#1148)

Default openHAB userdata environment variable should be `$OPENHAB_USERDATA`, not `$USER_DATA` shouldn't it? At least, this is the default on my fresh openHABian and also the most popular variant to find in the docs.

* Slight language corrections (openhab#1150)

I think it reads better this way

Signed-off-by: Richard Davies <rwdrich@gmail.com>

* additional example for non default persistence service (openhab#1152)

For me it was confusing how to pass on the serviceId into methods that already had an argument. An extra example is always good.

Signed-off-by: jaco <jaco.waes@gmail.com>

* Adding 12 new logos for OH Add-Ons page on website (openhab#1158)

Signed-off-by: bracklanna bracklanna@users.noreply.github.com

* Added missing preset variables (openhab#1104)

* Added missing preset variables

Signed-off-by: Scott Rushworth <openhab@5iver.com>

* Cleaned up blank lines, fixed table, and added file name for SimpleRule

Signed-off-by: Scott Rushworth <openhab@5iver.com>

* Fix broken link (openhab#1165)

* Added Hotlink from "label" section to "state presentation" (openhab#1167)

* Added note about broken action (openhab#1164)

* Added note about broken action

See openhab/openhab-core#1374

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated changes from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated changes from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Update index.md (openhab#1170)

Link appears to be wrong and does not work when I click on it in Edge. Loads the same page again instead of loading the correct new page from the hyperlink.

https://www.openhab.org/docs/developer/guidelines.html

* Added Airthings logo (openhab#1171)

* typo in exambp (openhab#1172)

`Temperature.averageSince(now.minusMinutes(5),"influxdb")`

* file.encoding=UTF-8 (openhab#1173)

* Update demo URL and add demo.rules URL (openhab#1174)

Based on: https://community.openhab.org/t/demo-setup-missing/94850
Old Link is broken leading to 404.
The link to the demo.rules on github is an extra :)

* Replace outdated zulu.org link. (openhab#1177)

* Replace outdated zulu.org link.

As of 3/23/2020 zulu.org has an SSL cert that expired on 9/28/2019. Changed link to azul.com/downloads, since that appears to be the new official source.

Signed-off-by: Billy Stevens <contact@wasv.me>

* Changed all http links to https for installation/index.md.

All changed links working, tested on 3/24/2020.

Signed-off-by: Billy Stevens <contact@wasv.me>

* Minor language tweak (openhab#1178)

* Ending an active scan/stopScan (openhab#1179)

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* Add files via upload (openhab#1184)

* Update persistence.md (openhab#1185)

Clarify return objects for max/min rules extensions.

Signed-off-by: Ross Kennedy rossko@culzean.clara.co.uk

* Update things.md (openhab#1186)

Amended example code to include using label and location when defining a Thing with a bridge that is defined elsewhere.

* Correct typos (openhab#1190)

* Correct usage of its/it's

"It's" is always a contraction of "it is" or "it has".  "Its" is a
possessive.  Correct a few places where they were used backwards.

Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com>

* Correct "Z-Wave" spelling

Per https://www.z-wave.com/, the canonical spelling appears to be "Z-Wave".
Most places use "Z-Wave" already; change the remaining references to match.

Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com>

* Correct typos and grammatical errors

Correct some typos and grammatical errors.

Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com>

* Update sitemap.md section charts (openhab#1191)

I observed that the unique first word in the labels of items charted in a group isn't causing an empty chart anymore. I'm on openHAB 2.5.1.

Signed-off-by: Juergen Baginski opus42@gmx.de

* Add image for insteon binding (openhab#1196)

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>

* typo (openhab#1198)

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* Installation details (openhab#1197)

Added more details around the installation and configuration process.
Fixed that engine no longer logs "Activated scripting support..."

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* Update sitemaps.md (openhab#1202)

Added full item definition for usage of visibility. See https://community.openhab.org/t/sitemap-visibility-basic-ui/97304/9

* Updated ecobee logo (https://brand.ecobee.com/) (openhab#1203)

Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>

* tutorial: Fix description of sitemap 'type' (openhab#1204)

In the tutorial, the generic sitemap description says that ItemType has
to be the same as the type defined in default.items.
Looking at
https://www.openhab.org/docs/configuration/items.html#type and
https://www.openhab.org/docs/configuration/sitemaps.html#element-types
this is incorrect as they take different values.
The example is even mislading as `Switch` is one of the only types which
is common between items and sitemaps. Might be better to describe
`Default` instead.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

* Added information about DateTime Group functions LATEST/EARLIEST (openhab#1206)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Add section for documentation contributions (openhab#1205)

Hopefully this will lower the hurdle for people to submit documentation contributions. I know from myself that I didn't submit various documentation improvements, because I didn't know git and thought it would be a much more involved process. 
Ideally there would be a separate documentation section, but submitting this under the development contribution page for now (as per discussion with @Confectrician in openhab/openhab-docs#1179 (comment)).
Note that I am addressing the issue of DCO failures wrt specifying the full name that I ran into myself in openhab/openhab-docs#1197 (comment). I found a good discussion of the issue at dcoapp/app#43.

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* fix typo (openhab#1209)

* add description of Ephemeris localization support (openhab#1210)

Add a new section to describe the localization support and how-to steps

Signed-off-by: Michael Roßner Schrott.Micha@web.de

* Line 115 broken link - should be: (openhab#1217)

* Line 115 broken link - should be:

({{base}}/docs/configuration/sitemaps.html#element-types)

was:
({{base}}/configuration/configuration/sitemaps.html#element-types)

* Removed diplicated docs breadcrumb

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>

Co-authored-by: Jerome Luckenbach <github@luckenba.ch>

* add missing space between words (openhab#1212)

* Update configuration.md (openhab#1215)

I'm a beginner myself. Though I liked this tutorial very much, it took me some time trying and erroring and finally reading forum posts to get behind this. I didn't even know there was something like a more modern ping. So maybe others are happy to learn this right from the beginning.

* Remove architecture from Docker tags (openhab#1220)

Docker automatically detects the architecture and downloads the appropriate image (openhab/openhab-docker#213).
BuildKit will no longer generate new tags having the architecture (openhab/openhab-docker#293).

Signed-off-by: Wouter Born <github@maindrain.net>

* slight readability improvements (openhab#1221)

* slight readability improvements

* Update introduction.md

* Update introduction.md

* minor wording update

* Update eclipse.md (openhab#1225)

Clarifying that it's no longer possible to make changes in the Core Framework for 2.5.x.

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* [fmiweather] logo for FMI Weather binding (openhab#929)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* Update eclipse.md (openhab#1226)

Added additional structure around install, run, debug and update steps. Provided more pointers to interactions with Eclipse, Maven and Git.

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* Update contributing.md (openhab#1227)

Need to escape \< and \> in the sign off message format so users see them explicitly in the Contributing to the Documentation section. 

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* Update contributing.md (openhab#1228)

Small refinement on documentation change submission flow. 

Signed-off-by: Mark Theiding <mark.theiding@gmail.com>

* Add doc folder to the binding directory structure (openhab#1230)

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

* Make Subheadings Use Proper Subheading Syntax (openhab#1234)

This way they render out as proper markdown and don't look weird on the website

Signed-off-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>

* Remove unnecessary isCancelled() from code example (openhab#1235)

Cancelling an already canceled task has no effect. IMHO this check is not necesssary and removal would simplify the code. I came to this because I saw this pattern in many bindings during reviewing.

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

* Update thing-xml.md (openhab#1236)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Fix broken ESH links (openhab#1231)

Signed-off-by: Wouter Born <github@maindrain.net>

* Update logging.md (openhab#1238)

Add information on how to find out the symbolic names of the bundles

* Remove Apache Commons from Default Libraries (openhab#1229)

See openhab#7722
Signed-off-by: Fabian Wolter <git@fabian-wolter.de>

* Update introduction.md (openhab#1239)

* Update introduction.md

Signed-off-by: Markus Storm markus.storm@gmx.net

* Update introduction.md

* Revise Java recommendations (openhab#1240)

* Revise Java recommendations

* Delete pine.md

Do not recommend PINE, it's not supported any longer by openHABian.

* Removed sidebar link in config

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>

Co-authored-by: Jerome Luckenbach <github@luckenba.ch>

* Update security.md (openhab#1241)

Been using FreeDNS for many years (ever since all these companies got rid of their free tiers) and never an issue!

* Fix DecimalType hex conversion example (openhab#1243)

See: openhab/openhab-core#1526

Signed-off-by: Wouter Born <github@maindrain.net>

* Fix typo (openhab#1244)

Signed-off-by: Wouter Born <github@maindrain.net>

* Update persistence.md (openhab#1246)

Fixes link to quartz docs page.

* Revision. (openhab#1187) (openhab#1237)

* Revision. (openhab#1187)

- Update of screenshots, removal of old screenshots
- Chapters for better formatting
- Removal of ZWave chapter (one example of adding things should be enough IMHO)
- Adding items in simple mode and in "manual" mode

Signed-off-by: Sascha Billian <sascha.billian@googlemail.com>

* Use one line per sentence
Signed-off-by: Sascha Billian <sascha.billian@googlemail.com>

Co-authored-by: Jerome Luckenbach <github@luckenba.ch>

* Add notes for configuring Synology Diskstation (openhab#1219)

* Add notes for configuring Synology Diskstation

I have a working set up for SSL enabled remote access on a Synology diskstation, taking advantage of the GUI as much as possible, to ensure automatic renewal of certs from Let's Encrypt, etc. It took me about 8 hours to suss it all out, but it could be achieved in about 30 mins if you knew exactly what to do... may not be widely useful, but since Synology is officially supported, I figured this might be a good addition.

There's also a minor error in the 'allow' masks - these should be 192.168.0.0/24 to allow access to anything in the 192.168.0.xxx range.

* Updated to use one line per sentence

Updated to use one line per sentence - sorry for the delay!

* Update security.md

* Updated for one line per sentence

Updated for one line per sentence

Signed-off-by: Andrew Mills mills@prettymachine.co.nz

* Bad subnet (openhab#1245)

Nginx warns about low address bits of `192.168.0.1/24` because they are meaningless.
The correct subnet mask should be `192.168.0.0/24`

Signed-off-by: Olivier Béraud <olivierberaud@free.fr>

* Fixed broken images. (openhab#1247)

* Fixed broken images.

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>

* Fix image path

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>

* [documentation] clarification of representation property (openhab#1248)

* [documentation] clarification of representation property

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] adopt suggestions of reviewers

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] commas

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] addopted suggestions of @bobadair

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentaion] example added back

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentaion] simplified text

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [documentation] adopted reviewer comment

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* Add Alexa mapping along side a channel mapping (openhab#1249)

* Add Alexa mapping along side a channel mapping

It took me a while to find this https://community.openhab.org/t/tagging-devices-for-alexa-support/98155/3 on the Forum and its not clearly documented in the openHAB Amazon Alexa Smart Home Skill or here in Item Metadata.
I originally suggested this as an update to the openHAB Amazon Alexa Smart Home Skill documentaion, but it fits better here, then other integrations using metadata (e.g. HomeKit or Google Assistant) could refer to it as well.

* Update items.md

* Mention defaults for element type setpoint. (openhab#1250)

Mention defaults for min, max and step value for element type setpoint.

Signed-off-by: Thomas Weiler <toweosp@gmail.com>

* Update index.md (openhab#1251)

I thought 'workl' was probably intended to be 'work'.

* Items - Bedroom_Light written as Light_Bedroom (openhab#1252)

Fix small error which might mislead some readers.

* Added example for time-weighted averages (openhab#1253)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Remove deprecated UIs, Eclipse Marketplace from sidebar

Signed-off-by: Yannick Schaus <github@schaus.net>

* Update branch name in README

Signed-off-by: Yannick Schaus <github@schaus.net>

Co-authored-by: Markus Storm <markus.storm@gmx.net>
Co-authored-by: Nagy Attila Gábor <mrbig@sneaker.hu>
Co-authored-by: Christoph Thiede <38782922+LinqLover@users.noreply.github.com>
Co-authored-by: Richard Davies <rwdrich@gmail.com>
Co-authored-by: jwaes <50528773+jwaes@users.noreply.github.com>
Co-authored-by: bracklanna <16140600+bracklanna@users.noreply.github.com>
Co-authored-by: Scott Rushworth <openhab@5iver.com>
Co-authored-by: cpmeister <mistercpp2000@gmail.com>
Co-authored-by: Ross Kennedy <rossko@culzean.clara.co.uk>
Co-authored-by: Christoph Weitkamp <github@christophweitkamp.de>
Co-authored-by: Skinah <32607303+Skinah@users.noreply.github.com>
Co-authored-by: pali <pauli.anttila@gmail.com>
Co-authored-by: ljsquare <laurens-jan@merkx-ewals.nl>
Co-authored-by: PatrikG <40170469+PatrikG8@users.noreply.github.com>
Co-authored-by: Elias H <E.Hackradt@web.de>
Co-authored-by: Billy Stevens <contact@wasv.me>
Co-authored-by: theiding <mark.theiding@gmail.com>
Co-authored-by: jadcx <60408305+jadcx@users.noreply.github.com>
Co-authored-by: Bjorn Helgaas <bjorn@helgaas.com>
Co-authored-by: Jürgen Baginski <opus42@gmx.de>
Co-authored-by: robnielsen <rob.nielsen@yahoo.com>
Co-authored-by: GumbyMan82 <40233411+GumbyMan82@users.noreply.github.com>
Co-authored-by: Christophe Fergeau <teuf@gnome.org>
Co-authored-by: Paulo "JCranky" Siqueira <paulo.siqueira@gmail.com>
Co-authored-by: Michael Rossner <Schrott.Micha@web.de>
Co-authored-by: BugSmurF <52825547+bugsmurf@users.noreply.github.com>
Co-authored-by: Jerome Luckenbach <github@luckenba.ch>
Co-authored-by: josefscript <64727123+josefscript@users.noreply.github.com>
Co-authored-by: Wouter Born <github@maindrain.net>
Co-authored-by: Sami Salonen <ssalonen@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Stefan Zabka <zabkaste@informatik.hu-berlin.de>
Co-authored-by: TRS-80 <25938297+TRSx80@users.noreply.github.com>
Co-authored-by: sihui <10405486+sihui62@users.noreply.github.com>
Co-authored-by: Andrew Mills <amil109@users.noreply.github.com>
Co-authored-by: Olivier Béraud <olivbd@users.noreply.github.com>
Co-authored-by: Andrew Fiddian-Green <software@whitebear.ch>
Co-authored-by: LeeC77 <LeeC77@users.noreply.github.com>
Co-authored-by: Thomas Weiler <18066810+toweosp@users.noreply.github.com>
Co-authored-by: garretcook <garretcook@gmail.com>
Co-authored-by: Michael Fielding <michael.fielding@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels