Dashboard Lists Integration #3000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renames build and test workflow to eliminate ambiguity. * Adds coverage generation for jest and mocha tests. * Expands coverage collection for jest tests. * Utilizes `lcov` reporter as well as text summary reporter. Resolves opensearch-project#1339 Prerequisite for opensearch-project#1035 Signed-off-by: Tommy Markley <markleyt@amazon.com>
* feat(Expressions): Initial demo plugin Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * feat(Expressions): Adds handlers tab Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * feat(Expressions): Adds playground tab Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * chore: Better expression playground messaging Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * feat(Expressions): Adds expression explorer Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * feat(Expressions): A better explorer Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * fix(Expressions): Fix basic demo abort error Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates readme and fixes rendering visualizations Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
* [Bug] fix copy as curl Copy as curl doesn't work in Dev Tools console due to usage of a deprecated method: https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility Issue Resolved: opensearch-project#1471 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds browser compatibility comment Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
* Addresses multiple CVEs. * CVE-2021-44531 (High) * CVE-2022-21824 (High) * CVE-2022-0778 (High) * CVE-2021-44532 (Medium) * CVE-2021-44533 (Medium) * [CHANGELOG](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2022-03-17-version-14191-fermium-lts-richardlau) Follow-up from opensearch-project#920 Signed-off-by: Tommy Markley <markleyt@amazon.com>
Resolves opensearch-project#1035 Signed-off-by: Tommy Markley <markleyt@amazon.com>
…pensearch-project#1442) Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
* fix(actions): Better type checks for icons - fix typo in iconType for `replace_panel` action - change iconType types from `string` to `EuiIconType` - use `icon` instead of `iconType` for svg pathseslin Signed-off-by: Josh Romero <rmerqg@amazon.com> * fix(actions): Remove unnecessary icon assertions Signed-off-by: Josh Romero <rmerqg@amazon.com>
…typing (opensearch-project#1491) * fix(Expressions): Fixes rendering viz when expression changes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * chore: Improves visualization types Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * chore: Updates Render type for other viz expressions Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Increment from 2.0.0 to 3.0.0, also some version checks. Also, add a release build verification workflow. To verify x64 and ARM64 artifacts are built successfully with dependencies. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.7. - [Release notes](https://github.com/mde/ejs/releases) - [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md) - [Commits](mde/ejs@v3.1.6...v3.1.7) --- updated-dependencies: - dependency-name: ejs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com> fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> add CVE details and emoji Signed-off-by: Anan Zhuang <ananzh@amazon.com> make node-14 to CVE Signed-off-by: Anan Zhuang <ananzh@amazon.com> remove UI lib from breaking changes. correct deprecations and maintanence Signed-off-by: Anan Zhuang <ananzh@amazon.com>
* [CI] Create doc issue workflow Add workflow to create documentation issue in https://github.com/opensearch-project/documentation-website Update CONTRIBUTING doc on how to use. Issue: opensearch-project#1493 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * follow up Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Tommy Markley <markleyt@amazon.com>
* This workflow is unnecessary now that the org uses the DCO App. * Removes the DCO badge from the README. Signed-off-by: Tommy Markley <markleyt@amazon.com>
…-project#1552) * Addresses CVE-2022-1214 * Bumps and resolves `axios` to ^0.27.2 to address CVE * [CHANGELOG](https://github.com/axios/axios/blob/master/CHANGELOG.md) * Bumps `chromedriver` to v100 to match GitHub actions Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
add back icon directive, which injects SVG Signed-off-by: Josh Romero <rmerqg@amazon.com>
* Exact copy of 2.0.0-rc1 release notes. * New changes between RC1 and GA must be added as PRs are merged. Signed-off-by: Tommy Markley <markleyt@amazon.com>
Signed-off-by: Tommy Markley <markleyt@amazon.com>
Addresses CVE-2022-1537 Issue: opensearch-project#1579 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…arch-project#1559) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <markleyt@amazon.com>
…t#1598) There is currently to a PR to remove the v7 and v8 (beta) theme versions within the application but it is getting stale: opensearch-project#978 Since the v8 (beta) theme isn't actually planned and has the incorrect version, we do not want end users to be able to change this setting. In the essence of time, this will prevent this setting from showing in the Advanced Settings page but will also not break users who set this version already (however it will lock them into theme until they switched by manually updating or deleting the config doc). Removing this setting will force the default to be v8 (beta). Temporary fix for: opensearch-project#494 But it should be removed completely. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…1599) Resolves opensearch-project#1594 Signed-off-by: Tommy Markley <markleyt@amazon.com>
* [Build][Tests] handle painless scripts update Sample data and functional tests were utilizing deprecated methods for painless scripts. However these deprecated methods were removed in: opensearch-project/OpenSearch#3346 This is to ensure sample data and ftr tests work but end users saved objects might contain painless scripts that we might not be able to address. So we should research if this it is possible to help mitigate this. Related issue: opensearch-project#1600 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…#1626) package.json and yarn.lock already updated to 100.0.0 Signed-off-by: Josh Romero <rmerqg@amazon.com>
… upload feature (opensearch-project#1632) * adds logic to accommodate import custom map tab from dashboards-maps plugin Signed-off-by: Shivam Dhar <dhshivam@amazon.com> * adds type to http and notifications Signed-off-by: Shivam Dhar <dhshivam@amazon.com> Co-authored-by: Shivam Dhar <dhshivam@amazon.com>
…earch-project#1649) Signed-off-by: manasvis <manasvis@amazon.com>
* [CI][BWC] add BWC tests to github actions Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…project#1570) Signed-off-by: Rafael Vargas <rafaelflvargas@gmail.com>
…roject#1663) Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
…efox (opensearch-project#2853) * fix: fix VisBuilder empty animation does not work in firefox Signed-off-by: raintygao <tygao@amazon.com> * doc: add changelog for pull request Signed-off-by: raintygao <tygao@amazon.com> Signed-off-by: raintygao <tygao@amazon.com>
…pensearch-project#2867) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
- Update README with full capabilities - Add `current_usage` to track current usage Signed-off-by: Josh Romero <rmerqg@amazon.com>
…project#2734) * Adding yarn opensearch args to setup opensearch plugin dependencies on snapshot * Updating the example opensearch snapshot help command with --P arg * Adding tests to the plugin installation function * Adding documentation for the new flag in developer guide Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
* [WS-2021-0638][Security] bump mocha to 10.1.0 In our current repo, most mocha tests have been changed to jest in this issue: opensearch-project#215 The fix for the above issue (mochajs/mocha@61b4b92) is only released in the latest version v10.1.0: https://github.com/mochajs/mocha/blob/5f96d511dbf913f135b92198aab721a27f6b44fe/lib/utils.js#L79 Since we are considering this change might break others, we will not backport to 2.x and release it in 3.0.0 Issue Resolved: opensearch-project#2269 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
* register ru locale Signed-off-by: Dmitry Dudin <d_dudin@step.ru>
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <clausen.patrick@gmail.com> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <clausen.patrick@gmail.com> Signed-off-by: Patrick Clausen <clausen.patrick@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
The release notes are in the 2.4 branch and 2.4.0 tag but not in main or 2.x which is our usual standard. Instead of cherry-picking commits I have just copied over the file. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Test data generated with: yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.4.0/opensearch-2.4.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.4.0/opensearch-dashboards-2.4.0-linux-x64.tar.gz -g true yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.4.0/opensearch-2.4.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.4.0/opensearch-dashboards-2.4.0-linux-x64.tar.gz -g true -s true Issues Resolved: opensearch-project#2556 Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
* Reenable CI tests for feature branches Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…pensearch-project#2964) * When updating the timestamps were requested, scanCopy first set the times and then copied content into the destination folder. On certain platforms, copying files into a folder updates its "Last Access Time" and that overwrites the just set timestamps. This PR, makes sure the timestamps are set only after copying the content. Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
…ch-project#2965) Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
…roject#2963) * Makes `yarn pkg-version` work across platforms Signed-off-by: Miki <amoo_miki@yahoo.com> * Makes `yarn pkg-version` work across platforms Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
…ross platforms (opensearch-project#2994) Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
8 tasks
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Thanks for raising this PR. Why would this not go to |
|
Fixes opensearch-project#2996, opensearch-project#2353 - Bump `leaflet-vega` to `^0.9.0` - they merged in our upstream PR and made a release - Fix the parameter name for passing `vega.parse` options. Signed-off-by: Miki <miki@amazon.com>
Basic data points [OSD] 16 submitted PRs (https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/manasvinibs) [OSD] 74 reviewed PRs (https://github.com/opensearch-project/OpenSearch-Dashboards/issues?q=reviewed-by%3Amanasvinibs) [OSD] 28 issues involved (https://github.com/opensearch-project/OpenSearch-Dashboards/issues?page=1&q=involves%3Amanasvinibs+is%3Aissue) Highlight Mana is assisting with extensions project which will be the next evolution of extending core functionality from OpenSearch Dashboards Mana implemented opensearch-project#2734 which allows for a huge quality of life for local development for external plugin developers to utilize snapshots with a single CLI command compared to before when they would had to pull down OpenSearch build, install their plugin on OpenSearch, and ensure the proper configurations. This has caused historically problems when plugin teams do development and miss some steps per their onboard documentation/PR suggestion and get different results than expected. Mana has assisted reviewing PRs providing great insight on BWC tests, BWC in general, and the release process. Mana has added documentation from insight she has gained within the informal dev doc repo https://cptnb.github.io/opensearch-dashboards-dev-docs/ ensuring the spread of knowledge. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #3000 +/- ##
==========================================
- Coverage 66.73% 66.64% -0.09%
==========================================
Files 3219 3220 +1
Lines 61450 61474 +24
Branches 9417 9418 +1
==========================================
- Hits 41007 40969 -38
- Misses 18203 18258 +55
- Partials 2240 2247 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8 tasks
pjfitzgibbons
force-pushed
the
feature/dashboard-list-integration.5
branch
from
7aaa7bb
to
9d62439
Compare
|
@pjfitzgibbons can we close this since we have #3090? |
|
Duplicate of #3090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configure types for registration of Dashboard List "Providers" and "Creators"
Add Left-Nav "top-level" category for Observability
Signed-off-by: Peter Fitzgibbons pjfitz@amazon.com
These changes enable the interactions demonstrated in this animation:
Issues WIP
[FEATURE] Dashboards List Extensibility & Integrate Observability Apps/Panels/EventAnalytics
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr