Fixing the tests for concurrent search #11076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasundra07
requested review from
abbashus,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
peternied,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami and
VachaShah
as code owners
|
@sohami @neetikasinghal Please review. |
Compatibility status:Checks if related components are compatible with change ac4ff3c Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
kasundra07
force-pushed
the
conc-test-changes
branch
from
4866361 to
b759c33
Compare
Gradle Check (Jenkins) Run Completed with:
|
kkmr
approved these changes
Nov 6, 2023
|
@kasundra07 lets make changes only for the functions for which the indexRandom function is meant to work in order to create slices greater >=2. |
5 tasks
jed326
reviewed
Nov 7, 2023
server/src/internalClusterTest/java/org/opensearch/search/fetch/subphase/InnerHitsIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
kasundra07
force-pushed
the
conc-test-changes
branch
from
de91c97 to
3d3ed66
Compare
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
kasundra07
force-pushed
the
conc-test-changes
branch
from
3d3ed66 to
ac4ff3c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
jed326
approved these changes
Nov 8, 2023
neetikasinghal
approved these changes
Nov 9, 2023
sohami
approved these changes
Nov 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com> (cherry picked from commit 3f30511) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 tasks
8 tasks
jed326
pushed a commit
to jed326/OpenSearch
that referenced
this pull request
Nov 16, 2023
* Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
sohami
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Add indexRandomForConcurrentSearch method to tests: (#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> * Add indexRandomForConcurrentSearch for tests: (#11181) * MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <jayd0104@gmail.com> * Fix tests for concurrent search with IndexRandomForConcurrentSearch follow-up [#11130] (#11212) Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> * Fix tests for concurrent search (#11130) Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> * Fixing the tests for concurrent search (#11076) * Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Fixed test cases for concurrent search (#11184) Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently Signed-off-by: Ethan Emoto <eemoto@amazon.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com> Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: Ethan Emoto <eemoto@amazon.com> Co-authored-by: Ganesh Krishna Ramadurai <gramadur@icloud.com> Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com> Co-authored-by: Bansi Kasundra <66969140+kasundra07@users.noreply.github.com> Co-authored-by: Ethan Emoto <70109490+e-emoto@users.noreply.github.com>
fahadshamiinsta
pushed a commit
to fahadshamiinsta/OpenSearch270
that referenced
this pull request
Dec 4, 2023
* Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
rayshrey
pushed a commit
to rayshrey/OpenSearch
that referenced
this pull request
Mar 18, 2024
* Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <kasundra@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to make sure that the index random function which is used in multiple classes has creation of multiple segments to test the concurrent search code path in the following ITs -
Related Issues
Muted Concurrent search case in tests due to pending fix -
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.