Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for concurrent search with IndexRandomForConcurrentSearch f… #11212

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix tests for concurrent search with IndexRandomForConcurrentSearch f… #11212

merged 1 commit into from
Nov 16, 2023

Conversation

Gankris96
Copy link
Contributor

follow-up [#11130]

Description

This fix follows up the pr - [#11130] with few additional fixes
This pr addresses the following tests


SearchScrollIT
.testSimpleScrollQueryThenFetch
.testSimpleScrollQueryThenFetchSmallSizeUnevenDistribution
.testScrollAndUpdateIndex
.testSimpleScrollQueryThenFetch_clearScrollIds
.testSimpleScrollQueryThenFetchClearAllScrollIds
.testDeepScrollingDoesNotBlowUp
.testStringSortMissingAscTerminates
.testCloseAndReopenOrDeleteWithActiveScroll
.testScrollInvalidDefaultKeepAlive
.testRestartDataNodesDuringScrollSearch


FieldSortIT
.testIssue8226
.testScoreSortDirection
.testScoreSortDirectionWithFunctionScore
.testIssue2991
.testSimpleSorts
.testSortMissingNumbers
.testSortMissingNumbersMinMax
.testSortMissingStrings
.testSortMVField
.testSortOnRareField
.testSortMetaField
.testNestedSort
.testFieldAlias
.testFieldAliasesWithMissingValues
.testCastDate
.testLongSortOptimizationCorrectResults



GeoDistanceIT
.testDistanceSortingMVFields
.testDistanceSortingWithMissingGeoPoint
.testDistanceSortingWithUnmappedField

SourceFetchingIT
.testSourceFiltering
.testSourceWithWildcardFiltering


SuggestSearchIT
.testSimple

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

#10247

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 20a8d2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change e8ae5fc

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git]

@Gankris96 Gankris96 marked this pull request as ready for review November 15, 2023 20:11
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 847b931: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator

sohami commented Nov 15, 2023

@Gankris96 precommit and assemble are failing, can you please take a look ?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1d83e2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Fix tests for concurrent search with IndexRandomForConcurrentSearch f…
e8ae5fc 
…ollow-up [opensearch-project#11130]

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for e8ae5fc: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sohami sohami merged commit b1adc84 into opensearch-project:main Nov 16, 2023
27 checks passed
@jed326 jed326 mentioned this pull request Nov 16, 2023
Closed
5 tasks
@sohami
Copy link
Collaborator

sohami commented Nov 16, 2023 

SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Existing one: #10755

@jed326 jed326 mentioned this pull request Nov 16, 2023
Merged
8 tasks
jed326 pushed a commit to jed326/OpenSearch that referenced this pull request Nov 16, 2023
@Gankris96
Fix tests for concurrent search with IndexRandomForConcurrentSearch f…
697fcf3 
…ollow-up [opensearch-project#11130] (opensearch-project#11212)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
sohami pushed a commit that referenced this pull request Nov 17, 2023
@jed326 @Gankris96
@kasundra07 @e-emoto
[Backport 2.x] Add indexRandomForConcurrentSearch for tests (#11204)
b33981e 
* Add indexRandomForConcurrentSearch method to tests: (#11118)

* IndexStatsIT.java
* SearchTimeoutIT.java
* NaNSortingIT.java
* NestedIT.java
* RangeIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Add indexRandomForConcurrentSearch for tests: (#11181)

* MultiSearchIT.java
* SimpleNestedIT.java
* SearchPreferenceIT.java
* SimpleQueryStringIT.java
* ScriptQuerySearchIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Fix tests for concurrent search with IndexRandomForConcurrentSearch follow-up [#11130] (#11212)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>

* Fix tests for concurrent search (#11130)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>

* Fixing the tests for concurrent search (#11076)

* Fixing the tests for concurrent search

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>

* Remove changes for non-flaky tests

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>

---------

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>

* Fixed test cases for concurrent search (#11184)

Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <eemoto@amazon.com>

---------

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com>
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Ethan Emoto <eemoto@amazon.com>
Co-authored-by: Ganesh Krishna Ramadurai <gramadur@icloud.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Bansi Kasundra <66969140+kasundra07@users.noreply.github.com>
Co-authored-by: Ethan Emoto <70109490+e-emoto@users.noreply.github.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
@Gankris96 @fahadshamiinsta
Fix tests for concurrent search with IndexRandomForConcurrentSearch f…
77adc67 
…ollow-up [opensearch-project#11130] (opensearch-project#11212)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@Gankris96 @rayshrey
Fix tests for concurrent search with IndexRandomForConcurrentSearch f…
623244a 
…ollow-up [opensearch-project#11130] (opensearch-project#11212)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@Gankris96 @shiv0408
Fix tests for concurrent search with IndexRandomForConcurrentSearch f…
9346a1c 
…ollow-up [opensearch-project#11130] (opensearch-project#11212)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jed326 jed326 jed326 approved these changes

@sohami sohami sohami approved these changes

@kkmr kkmr kkmr approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gankris96 @sohami @kkmr @jed326 @harishbhakuni